On Tue, 22 Jul 2025 19:53:39 GMT, Kevin Rushforth wrote:
>> This PR removes the terminally-deprecated `jdk.jsobject` module from the
>> JDK. This module is now shipped with JavaFX, and has been since JavaFX 24.
>>
>> The following files still reference `jdk.jsobject` (or the
>> `netscape.javas
On Wed, 23 Jul 2025 15:22:04 GMT, Hannes Wallnöfer wrote:
>> The list is used as list of external linkable modules/packages for the
>> `-linkoffline` option. Since the list is for JDK 17 the entry could be left
>> in the list, but as the test doesn't try to link to the module removing it
>> do
On Wed, 23 Jul 2025 14:33:34 GMT, Hannes Wallnöfer wrote:
>> @hns Would it be possible to confirm that it's okay to remove this from the
>> doclet tests?
>
> The list is used as list of external linkable modules/packages for the
> `-linkoffline` option. Since the list for JDK 17 the entry could
On Wed, 23 Jul 2025 05:55:11 GMT, Alan Bateman wrote:
>> As expected, the above test passes fine if I remove the jsobject entries
>> from `test/langtools/jdk/javadoc/doclet/testRecordTypes/jdk17/element-list`.
>> I'll go ahead and remove them, since it seems like good cleanup.
>
> @hns Would it
On Tue, 22 Jul 2025 19:41:39 GMT, Kevin Rushforth wrote:
>> I ran the test and then removed those lines and the test still passed.
>> I'd remove them to avoiding leaving a (little) mess behind.
>
> As expected, the above test passes fine if I remove the jsobject entries from
> `test/langtools/jd
On Tue, 22 Jul 2025 19:53:39 GMT, Kevin Rushforth wrote:
>> This PR removes the terminally-deprecated `jdk.jsobject` module from the
>> JDK. This module is now shipped with JavaFX, and has been since JavaFX 24.
>>
>> The following files still reference `jdk.jsobject` (or the
>> `netscape.javas
On Tue, 22 Jul 2025 19:53:39 GMT, Kevin Rushforth wrote:
>> This PR removes the terminally-deprecated `jdk.jsobject` module from the
>> JDK. This module is now shipped with JavaFX, and has been since JavaFX 24.
>>
>> The following files still reference `jdk.jsobject` (or the
>> `netscape.javas
On Tue, 22 Jul 2025 19:53:39 GMT, Kevin Rushforth wrote:
>> This PR removes the terminally-deprecated `jdk.jsobject` module from the
>> JDK. This module is now shipped with JavaFX, and has been since JavaFX 24.
>>
>> The following files still reference `jdk.jsobject` (or the
>> `netscape.javas
> This PR removes the terminally-deprecated `jdk.jsobject` module from the JDK.
> This module is now shipped with JavaFX, and has been since JavaFX 24.
>
> The following files still reference `jdk.jsobject` (or the
> `netscape.javascript` package). They are not modified because these files
> re
On Tue, 22 Jul 2025 18:48:59 GMT, Roger Riggs wrote:
>> I wondered about that, and originally was going to remove it, but then
>> noticed that the test in question parses the JDK 17 API docs (which does
>> have the `jdk.jsobject` module).
>>
>> https://github.com/openjdk/jdk/blob/e70c702d6f864
On Tue, 22 Jul 2025 18:44:40 GMT, Kevin Rushforth wrote:
>> test/langtools/jdk/javadoc/doclet/testModules/jdk/element-list line 305:
>>
>>> 303: jdk.jshell.spi
>>> 304: jdk.jshell.tool
>>> 305: module:jdk.jsobject
>>
>> There is a similar pair in
>> test/langtools/jdk/javadoc/doclet/testRecord
On Tue, 22 Jul 2025 15:13:44 GMT, Roger Riggs wrote:
>> This PR removes the terminally-deprecated `jdk.jsobject` module from the
>> JDK. This module is now shipped with JavaFX, and has been since JavaFX 24.
>>
>> The following files still reference `jdk.jsobject` (or the
>> `netscape.javascrip
On Tue, 22 Jul 2025 15:06:49 GMT, Alan Bateman wrote:
> I did a quick scan and the updates to the conf, the removal, and the test
> changes look okay. Happy to review the CSR when you have it ready.
Thanks. The CSR is now ready to review:
https://bugs.openjdk.org/browse/JDK-8362628
--
On Fri, 18 Jul 2025 16:58:14 GMT, Kevin Rushforth wrote:
> This PR removes the terminally-deprecated `jdk.jsobject` module from the JDK.
> This module is now shipped with JavaFX, and has been since JavaFX 24.
>
> The following files still reference `jdk.jsobject` (or the
> `netscape.javascript
On Fri, 18 Jul 2025 16:58:14 GMT, Kevin Rushforth wrote:
> This PR removes the terminally-deprecated `jdk.jsobject` module from the JDK.
> This module is now shipped with JavaFX, and has been since JavaFX 24.
>
> The following files still reference `jdk.jsobject` (or the
> `netscape.javascript
This PR removes the terminally-deprecated `jdk.jsobject` module from the JDK.
This module is now shipped with JavaFX, and has been since JavaFX 24.
The following files still reference `jdk.jsobject` (or the
`netscape.javascript` package). They are not modified because these files
reflect the st
On Fri, 18 Jul 2025 16:58:14 GMT, Kevin Rushforth wrote:
> This PR removes the terminally-deprecated `jdk.jsobject` module from the JDK.
> This module is now shipped with JavaFX, and has been since JavaFX 24.
>
> The following files still reference `jdk.jsobject` (or the
> `netscape.javascript
17 matches
Mail list logo
