Re: RFR: 8358538: Update GHA Windows runner to 2025 [v2]

2025-06-04 Thread Aleksey Shipilev
On Wed, 4 Jun 2025 17:03:07 GMT, Magnus Ihse Bursie wrote: >> GitHub is retiring the windows-2019 runner, starting with brownouts now, and >> complete removal in about a month. We need to upgrade to Windows 2022 or >> possible Windows 2025. > > Magnus Ihse Bursie has updated the pull request in

Re: RFR: 8358538: Update GHA Windows runner to 2025

2025-06-04 Thread Aleksey Shipilev
On Tue, 3 Jun 2025 19:56:37 GMT, Magnus Ihse Bursie wrote: > GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. Pretty sure it will just work (tm). I'll hang around for

Re: RFR: 8358538: Update GHA Windows runner to 2025 [v2]

2025-06-04 Thread Aleksey Shipilev
On Wed, 4 Jun 2025 16:55:12 GMT, Magnus Ihse Bursie wrote: >> .github/workflows/main.yml line 313: >> >>> 311: with: >>> 312: platform: windows-x64 >>> 313: msvc-toolset-version: '14.43' >> >> I wish I understood why `14.43`, since I don't see any reference to it in >> current

Re: RFR: 8358538: Update GHA Windows runner to 2025 [v2]

2025-06-04 Thread Magnus Ihse Bursie
> GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8358538: Update GHA Windows runner to 2025 [v2]

2025-06-04 Thread Magnus Ihse Bursie
On Wed, 4 Jun 2025 11:24:45 GMT, Aleksey Shipilev wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update windows version for testing > > .github/workflows/main.yml line 313: > >> 311: with: >> 312:

Re: RFR: 8358538: Update GHA Windows runner to 2025

2025-06-04 Thread Magnus Ihse Bursie
On Wed, 4 Jun 2025 13:06:07 GMT, Andrew John Hughes wrote: > There's another case of WIndows 2019 in `main.xml` for `test-windows-x64` not > fixed here, which is why the testing is stalled. Oh bummer, I did not see that. Fingers crossed that it's enough to just bump that number. -

Re: RFR: 8358538: Update GHA Windows runner to 2025

2025-06-04 Thread Andrew John Hughes
On Tue, 3 Jun 2025 19:56:37 GMT, Magnus Ihse Bursie wrote: > GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. There's another case of WIndows 2019 in `main.xml` for `

Re: RFR: 8358538: Update GHA Windows runner to 2025

2025-06-04 Thread Aleksey Shipilev
On Tue, 3 Jun 2025 19:56:37 GMT, Magnus Ihse Bursie wrote: > GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. .github/workflows/main.yml line 313: > 311: with: >

Re: RFR: 8358538: Update GHA Windows runner to 2025

2025-06-03 Thread Magnus Ihse Bursie
On Tue, 3 Jun 2025 19:56:37 GMT, Magnus Ihse Bursie wrote: > GitHub is retiring the windows-2019 runner, starting with brownouts now, and > complete removal in about a month. We need to upgrade to Windows 2022 or > possible Windows 2025. Also, for the record, fixing stuff like this for GHA whe

RFR: 8358538: Update GHA Windows runner to 2025

2025-06-03 Thread Magnus Ihse Bursie
GitHub is retiring the windows-2019 runner, starting with brownouts now, and complete removal in about a month. We need to upgrade to Windows 2022 or possible Windows 2025. - Commit messages: - now can we please restore configure option? - maybe 14.43 is installed? - remove tools