On Mon, 28 Apr 2025 13:47:47 GMT, Erik Joelsson wrote:
>> kuaiwei has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Get SDK_INSTALL_DIR from enviroment variable
>
> Verified that it still works in Cygwin on my machine. Looks good.
@erikj7
On Tue, 29 Apr 2025 03:38:33 GMT, kuaiwei wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d
>> "d:/VisualStuio"]` . The path must be converted as linux style before
>>
On Tue, 29 Apr 2025 03:38:33 GMT, kuaiwei wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d
>> "d:/VisualStuio"]` . The path must be converted as linux style before
>>
On Mon, 28 Apr 2025 19:30:23 GMT, Magnus Ihse Bursie wrote:
>> kuaiwei has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Get SDK_INSTALL_DIR from enviroment variable
>
> make/devkit/createWindowsDevkit.sh line 69:
>
>> 67: elif test "x$IS
> The patch fix error when creating devkit on wsl/msys2 .
> * Msys2 can be supported like cygwin
> * In wsl, it can not test path name in windows format, like `if [ -d
> "d:/VisualStuio"]` . The path must be converted as linux style before testing.
> * In msys2, `cmd.exe /c` doesn't work because "
On Mon, 28 Apr 2025 16:19:09 GMT, Frederic Thevenet
wrote:
> **Please note that this is not a formal review, as I am not an OpenJDK
> reviewer.**
>
> `createWindowsDevkit.sh` will fail to run when MSYS2 is started under any
> other environment[1] other than "MSYS" (i.e. `MINGW64`, `UCRT64`, `
On Mon, 28 Apr 2025 13:34:29 GMT, kuaiwei wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d
>> "d:/VisualStuio"]` . The path must be converted as linux style before
>>
On Mon, 28 Apr 2025 13:34:29 GMT, kuaiwei wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d
>> "d:/VisualStuio"]` . The path must be converted as linux style before
>>
On Mon, 28 Apr 2025 13:34:29 GMT, kuaiwei wrote:
>> The patch fix error when creating devkit on wsl/msys2 .
>> * Msys2 can be supported like cygwin
>> * In wsl, it can not test path name in windows format, like `if [ -d
>> "d:/VisualStuio"]` . The path must be converted as linux style before
>>
> The patch fix error when creating devkit on wsl/msys2 .
> * Msys2 can be supported like cygwin
> * In wsl, it can not test path name in windows format, like `if [ -d
> "d:/VisualStuio"]` . The path must be converted as linux style before testing.
> * In msys2, `cmd.exe /c` doesn't work because "
The patch fix error when creating devkit on wsl/msys2 .
* Msys2 can be supported like cygwin
* In wsl, it can not test path name in windows format, like `d:/VisualStuio` .
The path must be converted as linux style.
* In msys2, `cmd.exe /c` doesn't work because "/c" is converted as "c:", it can
be
11 matches
Mail list logo
