Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v3]

2025-04-28 Thread Chen Liang
> Perf numbers for simple main: > Linking of `Class::forName0` down from ~152 to ~83 > > For calling little color management system > https://bugs.openjdk.org/browse/JDK-8313344: > JNI: ~45 > baseline panama: ~164 > patch: ~103 > > Also see #24705. Chen Liang has updated the pull request with a

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-28 Thread Chen Liang
On Mon, 28 Apr 2025 13:50:17 GMT, Chen Liang wrote: >> make/jdk/src/classes/build/tools/classlist/HelloClasslist.java line 184: >> >>> 182: ADDRESS, ADDRESS, ADDRESS, >>> 183: JAVA_BOOLEAN, ADDRESS, ADDRESS); >>> 184: Linker.nativeLinker().downcallHandle(s

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-28 Thread Chen Liang
On Mon, 28 Apr 2025 13:40:47 GMT, Jorn Vernee wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify FFM linker warmup > > make/jdk/src/classes/build/tools/classlist/HelloClasslist.java line 184: > >> 182:

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-28 Thread Jorn Vernee
On Fri, 18 Apr 2025 18:25:54 GMT, Chen Liang wrote: >> Perf numbers for simple main: >> Linking of `Class::forName0` down from ~152 to ~83 >> >> For calling little color management system >> https://bugs.openjdk.org/browse/JDK-8313344: >> JNI: ~45 >> baseline panama: ~164 >> patch: ~103 >> >>

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-28 Thread Chen Liang
On Mon, 28 Apr 2025 11:51:23 GMT, Maurizio Cimadamore wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify FFM linker warmup > > src/java.base/share/classes/jdk/internal/foreign/abi/NativeEntryPoint.java > line

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-28 Thread Maurizio Cimadamore
On Fri, 18 Apr 2025 18:25:54 GMT, Chen Liang wrote: >> Perf numbers for simple main: >> Linking of `Class::forName0` down from ~152 to ~83 >> >> For calling little color management system >> https://bugs.openjdk.org/browse/JDK-8313344: >> JNI: ~45 >> baseline panama: ~164 >> patch: ~103 >> >>

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-22 Thread Chen Liang
On Tue, 22 Apr 2025 08:03:30 GMT, Viktor Klang wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify FFM linker warmup > > src/java.base/share/classes/jdk/internal/foreign/abi/LinkerOptions.java line > 149: > >>

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-22 Thread Chen Liang
On Tue, 22 Apr 2025 08:03:19 GMT, Viktor Klang wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Simplify FFM linker warmup > > src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java line > 78: > >>

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-22 Thread Viktor Klang
On Fri, 18 Apr 2025 18:25:54 GMT, Chen Liang wrote: >> Perf numbers for simple main: >> Linking of `Class::forName0` down from ~152 to ~83 >> >> For calling little color management system >> https://bugs.openjdk.org/browse/JDK-8313344: >> JNI: ~45 >> baseline panama: ~164 >> patch: ~103 >> >>

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-18 Thread Chen Liang
On Fri, 18 Apr 2025 18:15:09 GMT, Jorn Vernee wrote: >> So just `Linker.nativeLinker().downcallHandle(MemorySegment.ofArray(new >> byte[0]), signature)` suffices? > > Yes, that would work, but I was thinking just > `Linker.nativeLinker().downcallHandle(signature)` Yep, simplified this, the sta

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall [v2]

2025-04-18 Thread Chen Liang
> Perf numbers for simple main: > Linking of `Class::forName0` down from ~152 to ~83 > > For calling little color management system > https://bugs.openjdk.org/browse/JDK-8313344: > JNI: ~45 > baseline panama: ~164 > patch: ~103 > > Also see #24705. Chen Liang has updated the pull request increm

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall

2025-04-18 Thread Jorn Vernee
On Fri, 18 Apr 2025 17:56:53 GMT, Chen Liang wrote: >> make/jdk/src/classes/build/tools/classlist/HelloClasslist.java line 190: >> >>> 188: JAVA_BOOLEAN, ADDRESS, ADDRESS); >>> 189: Optional symbol = >>> lookup.find("Java_java_lang_Class_forName0"); >>> 190: var

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall

2025-04-18 Thread Chen Liang
On Fri, 18 Apr 2025 17:49:35 GMT, Jorn Vernee wrote: >> Perf numbers for simple main: >> Linking of `Class::forName0` down from ~152 to ~83 >> >> For calling little color management system >> https://bugs.openjdk.org/browse/JDK-8313344: >> JNI: ~45 >> baseline panama: ~164 >> patch: ~103 >> >>

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall

2025-04-18 Thread Jorn Vernee
On Thu, 17 Apr 2025 19:44:07 GMT, Chen Liang wrote: > Perf numbers for simple main: > Linking of `Class::forName0` down from ~152 to ~83 > > For calling little color management system > https://bugs.openjdk.org/browse/JDK-8313344: > JNI: ~45 > baseline panama: ~164 > patch: ~103 > > Also see #

Re: RFR: 8354996: Reduce dynamic code generation for a single downcall

2025-04-17 Thread Chen Liang
On Thu, 17 Apr 2025 19:44:07 GMT, Chen Liang wrote: > Perf numbers for simple main: > Linking of `Class::forName0` down from ~152 to ~83 > > For calling little color management system > https://bugs.openjdk.org/browse/JDK-8313344: > JNI: ~45 > baseline panama: ~164 > patch: ~103 > > Also see #

RFR: 8354996: Reduce dynamic code generation for a single downcall

2025-04-17 Thread Chen Liang
Perf numbers for simple main: Linking of `Class::forName0` down from ~152 to ~83 For calling little color management system https://bugs.openjdk.org/browse/JDK-8313344: JNI: ~45 baseline panama: ~164 patch: ~103 Also see #24705. - Commit messages: - Merge branch 'master' of https: