This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
include statements in C++ files are sorted alphabetically and that there's at
least one blank line between user and sys includes (as per the [style
guide](https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Tue, 25 Mar 2025 22:19:39 GMT, Doug Simon wrote:
>> src/hotspot/share/opto/output.cpp line 39:
>>
>>> 37: #include "opto/block.hpp"
>>> 38: #include "opto/c2_MacroAssembler.hpp"
>>> 39: #include "opto/c2compiler.hpp"
>>
>> Hmm.
>>
>> #include "opto/c2_MacroAssembler.hpp"
>> #include "opto/c
On Tue, 25 Mar 2025 21:19:03 GMT, Doug Simon wrote:
> Thanks for all the comments so far.
>
> First thing is that my tool does nothing about re-ordering block of
> conditional includes vs unconditional includes. I briefly looked into that
> but it gets very complicated, very quickly. That kind
On Tue, 25 Mar 2025 21:24:41 GMT, Doug Simon wrote:
>> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks
>> of include statements in C++ files are sorted alphabetically and that
>> there's at least one blank line between user and sys includes (as per the
>> [style
>>
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Tue, 25 Mar 2025 20:27:21 GMT, Stefan Karlsson wrote:
>> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks
>> of include statements in C++ files are sorted alphabetically and that
>> there's at least one blank line between user and sys includes (as per the
>> [style
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Tue, 25 Mar 2025 14:52:56 GMT, Magnus Ihse Bursie wrote:
>> I pushed a commit that prevents the re-ordering:
>> https://github.com/openjdk/jdk/pull/24180/commits/c0f202d2a7e7b8788719fe8cd2a4c7a095ecd3bb
>
> My gut reaction is that header files should be self-sustaining, that is if
> they nee
On Tue, 25 Mar 2025 14:56:27 GMT, Magnus Ihse Bursie wrote:
> Did you consider writing the tool in Java? Or rather, could you be convinced
> to convert it to Java? With the source code launch mechanism, it is just as
> simple to run as a python script. Also, there is some kind of optics about i
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Tue, 25 Mar 2025 12:06:42 GMT, Doug Simon wrote:
>> src/hotspot/cpu/aarch64/immediate_aarch64.cpp line 26:
>>
>>> 24: */
>>> 25:
>>> 26: #include
>>
>> Moving these sys includes causes a build failure:
>> https://github.com/dougxc/jdk/actions/runs/14054959680/job/39352322113#step:12:537
On Tue, 25 Mar 2025 09:16:15 GMT, Doug Simon wrote:
>> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks
>> of include statements in C++ files are sorted alphabetically and that
>> there's at least one blank line between user and sys includes (as per the
>> [style
>>
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
16 matches
Mail list logo
