Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-16 Thread Matthias Baesken
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , Thanks for the reviews ! - PR Comment: htt

Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Kevin Walls
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , We know GetOptionalSupport can't realistically fail, unl

Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , Build changes look good to me. - Marked as

Re: RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Matthias Baesken
On Fri, 14 Mar 2025 10:06:32 GMT, Matthias Baesken wrote: > We switched off unused-variable warnings for the file VMManagementImpl.c, > this should be avoided. > This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , In case someone has a good/better idea what to do with t

RFR: 8351821: VMManagementImpl.c avoid switching off warnings

2025-03-14 Thread Matthias Baesken
We switched off unused-variable warnings for the file VMManagementImpl.c, this should be avoided. This came up in [JDK-8351542](https://bugs.openjdk.org/browse/JDK-8351542) , - Commit messages: - JDK-8351821 Changes: https://git.openjdk.org/jdk/pull/24052/files Webrev: https://we