Re: RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-03-11 Thread Magnus Ihse Bursie
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote: > Please review the test fix that removes `libVThreadEventTest` explicit > dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in > `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With > the chang

Re: RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-03-07 Thread Jiangli Zhou
On Mon, 3 Mar 2025 17:36:00 GMT, Jiangli Zhou wrote: >> Please review the test fix that removes `libVThreadEventTest` explicit >> dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in >> `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With >> the ch

Re: RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-03-07 Thread Magnus Ihse Bursie
On Mon, 3 Mar 2025 17:36:00 GMT, Jiangli Zhou wrote: >> Please review the test fix that removes `libVThreadEventTest` explicit >> dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in >> `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With >> the ch

Re: RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-03-03 Thread Jiangli Zhou
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote: > Please review the test fix that removes `libVThreadEventTest` explicit > dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in > `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With > the chang

Re: RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-03-03 Thread Alan Bateman
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote: > Please review the test fix that removes `libVThreadEventTest` explicit > dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in > `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With > the chang

Re: RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-03-02 Thread David Holmes
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote: > Please review the test fix that removes `libVThreadEventTest` explicit > dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in > `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With > the chang

Re: RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-02-27 Thread mScott224
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote: > Please review the test fix that removes `libVThreadEventTest` explicit > dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in > `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With > the chang

Re: RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-02-27 Thread mScott224
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote: > Please review the test fix that removes `libVThreadEventTest` explicit > dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in > `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With > the chang

RFR: 8350903: Remove explicit libjvm.so dependency for libVThreadEventTest

2025-02-27 Thread Jiangli Zhou
Please review the test fix that removes `libVThreadEventTest` explicit dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With the change, `libVThreadEventTest` no longer needs to be linked with `libj