Re: RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools [v2]

2025-02-20 Thread Nizar Benalla
On Wed, 19 Feb 2025 16:05:15 GMT, Nizar Benalla wrote: >> This patch fixes a regression where the windows tools man pages appeared on >> the Linux and the MacOS builds >> >> The man pages found using `FindModuleManDirs` were used in both `Docs.gmk` >> used to generate the documentation for the

Re: RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools [v2]

2025-02-20 Thread Ian Myers
On Thu, 20 Feb 2025 15:52:19 GMT, Nizar Benalla wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> respond to feedback > > Thanks for reviewing Erik. Thank you @nizarbenalla and @erikj79 for resolving this! ---

Re: RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools [v2]

2025-02-19 Thread Erik Joelsson
On Wed, 19 Feb 2025 16:05:15 GMT, Nizar Benalla wrote: >> This patch fixes a regression where the windows tools man pages appeared on >> the Linux and the MacOS builds >> >> The man pages found using `FindModuleManDirs` were used in both `Docs.gmk` >> used to generate the documentation for the

Re: RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools [v2]

2025-02-19 Thread Nizar Benalla
> This patch fixes a regression where the windows tools man pages appeared on > the Linux and the MacOS builds > > The man pages found using `FindModuleManDirs` were used in both `Docs.gmk` > used to generate the documentation for the JDK as well as in > `LauncherCommon.gmk` here > https://git

Re: RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools

2025-02-19 Thread Erik Joelsson
On Wed, 19 Feb 2025 14:34:37 GMT, Nizar Benalla wrote: > This patch fixes a regression where the windows tools man pages appeared on > the Linux and the MacOS builds > > The man pages found using `FindModuleManDirs` were used in both `Docs.gmk` > used to generate the documentation for the JDK

RFR: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools

2025-02-19 Thread Nizar Benalla
This patch fixes a regression where the windows tools man pages appeared on the Linux and the MacOS builds The man pages found using `FindModuleManDirs` were used in both `Docs.gmk` used to generate the documentation for the JDK as well as in `LauncherCommon.gmk` here https://github.com/openjd