Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Jiangli Zhou
On Wed, 12 Feb 2025 19:33:15 GMT, Phil Race wrote: > Looks like you will have to more fully copy the pattern in the dynamic > linking case. Yeah, we still have to call it using the function address for the static case. I sent https://github.com/openjdk/jdk/pull/23600. - PR Comme

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Phil Race
On Wed, 12 Feb 2025 00:02:22 GMT, Jiangli Zhou wrote: > Please review the change that looks up `FT_Property_Set` from the current > executable first when running on static JDK. If `FT_Property_Set` can be > found, don't `dlopen` `libfreetype.so`. If a bundled `libfreetype` is > statically link

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Jiangli Zhou
On Wed, 12 Feb 2025 18:54:17 GMT, Mikael Vidstedt wrote: > I can confirm that `FT_Property_Set` does not seem to be there at all in the > (older?) version of freetype from OL6.4. Thanks for confirming! - PR Comment: https://git.openjdk.org/jdk/pull/23574#issuecomment-2654591105

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Mikael Vidstedt
On Wed, 12 Feb 2025 00:02:22 GMT, Jiangli Zhou wrote: > Please review the change that looks up `FT_Property_Set` from the current > executable first when running on static JDK. If `FT_Property_Set` can be > found, don't `dlopen` `libfreetype.so`. If a bundled `libfreetype` is > statically link

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Jiangli Zhou
On Wed, 12 Feb 2025 18:37:11 GMT, Henry Jen wrote: >> Please review the change that looks up `FT_Property_Set` from the current >> executable first when running on static JDK. If `FT_Property_Set` can be >> found, don't `dlopen` `libfreetype.so`. If a bundled `libfreetype` is >> statically lin

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Mikael Vidstedt
On Wed, 12 Feb 2025 00:02:22 GMT, Jiangli Zhou wrote: > Please review the change that looks up `FT_Property_Set` from the current > executable first when running on static JDK. If `FT_Property_Set` can be > found, don't `dlopen` `libfreetype.so`. If a bundled `libfreetype` is > statically link

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Jiangli Zhou
On Wed, 12 Feb 2025 18:17:16 GMT, Jiangli Zhou wrote: > This broke our builds: > > ``` > /jdk_git/open/src/java.desktop/share/native/libfontmanager/freetypeScaler.c: > In function 'setInterpreterVersion': > /jdk_git/open/src/java.desktop/share/native/libfontmanager/freetypeScaler.c:307:9: > er

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Henry Jen
On Wed, 12 Feb 2025 00:02:22 GMT, Jiangli Zhou wrote: > Please review the change that looks up `FT_Property_Set` from the current > executable first when running on static JDK. If `FT_Property_Set` can be > found, don't `dlopen` `libfreetype.so`. If a bundled `libfreetype` is > statically link

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Jiangli Zhou
On Wed, 12 Feb 2025 17:24:08 GMT, Vladimir Kozlov wrote: > This broke our builds: > > ``` > /jdk_git/open/src/java.desktop/share/native/libfontmanager/freetypeScaler.c: > In function 'setInterpreterVersion': > /jdk_git/open/src/java.desktop/share/native/libfontmanager/freetypeScaler.c:307:9: >

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Jiangli Zhou
On Wed, 12 Feb 2025 17:24:39 GMT, Vladimir Kozlov wrote: > I don't see GHA testing enabled for this repo. GHA testing is enabled: https://github.com/openjdk/jdk/pull/23574/checks. All tests passed in GHA. - PR Comment: https://git.openjdk.org/jdk/pull/23574#issuecomment-2654440345

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Vladimir Kozlov
On Wed, 12 Feb 2025 00:02:22 GMT, Jiangli Zhou wrote: > Please review the change that looks up `FT_Property_Set` from the current > executable first when running on static JDK. If `FT_Property_Set` can be > found, don't `dlopen` `libfreetype.so`. If a bundled `libfreetype` is > statically link

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-12 Thread Jiangli Zhou
On Wed, 12 Feb 2025 05:07:08 GMT, Phil Race wrote: >> Please review the change that looks up `FT_Property_Set` from the current >> executable first when running on static JDK. If `FT_Property_Set` can be >> found, don't `dlopen` `libfreetype.so`. If a bundled `libfreetype` is >> statically lin

Re: RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-11 Thread Phil Race
On Wed, 12 Feb 2025 00:02:22 GMT, Jiangli Zhou wrote: > Please review the change that looks up `FT_Property_Set` from the current > executable first when running on static JDK. If `FT_Property_Set` can be > found, don't `dlopen` `libfreetype.so`. If a bundled `libfreetype` is > statically link

RFR: 8349859: Support static JDK in libfontmanager/freetypeScaler.c

2025-02-11 Thread Jiangli Zhou
Please review the change that looks up `FT_Property_Set` from the current executable first when running on static JDK. If `FT_Property_Set` can be found, don't `dlopen` `libfreetype.so`. If a bundled `libfreetype` is statically linked with the launcher executable (on static JDK), `FT_Property_Se