Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-13 Thread Matthias Baesken
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-12 Thread Harshitha Onkar
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-12 Thread Matthias Baesken
On Fri, 7 Feb 2025 22:45:15 GMT, Harshitha Onkar wrote: >>> What tests have you run? >> >> Had this in our internal test queue with jtreg / JCK plus some additional >> SAP internal tests. No issues seen. >> However I think I have to run some more manual tests on client like setups. >> >> Un

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-11 Thread Harshitha Onkar
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-10 Thread Phil Race
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-09 Thread Matthias Baesken
On Sun, 9 Feb 2025 14:39:13 GMT, Matthias Baesken wrote: >> I note that AIX seems to be the biggest beneficiary here. It doesn't seem to >> be a big deal for anything else. >> >> I think what we are looking for in testing is no functional regression plus >> minimal perf impact on startup. >> B

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-09 Thread Matthias Baesken
On Sat, 8 Feb 2025 04:10:24 GMT, Phil Race wrote: > I note that AIX seems to be the biggest beneficiary here. It doesn't seem to > be a big deal for anything else. Please note that AIX has the debuginfo in the same binary (.so file), unlike e.g. Linux. If you look at the size reduction of the

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Phil Race
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Harshitha Onkar
On Fri, 7 Feb 2025 14:11:15 GMT, Matthias Baesken wrote: >> What tests have you run? > >> What tests have you run? > > Had this in our internal test queue with jtreg / JCK plus some additional > SAP internal tests. No issues seen. > However I think I have to run some more manual tests on clien

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Matthias Baesken
On Fri, 7 Feb 2025 13:08:17 GMT, Magnus Ihse Bursie wrote: > What tests have you run? Had this in our internal test queue with jtreg / JCK plus some additional SAP internal tests. No issues seen. However I think I have to run some more manual tests on client like setups. Unfortunately my Li

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Magnus Ihse Bursie
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-07 Thread Matthias Baesken
On Thu, 6 Feb 2025 14:03:16 GMT, Erik Joelsson wrote: >> The splashscreen lib is currently built with LOW optimization. >> This might be fine because it is not very performance critical (and LOW is >> not really low when looking at the opt-flags used). >> But building it with SIZE optimization

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-06 Thread Matthias Baesken
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

Re: RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-06 Thread Erik Joelsson
On Thu, 6 Feb 2025 13:52:49 GMT, Matthias Baesken wrote: > The splashscreen lib is currently built with LOW optimization. > This might be fine because it is not very performance critical (and LOW is > not really low when looking at the opt-flags used). > But building it with SIZE optimization m

RFR: 8349378: Build splashscreen lib with SIZE optimization

2025-02-06 Thread Matthias Baesken
The splashscreen lib is currently built with LOW optimization. This might be fine because it is not very performance critical (and LOW is not really low when looking at the opt-flags used). But building it with SIZE optimization makes it 10-20 % smaller on some platforms which helps to reduce im