On Tue, 21 Jan 2025 12:41:13 GMT, Stefan Karlsson wrote:
> Before [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) we had to
> remove the include lines in precompiled.hpp when precompiled headers were
> turned off. This was done by defining DONT_USE_PRECOMPILED_HEADER.
>
> After [JDK
On Tue, 21 Jan 2025 12:41:13 GMT, Stefan Karlsson wrote:
> Before [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) we had to
> remove the include lines in precompiled.hpp when precompiled headers were
> turned off. This was done by defining DONT_USE_PRECOMPILED_HEADER.
>
> After [JDK
On Tue, 21 Jan 2025 15:49:05 GMT, Stefan Karlsson wrote:
> > I can see more `DONT_USE_PRECOMPILED_HEADER` uses in `test/hotspot/gtest`,
> > take a look at those?
>
> There shouldn't be. Are you looking at the latest sources? I removed some of
> those in an earlier PR today.
Ah. Yes, I was loo
On Tue, 21 Jan 2025 12:41:13 GMT, Stefan Karlsson wrote:
> Before [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) we had to
> remove the include lines in precompiled.hpp when precompiled headers were
> turned off. This was done by defining DONT_USE_PRECOMPILED_HEADER.
>
> After [JDK
On Tue, 21 Jan 2025 15:03:33 GMT, Aleksey Shipilev wrote:
> I can see more `DONT_USE_PRECOMPILED_HEADER` uses in `test/hotspot/gtest`,
> take a look at those?
There shouldn't be. Are you looking at the latest sources? I removed some of
those in an earlier PR today.
-
PR Comment:
On Tue, 21 Jan 2025 12:41:13 GMT, Stefan Karlsson wrote:
> Before [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) we had to
> remove the include lines in precompiled.hpp when precompiled headers were
> turned off. This was done by defining DONT_USE_PRECOMPILED_HEADER.
>
> After [JDK
On Tue, 21 Jan 2025 12:41:13 GMT, Stefan Karlsson wrote:
> Before [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) we had to
> remove the include lines in precompiled.hpp when precompiled headers were
> turned off. This was done by defining DONT_USE_PRECOMPILED_HEADER.
>
> After [JDK
Before [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) we had to
remove the include lines in precompiled.hpp when precompiled headers were
turned off. This was done by defining DONT_USE_PRECOMPILED_HEADER.
After [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) we simply
don
