On Wed, 22 Jan 2025 09:34:18 GMT, Stefan Karlsson wrote:
>> [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) removed the need
>> for HotSpot devs to include the precompiled.hpp. This is the PR to reflect
>> that.
>>
>> I know that there is some process around updating the style guide
On Wed, 22 Jan 2025 09:34:18 GMT, Stefan Karlsson wrote:
>> [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) removed the need
>> for HotSpot devs to include the precompiled.hpp. This is the PR to reflect
>> that.
>>
>> I know that there is some process around updating the style guide
> [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) removed the need
> for HotSpot devs to include the precompiled.hpp. This is the PR to reflect
> that.
>
> I know that there is some process around updating the style guide, but I
> can't find it, so I'm starting with a plain PR.
Stef
On Tue, 21 Jan 2025 12:29:33 GMT, Stefan Karlsson wrote:
> [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) removed the need
> for HotSpot devs to include the precompiled.hpp. This is the PR to reflect
> that.
>
> I know that there is some process around updating the style guide, but
On Tue, 21 Jan 2025 15:54:06 GMT, Stefan Karlsson wrote:
> Maybe something like this:
>
> * Some build configurations uses precompiled headers to speed up the
> build times. The compiled headers are included in the precompiled.hpp file.
> Note that precompiled.hpp is just a build time opti
On Tue, 21 Jan 2025 15:08:39 GMT, Aleksey Shipilev wrote:
> This part looks dangling now:
>
> ```
> * precompiled.hpp is just a build time optimization, so don't rely on
> it to resolve include problems.
> ```
>
> Maybe move the line at the end of the list and phrase it as:
>
> "* Consider ad
On Tue, 21 Jan 2025 12:29:33 GMT, Stefan Karlsson wrote:
> [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) removed the need
> for HotSpot devs to include the precompiled.hpp. This is the PR to reflect
> that.
>
> I know that there is some process around updating the style guide, but
On Tue, 21 Jan 2025 12:29:33 GMT, Stefan Karlsson wrote:
> [JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) removed the need
> for HotSpot devs to include the precompiled.hpp. This is the PR to reflect
> that.
>
> I know that there is some process around updating the style guide, but
[JDK-8347909](https://bugs.openjdk.org/browse/JDK-8347909) removed the need for
HotSpot devs to include the precompiled.hpp. This is the PR to reflect that.
I know that there is some process around updating the style guide, but I can't
find it, so I'm starting with a plain PR.
-
Co
