Re: RFR: 8346987: [lto] gtest build fails

2025-02-25 Thread Magnus Ihse Bursie
On Mon, 24 Feb 2025 11:38:40 GMT, Matthias Baesken wrote: >>> I'll try to prioritize separating gtest and hotspot builds, and then it >>> will be possible to fix this in a clean way. >> >> Okay thanks, then let's wait a bit for your change separating gtest and >> hotspot builds, if this helps

Re: RFR: 8346987: [lto] gtest build fails

2025-02-24 Thread Thomas Stuefe
On Fri, 24 Jan 2025 17:22:46 GMT, Magnus Ihse Bursie wrote: >> When building with link time optimization (lto) , configure flag is >> --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of >> errors. >> One workaround is just to configure without gtest ; this one changes t

Re: RFR: 8346987: [lto] gtest build fails

2025-02-24 Thread Matthias Baesken
On Mon, 27 Jan 2025 07:59:24 GMT, Matthias Baesken wrote: > I'll try to prioritize separating gtest and hotspot builds, and then it will > be possible to fix this in a clean way. Hi @magicus was there some progress on this topic ? - PR Comment: https://git.openjdk.org/jdk/pull/231

Re: RFR: 8346987: [lto] gtest build fails

2025-01-27 Thread Matthias Baesken
On Fri, 24 Jan 2025 17:22:46 GMT, Magnus Ihse Bursie wrote: > I'll try to prioritize separating gtest and hotspot builds, and then it will > be possible to fix this in a clean way. Okay thanks, then let's wait a bit for your change separating gtest and hotspot builds, if this helps to make th

Re: RFR: 8346987: [lto] gtest build fails

2025-01-24 Thread Magnus Ihse Bursie
On Fri, 17 Jan 2025 11:41:06 GMT, Matthias Baesken wrote: > When building with link time optimization (lto) , configure flag is > --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of > errors. > One workaround is just to configure without gtest ; this one changes the mak

Re: RFR: 8346987: [lto] gtest build fails

2025-01-24 Thread Magnus Ihse Bursie
On Fri, 17 Jan 2025 11:41:06 GMT, Matthias Baesken wrote: > When building with link time optimization (lto) , configure flag is > --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of > errors. > One workaround is just to configure without gtest ; this one changes the mak

Re: RFR: 8346987: [lto] gtest build fails

2025-01-22 Thread Matthias Baesken
On Tue, 21 Jan 2025 16:32:05 GMT, Magnus Ihse Bursie wrote: > Hm, I wonder why...? >From what I see the JVM_CFLAGS_FEATURES / JVM_LDFLAGS_FEATURES are set prior >to this 'filtering out' effort. Maybe it would work with additionally rearranging somehow the makefile inclusion order ? -

Re: RFR: 8346987: [lto] gtest build fails

2025-01-21 Thread Magnus Ihse Bursie
On Fri, 17 Jan 2025 11:41:06 GMT, Matthias Baesken wrote: > When building with link time optimization (lto) , configure flag is > --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of > errors. > One workaround is just to configure without gtest ; this one changes the mak

Re: RFR: 8346987: [lto] gtest build fails

2025-01-21 Thread Matthias Baesken
On Tue, 21 Jan 2025 12:03:14 GMT, Magnus Ihse Bursie wrote: >> When building with link time optimization (lto) , configure flag is >> --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of >> errors. >> One workaround is just to configure without gtest ; this one changes t

Re: RFR: 8346987: [lto] gtest build fails

2025-01-21 Thread Magnus Ihse Bursie
On Fri, 17 Jan 2025 11:41:06 GMT, Matthias Baesken wrote: > When building with link time optimization (lto) , configure flag is > --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of > errors. > One workaround is just to configure without gtest ; this one changes the mak

Re: RFR: 8346987: [lto] gtest build fails

2025-01-21 Thread Matthias Baesken
On Mon, 20 Jan 2025 16:32:11 GMT, Magnus Ihse Bursie wrote: > Is the problem that LTO does not work with gtest, and this has not yet been > fixed? Or is it supposed to never work, due to how LTO and gtest interact? LTO does not work currently with gtest; maybe it could be fixed. Not sure how.

Re: RFR: 8346987: [lto] gtest build fails

2025-01-20 Thread Magnus Ihse Bursie
On Fri, 17 Jan 2025 11:41:06 GMT, Matthias Baesken wrote: > When building with link time optimization (lto) , configure flag is > --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of > errors. > One workaround is just to configure without gtest ; this one changes the mak

Re: RFR: 8346987: [lto] gtest build fails

2025-01-20 Thread Julian Waters
On Mon, 20 Jan 2025 16:32:11 GMT, Magnus Ihse Bursie wrote: > Is it possible to modify the set of JVM Features to not include > `link-time-opt` when building gtest? I don't recall the exact flow of this, > so it might not be possible. But if it is, I think it is a better solution. Wouldn't tha

Re: RFR: 8346987: [lto] gtest build fails

2025-01-20 Thread Magnus Ihse Bursie
On Fri, 17 Jan 2025 11:41:06 GMT, Matthias Baesken wrote: > When building with link time optimization (lto) , configure flag is > --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of > errors. > One workaround is just to configure without gtest ; this one changes the mak

RFR: 8346987: [lto] gtest build fails

2025-01-17 Thread Matthias Baesken
When building with link time optimization (lto) , configure flag is --enable-jvm-feature-link-time-opt , we run in the gtest build into a lot of errors. One workaround is just to configure without gtest ; this one changes the make to NOT use the lto build flags for gtest , just for the "normal"