Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Erik Joelsson
On Fri, 20 Dec 2024 13:11:22 GMT, Magnus Ihse Bursie wrote: >> When the static launcher was introduced in >> [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and >> resource constraints, it was only working properly on Linux and macOS, while >> the Windows port compiled

Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Magnus Ihse Bursie
On Fri, 20 Dec 2024 13:05:53 GMT, Magnus Ihse Bursie wrote: >> src/java.desktop/windows/native/libawt/windows/awt_Mlib.cpp line 53: >> >>> 51: */ >>> 52: if (JVM_IsStaticallyLinked()) { >>> 53: hDLL = ::GetModuleHandle(NULL); >> >> So this returns a handle to the pr

Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Magnus Ihse Bursie
On Thu, 19 Dec 2024 22:10:29 GMT, Erik Joelsson wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix comment > > src/hotspot/os/windows/os_windows.cpp line 316: > >> 314: } >> 315: >> 316: //

Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Magnus Ihse Bursie
> When the static launcher was introduced in > [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and > resource constraints, it was only working properly on Linux and macOS, while > the Windows port compiled but did not work. Now the time has come to fix that. > > Most of

Re: RFR: 8346377: Properly support static builds for Windows [v2]

2024-12-20 Thread Magnus Ihse Bursie
On Thu, 19 Dec 2024 21:52:10 GMT, Phil Race wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix comment > > src/java.desktop/windows/native/libawt/windows/awt_Mlib.cpp line 53: > >> 51: */ >> 52:

Re: RFR: 8346377: Properly support static builds for Windows

2024-12-20 Thread Magnus Ihse Bursie
On Thu, 19 Dec 2024 21:48:27 GMT, Phil Race wrote: >> When the static launcher was introduced in >> [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and >> resource constraints, it was only working properly on Linux and macOS, while >> the Windows port compiled but did n

Re: RFR: 8346377: Properly support static builds for Windows

2024-12-19 Thread Erik Joelsson
On Tue, 17 Dec 2024 15:41:51 GMT, Magnus Ihse Bursie wrote: > When the static launcher was introduced in > [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and > resource constraints, it was only working properly on Linux and macOS, while > the Windows port compiled but

Re: RFR: 8346377: Properly support static builds for Windows

2024-12-19 Thread Phil Race
On Tue, 17 Dec 2024 15:41:51 GMT, Magnus Ihse Bursie wrote: > When the static launcher was introduced in > [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and > resource constraints, it was only working properly on Linux and macOS, while > the Windows port compiled but

Re: RFR: 8346377: Properly support static builds for Windows

2024-12-19 Thread Phil Race
On Tue, 17 Dec 2024 15:41:51 GMT, Magnus Ihse Bursie wrote: > When the static launcher was introduced in > [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and > resource constraints, it was only working properly on Linux and macOS, while > the Windows port compiled but

Re: RFR: 8346377: Properly support static builds for Windows

2024-12-19 Thread Magnus Ihse Bursie
On Tue, 17 Dec 2024 15:41:51 GMT, Magnus Ihse Bursie wrote: > When the static launcher was introduced in > [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and > resource constraints, it was only working properly on Linux and macOS, while > the Windows port compiled but

RFR: 8346377: Properly support static builds for Windows

2024-12-19 Thread Magnus Ihse Bursie
When the static launcher was introduced in [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), due to time and resource constraints, it was only working properly on Linux and macOS, while the Windows port compiled but did not work. Now the time has come to fix that. Most of the changes