Re: RFR: 8345874: Run make doctor automatically on failed CI builds [v2]

2025-04-28 Thread SendaoYan
On Mon, 28 Apr 2025 09:41:38 GMT, Magnus Ihse Bursie wrote: >> make/autoconf/spec.gmk.template line 173: >> >>> 171: >>> 172: # dev or ci >>> 173: BUILD_ENV := @BUILD_ENV@ >> >> I think the `BUILD_ENV` could be seted in command line also. So, should we >> update the doc/building.md sync with

Re: RFR: 8345874: Run make doctor automatically on failed CI builds [v2]

2025-04-28 Thread Magnus Ihse Bursie
On Sun, 20 Apr 2025 04:01:31 GMT, SendaoYan wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' into make-doctor-on-ci >> - 8345874: Run make doctor automatical

Re: RFR: 8345874: Run make doctor automatically on failed CI builds [v2]

2025-04-19 Thread SendaoYan
On Wed, 9 Apr 2025 20:29:45 GMT, Magnus Ihse Bursie wrote: >> If there is something wrong with the build, the user can run "make doctor". >> That is hard to do in a CI setting. Instead, if the build environment is >> detected to be a CI, we should run the doctor automatically in case of a >> f

Re: RFR: 8345874: Run make doctor automatically on failed CI builds [v2]

2025-04-09 Thread Magnus Ihse Bursie
> If there is something wrong with the build, the user can run "make doctor". > That is hard to do in a CI setting. Instead, if the build environment is > detected to be a CI, we should run the doctor automatically in case of a > failed build. Magnus Ihse Bursie has updated the pull request wit

RFR: 8345874: Run make doctor automatically on failed CI builds

2025-04-07 Thread Magnus Ihse Bursie
If there is something wrong with the build, the user can run "make doctor". That is hard to do in a CI setting. Instead, if the build environment is detected to be a CI, we should run the doctor automatically in case of a failed build. - Commit messages: - 8345874: Run make doctor