Re: RFR: 8344607: Link Time Optimization - basic support for clang [v4]

2024-12-06 Thread Magnus Ihse Bursie
On Fri, 6 Dec 2024 08:14:31 GMT, Matthias Baesken wrote: >> I saw this too late, shouldn't it be isTargetOs instead of isBuildOs? Or am >> I mistaken and only gtest is affected, hence isBuildOs? Actually I'm not >> sure which one would be appropriate for gtest > > I think in the AIX case the ta

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v4]

2024-12-06 Thread Matthias Baesken
On Fri, 6 Dec 2024 05:05:19 GMT, Julian Waters wrote: >> make/hotspot/lib/JvmFeatures.gmk line 182: >> >>> 180: JVM_CFLAGS_FEATURES += -ffat-lto-objects >>> 181: endif >>> 182: JVM_LDFLAGS_FEATURES += $(CXX_O_FLAG_HIGHEST_JVM) -flto >>> -fno-strict-aliasing >> >> LGTM. ffat-lto-o

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v4]

2024-12-05 Thread Julian Waters
On Thu, 5 Dec 2024 09:44:47 GMT, Joachim Kern wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> use fat lto objects on AIX/clang > > make/hotspot/lib/JvmFeatures.gmk line 182: > >> 180: JVM_CFLAGS_FEATURES

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v4]

2024-12-05 Thread Lutz Schmidt
On Tue, 3 Dec 2024 16:46:04 GMT, Matthias Baesken wrote: >> Support the clang toolchain when link time optimization is configured. >> Please note that this is NOT intended to enable lto by default and NOT to >> fix all possible clang-supporting builds or test issues . >> >> It works on my Linux

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v4]

2024-12-05 Thread Matthias Baesken
On Tue, 3 Dec 2024 16:46:04 GMT, Matthias Baesken wrote: >> Support the clang toolchain when link time optimization is configured. >> Please note that this is NOT intended to enable lto by default and NOT to >> fix all possible clang-supporting builds or test issues . >> >> It works on my Linux

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v4]

2024-12-05 Thread Joachim Kern
On Tue, 3 Dec 2024 16:46:04 GMT, Matthias Baesken wrote: >> Support the clang toolchain when link time optimization is configured. >> Please note that this is NOT intended to enable lto by default and NOT to >> fix all possible clang-supporting builds or test issues . >> >> It works on my Linux

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v4]

2024-12-03 Thread Matthias Baesken
> Support the clang toolchain when link time optimization is configured. > Please note that this is NOT intended to enable lto by default and NOT to fix > all possible clang-supporting builds or test issues . > > It works on my Linux x86_64 SUSE 15 test machine with clang15.0.7, also on > macOS

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v3]

2024-12-02 Thread Magnus Ihse Bursie
On Fri, 29 Nov 2024 09:24:15 GMT, Matthias Baesken wrote: >> Support the clang toolchain when link time optimization is configured. >> Please note that this is NOT intended to enable lto by default and NOT to >> fix all possible clang-supporting builds or test issues . >> >> It works on my Linu

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v3]

2024-11-29 Thread Matthias Baesken
> Support the clang toolchain when link time optimization is configured. > Please note that this is NOT intended to enable lto by default and NOT to fix > all possible clang-supporting builds or test issues . > > It works on my Linux x86_64 SUSE 15 test machine with clang15.0.7, also on > macOS

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v2]

2024-11-28 Thread Julian Waters
On Thu, 28 Nov 2024 07:56:27 GMT, Matthias Baesken wrote: >> Support the clang toolchain when link time optimization is configured. >> Please note that this is NOT intended to enable lto by default and NOT to >> fix all possible clang-supporting builds or test issues . >> >> It works on my Linu

Re: RFR: 8344607: Link Time Optimization - basic support for clang

2024-11-28 Thread Julian Waters
On Thu, 28 Nov 2024 07:52:37 GMT, Matthias Baesken wrote: > Hi Julian, the assembler local labels seem to work (see current commit). If > this approach is used, we probably need a comment about this ? Btw. the > NOINLINE is most likely okay too, this function does not need to be inlined I > th

Re: RFR: 8344607: Link Time Optimization - basic support for clang

2024-11-27 Thread Matthias Baesken
On Wed, 27 Nov 2024 15:14:10 GMT, Matthias Baesken wrote: > Support the clang toolchain when link time optimization is configured. > Please note that this is NOT intended to enable lto by default and NOT to fix > all possible clang-supporting builds or test issues . > > It works on my Linux x86

Re: RFR: 8344607: Link Time Optimization - basic support for clang [v2]

2024-11-27 Thread Matthias Baesken
> Support the clang toolchain when link time optimization is configured. > Please note that this is NOT intended to enable lto by default and NOT to fix > all possible clang-supporting builds or test issues . > > It works on my Linux x86_64 SUSE 15 test machine with clang15.0.7, also on > macOS

Re: RFR: 8344607: Link Time Optimization - basic support for clang

2024-11-27 Thread Julian Waters
On Wed, 27 Nov 2024 15:14:10 GMT, Matthias Baesken wrote: > Support the clang toolchain when link time optimization is configured. > Please note that this is NOT intended to enable lto by default and NOT to fix > all possible clang-supporting builds or test issues . > > It works on my Linux x86

Re: RFR: 8344607: Link Time Optimization - basic support for clang

2024-11-27 Thread Lutz Schmidt
On Wed, 27 Nov 2024 15:14:10 GMT, Matthias Baesken wrote: > Support the clang toolchain when link time optimization is configured. > Please note that this is NOT intended to enable lto by default and NOT to fix > all possible clang-supporting builds or test issues . > > It works on my Linux x86

RFR: 8344607: Link Time Optimization - basic support for clang

2024-11-27 Thread Matthias Baesken
Support the clang toolchain when link time optimization is configured. Please note that this is NOT intended to enable lto by default and NOT to fix all possible clang-supporting builds or test issues . It works on my Linux x86_64 SUSE 15 test machine with clang15.0.7, also on macOS with Xcode