Re: RFR: 8342988: GHA: Build JTReg in single step [v2]

2024-10-28 Thread Aleksey Shipilev
On Fri, 25 Oct 2024 17:12:52 GMT, Aleksey Shipilev wrote: >> It is visible in current GHA runs that building jtreg sometimes break on >> dependencies checkout, for example: >> >> >> [build.sh][INFO] CYGWIN_OR_MSYS=0 >> [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64 >> [build.sh]

Re: RFR: 8342988: GHA: Build JTReg in single step [v2]

2024-10-28 Thread Magnus Ihse Bursie
On Fri, 25 Oct 2024 17:12:52 GMT, Aleksey Shipilev wrote: >> It is visible in current GHA runs that building jtreg sometimes break on >> dependencies checkout, for example: >> >> >> [build.sh][INFO] CYGWIN_OR_MSYS=0 >> [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64 >> [build.sh]

Re: RFR: 8342988: GHA: Build JTReg in single step [v2]

2024-10-28 Thread Magnus Ihse Bursie
On Mon, 28 Oct 2024 13:59:12 GMT, Aleksey Shipilev wrote: >> .github/actions/get-jtreg/action.yml line 59: >> >>> 57: - name: 'Build JTReg' >>> 58: run: | >>> 59: # If runner architecture is x64 set JAVA_HOME_17_X64 otherwise >>> set to JAVA_HOME_17_arm64 >> >> This logic see

Re: RFR: 8342988: GHA: Build JTReg in single step [v2]

2024-10-28 Thread Aleksey Shipilev
On Mon, 28 Oct 2024 13:36:54 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rework for artifacts > > .github/actions/get-jtreg/action.yml line 59: > >> 57: - name: 'Build JTReg' >>

Re: RFR: 8342988: GHA: Build JTReg in single step [v2]

2024-10-28 Thread Magnus Ihse Bursie
On Fri, 25 Oct 2024 17:12:52 GMT, Aleksey Shipilev wrote: >> It is visible in current GHA runs that building jtreg sometimes break on >> dependencies checkout, for example: >> >> >> [build.sh][INFO] CYGWIN_OR_MSYS=0 >> [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64 >> [build.sh]

Re: RFR: 8342988: GHA: Build JTReg in single step

2024-10-28 Thread Aleksey Shipilev
On Fri, 25 Oct 2024 17:09:26 GMT, Aleksey Shipilev wrote: > Reworked for artifacts. My limited tests passed. Let's see if full GHA test > passes with it. Passed. @magicus, take a look again? - PR Comment: https://git.openjdk.org/jdk/pull/21692#issuecomment-2441237869

Re: RFR: 8342988: GHA: Build JTReg in single step [v2]

2024-10-25 Thread Aleksey Shipilev
> It is visible in current GHA runs that building jtreg sometimes break on > dependencies checkout, for example: > > > [build.sh][INFO] CYGWIN_OR_MSYS=0 > [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64 > [build.sh][INFO] Downloading > https://archive.apache.org/dist/ant/binaries/

Re: RFR: 8342988: GHA: Build JTReg in single step

2024-10-25 Thread Aleksey Shipilev
On Thu, 24 Oct 2024 18:58:41 GMT, Aleksey Shipilev wrote: > It is visible in current GHA runs that building jtreg sometimes break on > dependencies checkout, for example: > > > [build.sh][INFO] CYGWIN_OR_MSYS=0 > [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64 > [build.sh][INFO]

Re: RFR: 8342988: GHA: Build JTReg in single step

2024-10-25 Thread Aleksey Shipilev
On Fri, 25 Oct 2024 15:16:30 GMT, Aleksey Shipilev wrote: > > Can we trust the cache that much? I mean, up to now it's only been a > > performance hack, now it will become a necessary part of the pipeline. > > Yeah, I guess that's the risk. I can redo this to use the same > upload/download-art

Re: RFR: 8342988: GHA: Build JTReg in single step

2024-10-25 Thread Aleksey Shipilev
On Fri, 25 Oct 2024 14:53:33 GMT, Magnus Ihse Bursie wrote: > Can we trust the cache that much? I mean, up to now it's only been a > performance hack, now it will become a necessary part of the pipeline. Yeah, I guess that's the risk. I can redo this to use the same upload/download-artifact we

Re: RFR: 8342988: GHA: Build JTReg in single step

2024-10-25 Thread Magnus Ihse Bursie
On Thu, 24 Oct 2024 18:58:41 GMT, Aleksey Shipilev wrote: > It is visible in current GHA runs that building jtreg sometimes break on > dependencies checkout, for example: > > > [build.sh][INFO] CYGWIN_OR_MSYS=0 > [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64 > [build.sh][INFO]

RFR: 8342988: GHA: Build JTReg in single step

2024-10-25 Thread Aleksey Shipilev
It is visible in current GHA runs that building jtreg in all worker at once sometimes break on dependencies checkout, for example: [build.sh][INFO] CYGWIN_OR_MSYS=0 [build.sh][INFO] JAVA_HOME: /usr/lib/jvm/temurin-17-jdk-amd64 [build.sh][INFO] Downloading https://archive.apache.org/dist/ant/bin