On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Tue, 10 Sep 2024 08:51:56 GMT, David Holmes wrote:
> This seems trivially fine to me. The JEP isn't really relevant for this C
> code as we have C99 as a minimum for a while now.
>
> Thanks
We actually have C11 as a minimum, C99 for Unix and C89 for Windows was our old
standard, but that h
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Mon, 9 Sep 2024 13:03:49 GMT, Julian Waters wrote:
>> I have verified this change locally, include build hsdis.so and check the
>> functional with command java -XX:+UnlockDiagnosticVMOptions
>> -XX:+PrintAssembly -version. The verified show this change for hsdis.so work
>> normally.
>
> Ok,
On Mon, 9 Sep 2024 12:56:56 GMT, SendaoYan wrote:
>> src/utils/hsdis/binutils/hsdis-binutils.c line 67:
>>
>>> 65: #include "hsdis.h"
>>> 66:
>>> 67: #ifndef bool
>>
>> I'm a little worried about this change. hsdis may really need an int here.
>> If that turns out to not be the case then I'll
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
On Mon, 9 Sep 2024 12:07:54 GMT, Julian Waters wrote:
>> Hi all,
>> This PR delete tedious bool type define in
>> `src/java.base/unix/native/libjsig/jsig.c` and
>> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
>> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I thi
On Mon, 9 Sep 2024 12:06:25 GMT, Julian Waters wrote:
>> Hi all,
>> This PR delete tedious bool type define in
>> `src/java.base/unix/native/libjsig/jsig.c` and
>> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
>> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I thi
On Mon, 9 Sep 2024 09:50:59 GMT, SendaoYan wrote:
> Hi all,
> This PR delete tedious bool type define in
> `src/java.base/unix/native/libjsig/jsig.c` and
> `src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
> 347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we
>
Hi all,
This PR delete tedious bool type define in
`src/java.base/unix/native/libjsig/jsig.c` and
`src/utils/hsdis/binutils/hsdis-binutils.c`. After JEP
347([JDK-8246032](https://bugs.openjdk.org/browse/JDK-8246032)), I think we can
"#include " to use bool type directly, like
[string.h](http
13 matches
Mail list logo
