Re: RFR: 8334391: JDK build should exclude *-files directories for Java source [v2]

2025-05-08 Thread Erik Joelsson
On Wed, 7 May 2025 22:59:04 GMT, Magnus Ihse Bursie wrote: >> We should always exclude `doc-files` and `snippet-files` when compiling java >> code. To generalize this, exclude all `*-files` directories. >> >> (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence, >> EXCLUDE_FILES

Re: RFR: 8334391: JDK build should exclude *-files directories for Java source [v2]

2025-05-08 Thread Erik Joelsson
On Wed, 7 May 2025 22:52:09 GMT, Magnus Ihse Bursie wrote: >> make/common/JavaCompilation.gmk line 342: >> >>> 340: $1_SRCS_WITHOUT_ROOTS := $$($1_SRCS) >>> 341: $$(foreach i, $$($1_SRC), $$(eval $1_SRCS_WITHOUT_ROOTS := >>> $$(patsubst \ >>> 342: $$i/%,%, $$($1_SRCS_WITHOUT_ROO

Re: RFR: 8334391: JDK build should exclude *-files directories for Java source [v2]

2025-05-07 Thread Magnus Ihse Bursie
> We should always exclude `doc-files` and `snippet-files` when compiling java > code. To generalize this, exclude all `*-files` directories. > > (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence, > EXCLUDE_FILES prepends a `%` wildchar match to the filenames given, which we >

Re: RFR: 8334391: JDK build should exclude *-files directories for Java source

2025-05-07 Thread Magnus Ihse Bursie
On Wed, 7 May 2025 21:12:54 GMT, Erik Joelsson wrote: >> We should always exclude `doc-files` and `snippet-files` when compiling java >> code. To generalize this, exclude all `*-files` directories. >> >> (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence, >> EXCLUDE_FILES prep

Re: RFR: 8334391: JDK build should exclude *-files directories for Java source

2025-05-07 Thread Erik Joelsson
On Fri, 4 Apr 2025 14:44:07 GMT, Magnus Ihse Bursie wrote: > We should always exclude `doc-files` and `snippet-files` when compiling java > code. To generalize this, exclude all `*-files` directories. > > (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence, > EXCLUDE_FILES prep

RFR: 8334391: JDK build should exclude *-files directories for Java source

2025-05-07 Thread Magnus Ihse Bursie
We should always exclude `doc-files` and `snippet-files` when compiling java code. To generalize this, exclude all `*-files` directories. (The usage of EXCLUDES and EXCLUDE_FILES is a bit weird. In essence, EXCLUDE_FILES prepends a `%` wildchar match to the filenames given, which we use here, w