Re: RFR: 8331027: JDK's ct.sym file packs corrupted module-info classes [v2]

2024-05-02 Thread Jan Lahoda
On Thu, 2 May 2024 07:03:20 GMT, Adam Sotona wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removing unnecessary directory cleanup. > > test/langtools/tools/javac/platform/createsymbols/CreateSymbolsTestImpl.java >

Re: RFR: 8331027: JDK's ct.sym file packs corrupted module-info classes [v2]

2024-05-02 Thread Jan Lahoda
> When writing the `ModuleMainClass` attribute, `CreateSymbols` uses an UTF8 > entry (incorrect), instead of a Class_info (correct). This patch fixes that. Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision: Removing unnecessary directory

Re: RFR: 8331027: JDK's ct.sym file packs corrupted module-info classes

2024-05-02 Thread Adam Sotona
On Wed, 1 May 2024 11:18:36 GMT, Jan Lahoda wrote: > When writing the `ModuleMainClass` attribute, `CreateSymbols` uses an UTF8 > entry (incorrect), instead of a Class_info (correct). This patch fixes that. Looks good to me. test/langtools/tools/javac/platform/createsymbols/CreateSymbolsTestIm

RFR: 8331027: JDK's ct.sym file packs corrupted module-info classes

2024-05-01 Thread Jan Lahoda
When writing the `ModuleMainClass` attribute, `CreateSymbols` uses an UTF8 entry (incorrect), instead of a Class_info (correct). This patch fixes that. - Commit messages: - 8331027: JDK's ct.sym file packs corrupted module-info classes Changes: https://git.openjdk.org/jdk/pull/1903