On Mon, 3 Feb 2025 12:14:35 GMT, Stefan Karlsson wrote:
>> The HotSpot Style Guide has a section about source files and includes. The
>> style used for includes have mostly been introduced by scripts when
>> includeDB was replaced, but also when various other enhancements to our
>> includes we
On Mon, 3 Feb 2025 12:14:53 GMT, Doug Simon wrote:
>>> A lot of these rules looks like they could be checked with some simple
>>> scripting or additions to jcheck. Have you considered that?
>>
>> I haven't felt the urge to write such a script, but I know that others have
>> scripts to sort the
On Wed, 5 Feb 2025 08:50:29 GMT, Stefan Karlsson wrote:
> FWIW, I also tend to sort the forward declarations but that's also not
> something that everyone does.
I, too, am an obsessive sorter. Clean code is good code.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/23388#dis
On Wed, 5 Feb 2025 08:49:59 GMT, Stefan Karlsson wrote:
>> doc/hotspot-style.html line 213:
>>
>>> 211: Put conditional inclusions (`#if ...`) at the end of the
>>> section of HotSpot
>>> 212: include lines. This also applies to macro-expanded includes of platform
>>> 213: dependent files.
>>
On Wed, 5 Feb 2025 01:42:36 GMT, David Holmes wrote:
>> Stefan Karlsson has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update hotspot-style.md
>> - Update hotspot-style.html
>
> doc/hotspot-style.html line 213:
>
>> 211: Put conditi
On Mon, 3 Feb 2025 12:14:35 GMT, Stefan Karlsson wrote:
>> The HotSpot Style Guide has a section about source files and includes. The
>> style used for includes have mostly been introduced by scripts when
>> includeDB was replaced, but also when various other enhancements to our
>> includes we
On Mon, 3 Feb 2025 12:14:35 GMT, Stefan Karlsson wrote:
>> The HotSpot Style Guide has a section about source files and includes. The
>> style used for includes have mostly been introduced by scripts when
>> includeDB was replaced, but also when various other enhancements to our
>> includes we
On Mon, 3 Feb 2025 12:14:53 GMT, Doug Simon wrote:
> > I haven't felt the urge to write such a script, but I know that others have
> > scripts to sort the includes
>
> Ok, it was just a suggestion. My experience is that while clearly written
> conventions/rules are important, the more they can
On Mon, 3 Feb 2025 12:11:35 GMT, Stefan Karlsson wrote:
> I haven't felt the urge to write such a script, but I know that others have
> scripts to sort the includes
Ok, it was just a suggestion. My experience is that while clearly written
conventions/rules are important, the more they can be a
On Sat, 1 Feb 2025 07:19:02 GMT, Doug Simon wrote:
> A lot of these rules looks like they could be checked with some simple
> scripting or additions to jcheck. Have you considered that?
I haven't felt the urge to write such a script, but I know that others have
scripts to sort the includes.
-
> The HotSpot Style Guide has a section about source files and includes. The
> style used for includes have mostly been introduced by scripts when includeDB
> was replaced, but also when various other enhancements to our includes were
> made. Some of the introduced styles were never written down
On Fri, 31 Jan 2025 13:56:58 GMT, Stefan Karlsson wrote:
> The HotSpot Style Guide has a section about source files and includes. The
> style used for includes have mostly been introduced by scripts when includeDB
> was replaced, but also when various other enhancements to our includes were
>
On Fri, 31 Jan 2025 13:56:58 GMT, Stefan Karlsson wrote:
> The HotSpot Style Guide has a section about source files and includes. The
> style used for includes have mostly been introduced by scripts when includeDB
> was replaced, but also when various other enhancements to our includes were
>
On Fri, 31 Jan 2025 13:56:58 GMT, Stefan Karlsson wrote:
> The HotSpot Style Guide has a section about source files and includes. The
> style used for includes have mostly been introduced by scripts when includeDB
> was replaced, but also when various other enhancements to our includes were
>
The HotSpot Style Guide has a section about source files and includes. The
style used for includes have mostly been introduced by scripts when includeDB
was replaced, but also when various other enhancements to our includes were
made. Some of the introduced styles were never written down in the
15 matches
Mail list logo
