Re: RFR: 8282493: Add --with-jcov-modules convenience option [v5]

2025-05-07 Thread Sergey Bylokhov
On Wed, 7 May 2025 11:22:40 GMT, Magnus Ihse Bursie wrote: > JAVA_TOOL_OPTIONS and _JAVA_OPTIONS are setup in lines 127...130 in > RunTests.gmk. > > @mrserb Is this expected behavior, or am I doing something wrong? That is a known issue: https://bugs.openjdk.org/browse/JDK-8219323 ---

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v5]

2025-05-07 Thread Erik Joelsson
On Wed, 7 May 2025 09:18:29 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v5]

2025-05-07 Thread Magnus Ihse Bursie
On Wed, 7 May 2025 09:18:29 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v5]

2025-05-07 Thread Magnus Ihse Bursie
On Wed, 7 May 2025 09:18:29 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v5]

2025-05-07 Thread Magnus Ihse Bursie
> Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last r

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v4]

2025-05-07 Thread Magnus Ihse Bursie
> Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pu

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Erik Joelsson
On Tue, 6 May 2025 15:06:36 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Erik Joelsson
On Tue, 6 May 2025 20:59:35 GMT, Sergey Bylokhov wrote: >> make/RunTests.gmk line 1376: >> >>> 1374: jcov-gen-report: jcov-stop-grabber >>> 1375: $(call LogWarn, Generating JCov report ...) >>> 1376: $(call ExecuteWithLog, $(JCOV_SUPPORT_DIR)/run-jcov-repgen, >> >> Shouldn't there

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Sergey Bylokhov
On Tue, 6 May 2025 15:06:36 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Sergey Bylokhov
On Tue, 6 May 2025 20:58:17 GMT, Sergey Bylokhov wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update copyright year >> - Update testing documentation > > make/RunTests.gmk line 1376: > >> 1374: jcov-

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Sergey Bylokhov
On Tue, 6 May 2025 15:06:36 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Erik Joelsson
On Tue, 6 May 2025 15:06:36 GMT, Magnus Ihse Bursie wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Magnus Ihse Bursie has updated the pull

Re: RFR: 8282493: Add --with-jcov-modules convenience option

2025-05-06 Thread Magnus Ihse Bursie
On Mon, 21 Apr 2025 06:58:52 GMT, Sergey Bylokhov wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > Description of the new option can be adde

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Magnus Ihse Bursie
On Sun, 20 Apr 2025 03:52:38 GMT, SendaoYan wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Update copyright year >> - Update testing documentation > > Should we update the copyright year from 2024 to 2025

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v3]

2025-05-06 Thread Magnus Ihse Bursie
> Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last

Re: RFR: 8282493: Add --with-jcov-modules convenience option [v2]

2025-05-06 Thread Magnus Ihse Bursie
> Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The in

Re: RFR: 8282493: Add --with-jcov-modules convenience option

2025-04-21 Thread Sergey Bylokhov
On Mon, 7 Apr 2025 08:45:13 GMT, Magnus Ihse Bursie wrote: > Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. Description of the new option can be added to

Re: RFR: 8282493: Add --with-jcov-modules convenience option

2025-04-20 Thread Sergey Bylokhov
On Mon, 7 Apr 2025 08:45:13 GMT, Magnus Ihse Bursie wrote: > Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. It might be helpful to clarify which combinat

Re: RFR: 8282493: Add --with-jcov-modules convenience option

2025-04-19 Thread SendaoYan
On Mon, 7 Apr 2025 08:45:13 GMT, Magnus Ihse Bursie wrote: > Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. Should we update the copyright year from 2024

Re: RFR: 8282493: Add --with-jcov-modules convenience option

2025-04-10 Thread Erik Joelsson
On Mon, 7 Apr 2025 08:45:13 GMT, Magnus Ihse Bursie wrote: > Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. Marked as reviewed by erikj (Reviewer). make

Re: RFR: 8282493: Add --with-jcov-modules convenience option

2025-04-09 Thread Erik Joelsson
On Wed, 9 Apr 2025 10:24:24 GMT, Magnus Ihse Bursie wrote: >> make/Coverage.gmk line 42: >> >>> 40: JCOV_TEMP := $(JCOV_SUPPORT_DIR)/temp >>> 41: >>> 42: ifneq ($(JCOV_MODULES), ) >> >> Is this redundant conditional done on purpose? > > You mean as in a foreach on an empty variable will yield

Re: RFR: 8282493: Add --with-jcov-modules convenience option

2025-04-09 Thread Magnus Ihse Bursie
On Tue, 8 Apr 2025 19:38:52 GMT, Erik Joelsson wrote: >> Allow the user to set "--with-jcov-modules=java.desktop", instead of >> "--with-jcov-filters=--include-modules java.desktop", since this is one of >> the common use cases for the filtering. > > make/Coverage.gmk line 42: > >> 40: JCOV_TE

Re: RFR: 8282493: Add --with-jcov-modules convenience option

2025-04-08 Thread Magnus Ihse Bursie
On Mon, 7 Apr 2025 08:45:13 GMT, Magnus Ihse Bursie wrote: > Allow the user to set "--with-jcov-modules=java.desktop", instead of > "--with-jcov-filters=--include-modules java.desktop", since this is one of > the common use cases for the filtering. @shurymury I believe you are the one that ori

RFR: 8282493: Add --with-jcov-modules convenience option

2025-04-08 Thread Magnus Ihse Bursie
Allow the user to set "--with-jcov-modules=java.desktop", instead of "--with-jcov-filters=--include-modules java.desktop", since this is one of the common use cases for the filtering. - Commit messages: - Also fix RepGen - Update with correct syntax + debug support - 8282493: Add