On Tue, 16 Apr 2024 21:21:43 GMT, Chen Liang wrote:
>> Get JDK 24 underway.
>
> src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1481:
>
>> 1479: int JAVA_23_VERSION = 67;
>> 1480:
>> 1481: /** 68 */
>
> We need `@since 24` here.
Ah, good catch; looks like I was tre
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
This pull request has now been integrated.
Changeset: 75dc2f85
Author:Joe Darcy
Committer: Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/75dc2f8518d0adea30f7065d6732b807c0220756
Stats: 2083 l
On Mon, 15 Apr 2024 19:57:49 GMT, Iris Clark wrote:
> The copyright year was not updated in all files *14.java. I assume that's
> intentional.
I'll run my copyright update script before pushing.
> I've also Reviewed the associated CSRs.
Thanks.
> make/conf/version-numbers.conf line 36:
>
>>
On Tue, 23 Apr 2024 07:03:45 GMT, David Holmes wrote:
> There are further updates to this test in the pipeline (new deprecated flags
> in 23) so you will need to keep updating to reflect that.
Thanks @dholmes-ora ; acknowledged.
-
PR Review Comment: https://git.openjdk.org/jdk/pul
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
src/java.base/share/classes/java/lang/classfile/ClassFile.java line 1481:
> 1479: int JAVA_23_VERSION = 67;
> 1480:
> 1481: /** 68 */
We need `@since 24` here.
src/jdk.compiler/share/data/symbols/jdk.incubator.
On Thu, 30 May 2024 18:39:19 GMT, Chen Liang wrote:
>> Get JDK 24 underway.
>
> src/jdk.compiler/share/data/symbols/jdk.incubator.foreign-N.sym.txt line 1:
>
>> 1: #
>
> Just curious, does CreateSymbols not track module migrations, now that
> jdk.incubator.foreign is completely merged into jav
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
This initial version of the PR intentionally excludes the creation of the new
symbol files so that the fundamental code aspects of the update are easier to
see.
-
PR Comment: https://git.openjdk.org/jdk/pul
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
lgtm
-
Marked as reviewed by vromero (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2004323374
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
LGTM
Thanks
test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java line 1:
> 1: /*
There are further updates to this test in the pipeline (new deprecated flags in
23) so you will need to keep updating to refl
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
The copyright year was not updated in all files *14.java. I assume that's
intentional.
I've also Reviewed the associated CSRs.
Marked as reviewed by iris (Reviewer).
Marked as reviewed by iris (Reviewer).
Still loo
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
ClassFile changes are OK.
-
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18787#pullrequestreview-2005504192
Get JDK 24 underway.
-
Commit messages:
- Update copyright.
- Updated problem list after bug fix.
- Merge branch 'master' into JDK-8330188
- Merge branch 'master' into JDK-8330188
- Temporarily problem list java.lang.instrument tests until jar generation is
fixed.
- Merge branc
On Mon, 15 Apr 2024 19:01:08 GMT, Joe Darcy wrote:
> Get JDK 24 underway.
This pull request has now been integrated.
Changeset: 75dc2f85
Author:Joe Darcy
Committer: Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/75dc2f8518d0adea30f7065d6732b807c0220756
Stats: 2083 l
13 matches
Mail list logo
