Re: RFR: 8346109: Create JDK taglet for additional preview notes

2025-04-11 Thread Hannes Wallnöfer
On Tue, 8 Apr 2025 18:32:16 GMT, Chen Liang wrote: >> The problem is the Taglet class is part of the build system, and I don't >> think we have a way to test these build classes (I coulndn't find any tests >> for the other build Taglets). I could replicate the Taglet class in the >> test, but

Re: RFR: 8346109: Create JDK taglet for additional preview notes

2025-04-11 Thread Hannes Wallnöfer
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote: > Please review a patch to add a JavaDoc Taglet to the JDK build system that > allows to add preview-related notes to non-preview API elements, as well as a > hidden javadoc option to add elements with preview notes to the preview > sum

Integrated: 8346109: Create JDK taglet for additional preview notes

2025-04-11 Thread Hannes Wallnöfer
On Fri, 31 Jan 2025 16:19:17 GMT, Hannes Wallnöfer wrote: > Please review a patch to add a JavaDoc Taglet to the JDK build system that > allows to add preview-related notes to non-preview API elements, as well as a > hidden javadoc option to add elements with preview notes to the preview > sum

Integrated: 8354266: Fix non-UTF-8 text encoding

2025-04-11 Thread Magnus Ihse Bursie
On Thu, 10 Apr 2025 10:10:49 GMT, Magnus Ihse Bursie wrote: > I have checked the entire code base for incorrect encodings, but luckily > enough these were the only remaining problems I found. > > BOM (byte-order mark) is a method used for distinguishing big and little > endian UTF-16 encoding

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-11 Thread Magnus Ihse Bursie
On Fri, 11 Apr 2025 03:35:11 GMT, Sergey Bylokhov wrote: >> I have checked the entire code base for incorrect encodings, but luckily >> enough these were the only remaining problems I found. >> >> BOM (byte-order mark) is a method used for distinguishing big and little >> endian UTF-16 encodi

Re: RFR: 8354266: Fix non-UTF-8 text encoding

2025-04-11 Thread Eirik Bjørsnøs
On Fri, 11 Apr 2025 10:21:32 GMT, Magnus Ihse Bursie wrote: >> src/demo/share/java2d/J2DBench/resources/textdata/arabic.ut8.txt line 11: >> >>> 9: تخصص الشفرة الموحدة "يونِكود" رقما وحيدا لكل محرف في جميع اللغات >>> العالمية، وذلك بغض النظر عن نوع الحاسوب أو البرامج المستخدمة. وقد تـم تبني >>>

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493 [v5]

2025-04-11 Thread Christoph Langer
On Wed, 9 Apr 2025 16:10:20 GMT, Severin Gehwolf wrote: >> For JEP 493-enabled builds there are no JMODs. Certain files come from the >> installed JDK image when a user creates a custom run-time from it. This is >> problematic for example for files that often come from a different package >> (

Re: RFR: 8353185: Introduce the concept of upgradeable files in context of JEP 493 [v2]

2025-04-11 Thread Christoph Langer
On Sat, 5 Apr 2025 04:49:03 GMT, Christoph Langer wrote: >> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> c