On Tue, 25 Mar 2025 21:24:41 GMT, Doug Simon wrote:
>> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks
>> of include statements in C++ files are sorted alphabetically and that
>> there's at least one blank line between user and sys includes (as per the
>> [style
>>
unsubscript
On Tue, 25 Mar 2025 15:57:12 GMT, Magnus Ihse Bursie wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Force use of lld when build os is not macosx
>
> Since I wrote like half the actual patch, I think it would be prope
On Thu, 20 Mar 2025 06:57:04 GMT, SendaoYan wrote:
> Hi all,
>
> There is an extra a.out file generated located in repository root directory
> after execute the configure command with llvm/clang compiler sometimes, not
> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, sho
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Tue, 25 Mar 2025 20:16:51 GMT, Frederic Thevenet
wrote:
> > Using the log file from ExecuteWithLog as the recipe target to work around
> > changing/signing the actual target file in place is an interesting choice,
> > but I think it will work. Have you tried incremental builds thoroughly?
>
On Tue, 25 Mar 2025 20:27:21 GMT, Stefan Karlsson wrote:
>> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks
>> of include statements in C++ files are sorted alphabetically and that
>> there's at least one blank line between user and sys includes (as per the
>> [style
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Tue, 25 Mar 2025 17:22:07 GMT, Erik Joelsson wrote:
> Using the log file from ExecuteWithLog as the recipe target to work around
> changing/signing the actual target file in place is an interesting choice,
> but I think it will work. Have you tried incremental builds thoroughly?
Hmm... If t
On Tue, 25 Mar 2025 14:52:56 GMT, Magnus Ihse Bursie wrote:
>> I pushed a commit that prevents the re-ordering:
>> https://github.com/openjdk/jdk/pull/24180/commits/c0f202d2a7e7b8788719fe8cd2a4c7a095ecd3bb
>
> My gut reaction is that header files should be self-sustaining, that is if
> they nee
On Tue, 25 Mar 2025 15:51:02 GMT, Severin Gehwolf wrote:
>> make/autoconf/jdk-options.m4 line 638:
>>
>>> 636: # Extra jlink options to be (optionally) passed to the JDK build
>>> 637: #
>>> 638: AC_ARG_WITH(extra-jlink-flags,
>>> [AS_HELP_STRING([--with-extra-jlink-flags],
>>
>> Please
> Please review this simple change to allow for extra `jlink` flags to be
> passed to the JDK build by `configure`. The bug describes use-cases where
> this would be needed.
>
> Testing:
> - [x] GHA
> - [x] Manual tests with a fix for
> [JDK-8352689](https://bugs.openjdk.org/browse/JDK-8352689)
Hello, I was running on Linux into this issue today :
make all
Building target 'all' in configuration '/builddir'
gmake[3]: *** No rule to make target
'/builddir/support/interim-image/bin/java', needed by
'/builddir/support/link_opt/classlist'. Stop.
gmake[2]: *** [make/Main.gmk:649: generate
On 3/25/25 08:57, Baesken, Matthias wrote:
> Did you try to run "make doctor"?
No .
(I have to confess I deleted some stuff from the builddir before) .
If you manually delete stuff from the builddir, you cannot expect
incremental builds to work unless you know exactly what to delete. Make
On 2025-03-25 17:00, Baesken, Matthias wrote:
>Have you tried doing a "make clean" to see if it resolves the issue?
I did an “rm -rf” and full rebuild 😊 !
And the problem still persisted..?
/Magnus
On Tue, 25 Mar 2025 12:40:42 GMT, SendaoYan wrote:
>> Hi all,
>>
>> There is an extra a.out file generated located in repository root directory
>> after execute the configure command with llvm/clang compiler sometimes, not
>> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`
On Wed, 26 Feb 2025 18:02:53 GMT, Frederic Thevenet
wrote:
> OpenJDK vendors who provide binary distributions for the Windows and macOS
> platforms generally need to ensure that every native executable file and
> dynamic library that are part of the binary builds are digitally signed using
>
On 2025-03-25 16:57, Baesken, Matthias wrote:
> Did you try to run "make doctor"?
No .
(I have to confess I deleted some stuff from the builddir before) .
>Normally, incremental builds work fine, but they are not 100% proof.
In particular, "make reconfigure" can cause situations that an
inc
On Tue, 25 Mar 2025 15:50:36 GMT, Frederic Thevenet
wrote:
>> OpenJDK vendors who provide binary distributions for the Windows and macOS
>> platforms generally need to ensure that every native executable file and
>> dynamic library that are part of the binary builds are digitally signed
>> us
On 2025-03-22 01:55, Bingwu Zhang wrote:
Recently when packaging OpenJDK 24-ga for AOSC OS, I hit an compilation error
on loongson3 (which is a variant of mips64), saying that javac is running out
of stack space:
java.lang.StackOverflowError
at jdk.compiler.interim/
[...]
What should
>Have you tried doing a "make clean" to see if it resolves the issue?
I did an “rm -rf” and full rebuild 😊 !
On 2025-03-25 15:23, Baesken, Matthias wrote:
HELP: Try searching the build log for '] Error'.
HELP: Run 'make doctor' to diagnose build problems.
Did you try to run "make doctor"?
Any idea what’s going wrong ? Is there maybe some issue with the
dependencies of the make ?
(it is an incre
> Did you try to run "make doctor"?
No .
(I have to confess I deleted some stuff from the builddir before) .
>Normally, incremental builds work fine, but they are not 100% proof. In
>particular, "make reconfigure" can cause situations that an incremental build
>>cannot properly resolve. (Thi
On Tue, 25 Mar 2025 15:50:36 GMT, Frederic Thevenet
wrote:
>> OpenJDK vendors who provide binary distributions for the Windows and macOS
>> platforms generally need to ensure that every native executable file and
>> dynamic library that are part of the binary builds are digitally signed
>> us
On Tue, 25 Mar 2025 14:59:13 GMT, Magnus Ihse Bursie wrote:
>> Please review this simple change to allow for extra `jlink` flags to be
>> passed to the JDK build by `configure`. The bug describes use-cases where
>> this would be needed.
>>
>> Testing:
>> - [x] GHA
>> - [x] Manual tests with a
On Tue, 25 Mar 2025 14:56:27 GMT, Magnus Ihse Bursie wrote:
> Did you consider writing the tool in Java? Or rather, could you be convinced
> to convert it to Java? With the source code launch mechanism, it is just as
> simple to run as a python script. Also, there is some kind of optics about i
On Tue, 25 Mar 2025 14:26:46 GMT, Frederic Thevenet
wrote:
>> OpenJDK vendors who provide binary distributions for the Windows and macOS
>> platforms generally need to ensure that every native executable file and
>> dynamic library that are part of the binary builds are digitally signed
>> us
On Tue, 25 Mar 2025 12:40:42 GMT, SendaoYan wrote:
>> Hi all,
>>
>> There is an extra a.out file generated located in repository root directory
>> after execute the configure command with llvm/clang compiler sometimes, not
>> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`
On Tue, 25 Mar 2025 10:43:32 GMT, Aleksey Shipilev wrote:
>> This PR implements JEP 503: Remove the 32-bit x86 Port.
>>
>> The JEP is proposed to target 25, we would not integrate until JEP is ready.
>> Reviews are appreciated meanwhile.
>>
>> This is only the removal of obvious 32-bit x86 par
On Tue, 25 Mar 2025 10:43:32 GMT, Aleksey Shipilev wrote:
>> This PR implements JEP 503: Remove the 32-bit x86 Port.
>>
>> The JEP is proposed to target 25, we would not integrate until JEP is ready.
>> Reviews are appreciated meanwhile.
>>
>> This is only the removal of obvious 32-bit x86 par
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Mon, 24 Mar 2025 10:37:10 GMT, Severin Gehwolf wrote:
> Please review this simple change to allow for extra `jlink` flags to be
> passed to the JDK build by `configure`. The bug describes use-cases where
> this would be needed.
>
> Testing:
> - [x] GHA
> - [x] Manual tests with a fix for
>
On Tue, 25 Mar 2025 12:06:42 GMT, Doug Simon wrote:
>> src/hotspot/cpu/aarch64/immediate_aarch64.cpp line 26:
>>
>>> 24: */
>>> 25:
>>> 26: #include
>>
>> Moving these sys includes causes a build failure:
>> https://github.com/dougxc/jdk/actions/runs/14054959680/job/39352322113#step:12:537
> OpenJDK vendors who provide binary distributions for the Windows and macOS
> platforms generally need to ensure that every native executable file and
> dynamic library that are part of the binary builds are digitally signed using
> a set of OS specific APIs.
>
> The JDK build systems already
On Tue, 25 Mar 2025 11:24:51 GMT, Magnus Ihse Bursie wrote:
>> Frederic Thevenet has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Simplified CallSigningHook logic
>> - Reapply "Expand the UTIL_ARG_WITH macro to accept and check for
>>
> OpenJDK vendors who provide binary distributions for the Windows and macOS
> platforms generally need to ensure that every native executable file and
> dynamic library that are part of the binary builds are digitally signed using
> a set of OS specific APIs.
>
> The JDK build systems already
On Tue, 25 Mar 2025 10:43:32 GMT, Aleksey Shipilev wrote:
>> This PR implements JEP 503: Remove the 32-bit x86 Port.
>>
>> The JEP is proposed to target 25, we would not integrate until JEP is ready.
>> Reviews are appreciated meanwhile.
>>
>> This is only the removal of obvious 32-bit x86 par
On Wed, 26 Feb 2025 18:02:53 GMT, Frederic Thevenet
wrote:
> OpenJDK vendors who provide binary distributions for the Windows and macOS
> platforms generally need to ensure that every native executable file and
> dynamic library that are part of the binary builds are digitally signed using
>
On Thu, 27 Feb 2025 06:23:17 GMT, Julian Waters wrote:
>> OpenJDK vendors who provide binary distributions for the Windows and macOS
>> platforms generally need to ensure that every native executable file and
>> dynamic library that are part of the binary builds are digitally signed
>> using a
On Tue, 25 Mar 2025 11:36:01 GMT, Magnus Ihse Bursie wrote:
>>> Also, the addition of the `executable` test was good! Please re-instantiate
>>> it.
>>>
>>> I'm not sure if @tstuefe meant that it should be removed? If so, why? To be
>>> able to pass in a shell script that does not have the exec
> Hi all,
>
> There is an extra a.out file generated located in repository root directory
> after execute the configure command with llvm/clang compiler sometimes, not
> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, shows
> as below. This PR force use of lld when toolch
On Tue, 25 Mar 2025 11:32:17 GMT, Magnus Ihse Bursie wrote:
> And no, passing `-fuse-ld=lld` to the linker at all time does not make this a
> big PR. Try something like this (untested, but should work):
Okey, this change works. I was mistakenly though we should use `BASIC_LDFLAGS`
in `FLAGS_SE
> Hi all,
>
> There is an extra a.out file generated located in repository root directory
> after execute the configure command with llvm/clang compiler sometimes, not
> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`, shows
> as below. This PR add a command to remove the
On Tue, 25 Mar 2025 09:16:15 GMT, Doug Simon wrote:
>> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks
>> of include statements in C++ files are sorted alphabetically and that
>> there's at least one blank line between user and sys includes (as per the
>> [style
>>
On Sun, 23 Mar 2025 21:14:47 GMT, Doug Simon wrote:
> This PR adds `bin/sort_includes.py`, a python3 script to check that blocks of
> include statements in C++ files are sorted alphabetically and that there's at
> least one blank line between user and sys includes (as per the [style
> guide](h
On Fri, 21 Mar 2025 08:58:36 GMT, Matthias Baesken wrote:
>> Seems Wayland is not supported on AIX, so we most likely do not need to
>> build pipewire on AIX and can remove it from the build.
>> Reason is that pipewire updates can break the AIX build, so better avoid it
>> if possible.
>>
>> T
On Tue, 25 Mar 2025 04:10:53 GMT, SendaoYan wrote:
>> Hi all,
>>
>> There is an extra a.out file generated located in repository root directory
>> after execute the configure command with llvm/clang compiler sometimes, not
>> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`
On Tue, 25 Mar 2025 11:26:09 GMT, Frederic Thevenet
wrote:
> I removed the check because I noticed that UTIL_FIXUP_EXECUTABLE already
> performs such a check and so it was redundant.
I see.
The benefit of your solution was that the error message is tied to the
configure argument and is more
On Tue, 25 Mar 2025 04:10:53 GMT, SendaoYan wrote:
>> Hi all,
>>
>> There is an extra a.out file generated located in repository root directory
>> after execute the configure command with llvm/clang compiler sometimes, not
>> always. The a.out was generate by `$LINKER -Wl,-v 2>&1 | $HEAD -n 1`
On Mon, 24 Mar 2025 20:49:23 GMT, Magnus Ihse Bursie wrote:
> Actually, I think there is a UTIL_FIXUP_EXECUTABLE, which takes care of
> adding FIXPATH and fixes any issues with `.exe` on Windows. That is the one
> you should use.
Thanks @magicus. I have reverted my changes in favour of using
On Wed, 26 Feb 2025 18:02:53 GMT, Frederic Thevenet
wrote:
> OpenJDK vendors who provide binary distributions for the Windows and macOS
> platforms generally need to ensure that every native executable file and
> dynamic library that are part of the binary builds are digitally signed using
>
On Tue, 25 Mar 2025 08:49:34 GMT, Thomas Stuefe wrote:
> Why not just call bash with the script as argument? Or is this against some
> policy or good style?
EDIT: I didn't want to presume that the hook would necessarily be implemented
as a shell script. It seems likely that it will almost alw
On Mon, 24 Mar 2025 17:47:07 GMT, Frederic Thevenet
wrote:
> > Tested on Mac OS. Works, see
> > [build.log](https://github.com/user-attachments/files/19428633/build.log)
> > Improvement possible:
> > ```
> > * signing script has to be executable
> > ```
>
> I've extend the `UTIL_ARG_WITH` macr
On Wed, 26 Feb 2025 18:02:53 GMT, Frederic Thevenet
wrote:
> OpenJDK vendors who provide binary distributions for the Windows and macOS
> platforms generally need to ensure that every native executable file and
> dynamic library that are part of the binary builds are digitally signed using
>
OpenJDK vendors who provide binary distributions for the Windows and macOS
platforms generally need to ensure that every native executable file and
dynamic library that are part of the binary builds are digitally signed using a
set of OS specific APIs.
The JDK build systems already provides the
On Fri, 21 Mar 2025 15:17:27 GMT, Magnus Ihse Bursie wrote:
> It's time for some spring cleaning in the build system. These checks are for
> functionality that has long been deprecated, and should not be in use
> anymore. We should remove it to keep the code base simpler.
This pull request has
On Fri, 21 Mar 2025 15:30:58 GMT, Magnus Ihse Bursie wrote:
> We are missing `$(SYSROOT_CFLAGS)` when calling `$(CPP)` directly (instead of
> going via `SetupNativeCompilation`).
This pull request has now been integrated.
Changeset: 512b9b16
Author:Magnus Ihse Bursie
URL:
https://g
On Wed, 12 Mar 2025 14:52:10 GMT, Matthias Baesken wrote:
> Seems Wayland is not supported on AIX, so we most likely do not need to build
> pipewire on AIX and can remove it from the build.
> Reason is that pipewire updates can break the AIX build, so better avoid it
> if possible.
>
> To chec
59 matches
Mail list logo
