Re: RFR: 8346046: Enable copyright header format check [v2]

2024-12-13 Thread Iris Clark
On Fri, 13 Dec 2024 17:18:10 GMT, Zhao Song wrote: >> As requested in [SKARA-1357](https://bugs.openjdk.org/browse/SKARA-1357), >> now skara bot is able to check the copyright header format. >> Now I am going to update the jcheck configuration to configure copyright >> check as an error. > > Zh

Re: RFR: 8346046: Enable copyright header format check [v2]

2024-12-13 Thread Erik Joelsson
On Fri, 13 Dec 2024 17:18:10 GMT, Zhao Song wrote: >> As requested in [SKARA-1357](https://bugs.openjdk.org/browse/SKARA-1357), >> now skara bot is able to check the copyright header format. >> Now I am going to update the jcheck configuration to configure copyright >> check as an error. > > Zh

Re: RFR: 8346046: Enable copyright header format check [v2]

2024-12-13 Thread Zhao Song
> As requested in [SKARA-1357](https://bugs.openjdk.org/browse/SKARA-1357), now > skara bot is able to check the copyright header format. > Now I am going to update the jcheck configuration to configure copyright > check as an error. Zhao Song has updated the pull request incrementally with one

Re: RFR: 8346046: Enable copyright header format check

2024-12-13 Thread Zhao Song
On Fri, 13 Dec 2024 04:06:47 GMT, David Holmes wrote: >> As requested in [SKARA-1357](https://bugs.openjdk.org/browse/SKARA-1357), >> now skara bot is able to check the copyright header format. >> Now I am going to update the jcheck configuration to configure copyright >> check as an error. > >

Re: RFR: 8343832: Enhance test summary with number of skipped tests [v5]

2024-12-13 Thread Ivan Bereziuk
On Fri, 13 Dec 2024 14:07:54 GMT, Erik Joelsson wrote: >> Ivan Bereziuk has updated the pull request incrementally with one additional >> commit since the last revision: >> >> adapt changes to the ancient awk on MacOS > > Marked as reviewed by erikj (Reviewer). thank you @erikj79 for re-revi

Re: RFR: 8343832: Enhance test summary with number of skipped tests [v5]

2024-12-13 Thread Erik Joelsson
On Fri, 13 Dec 2024 12:56:18 GMT, Ivan Bereziuk wrote: >> The output for Jtreg v7.5 was >> [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947) >> with [information about skipped >> tests](https://github.com/openj

Re: RFR: 8345942: Separate source output from class output when building microbenchmarks

2024-12-13 Thread Erik Joelsson
On Fri, 13 Dec 2024 05:46:28 GMT, Jan Lahoda wrote: > The microbenchmarks build generates a considerable amount of (generated) > sources using an annotation processor. This, by itself, is not a problem. > But, it generates them into the class output, and after the microbenchmarks > build has b

Re: RFR: 8343832: Enhance test summary with number of skipped tests [v5]

2024-12-13 Thread Ivan Bereziuk
> The output for Jtreg v7.5 was > [enhanced](https://github.com/openjdk/jtreg/pull/217/files#diff-b6ab77bf651f1fd9a83c3ca0aab9cd24ae5c08cef41e6e257f7eaccc07c7c366R947) > with [information about skipped > tests](https://github.com/openjdk/jtreg/blob/master/src/share/doc/javatest/regtest/faq.md#wh

Integrated: 8345590: AIX 'make all' fails after JDK-8339480

2024-12-13 Thread Matthias Baesken
On Thu, 12 Dec 2024 14:14:18 GMT, Matthias Baesken wrote: > On AIX we after [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480) > into this error > > > make all > Building target 'all' in configuration '/open_jdk/jdk/build_aix' > Creating 1 test executable file(s) for BUILD_LIBTEST_JTRE

Re: RFR: 8345590: AIX 'make all' fails after JDK-8339480 [v2]

2024-12-13 Thread Matthias Baesken
On Fri, 13 Dec 2024 09:42:09 GMT, Matthias Baesken wrote: >> On AIX we after [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480) >> into this error >> >> >> make all >> Building target 'all' in configuration '/open_jdk/jdk/build_aix' >> Creating 1 test executable file(s) for BUILD_LIBTE

Re: RFR: 8345590: AIX 'make all' fails after JDK-8339480 [v2]

2024-12-13 Thread Christoph Langer
On Fri, 13 Dec 2024 09:42:09 GMT, Matthias Baesken wrote: >> On AIX we after [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480) >> into this error >> >> >> make all >> Building target 'all' in configuration '/open_jdk/jdk/build_aix' >> Creating 1 test executable file(s) for BUILD_LIBTE

Re: RFR: 8345590: AIX 'make all' fails after JDK-8339480 [v2]

2024-12-13 Thread Matthias Baesken
> On AIX we after [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480) > into this error > > > make all > Building target 'all' in configuration '/open_jdk/jdk/build_aix' > Creating 1 test executable file(s) for BUILD_LIBTEST_JTREG_EXECUTABLES > StaticLibs.gmk:107: *** Unsupported platform

Re: RFR: 8345942: Separate source output from class output when building microbenchmarks

2024-12-13 Thread Aleksey Shipilev
On Fri, 13 Dec 2024 05:46:28 GMT, Jan Lahoda wrote: > The microbenchmarks build generates a considerable amount of (generated) > sources using an annotation processor. This, by itself, is not a problem. > But, it generates them into the class output, and after the microbenchmarks > build has b

Re: RFR: 8345590: AIX 'make all' fails after JDK-8339480

2024-12-13 Thread Magnus Ihse Bursie
On Fri, 13 Dec 2024 08:05:17 GMT, Matthias Baesken wrote: >> Eriks suggestion is almost okay, but you should filter on the supported >> platforms for static images instead, that is, check `ifeq ($(call >> isTargetOs, linux macosx), true)` instead. > > Hi Magnus, what about Windows ? Static ima

RFR: 8345627: [REDO] Use gcc12 -ftrivial-auto-var-init=pattern in debug builds

2024-12-13 Thread Magnus Ihse Bursie
This is a retry to add `-ftrivial-auto-var-init=pattern` to gcc debug builds. The first attempt was buggy in multiple ways and had to be backed out. This is the description of the original bug report: gcc12 has added -ftrivial-auto-var-init=, which specifies how automatic variables without an i

Re: RFR: 8345627: [REDO] Use gcc12 -ftrivial-auto-var-init=pattern in debug builds

2024-12-13 Thread Magnus Ihse Bursie
On Wed, 11 Dec 2024 21:14:04 GMT, Magnus Ihse Bursie wrote: > This is a retry to add `-ftrivial-auto-var-init=pattern` to gcc debug builds. > The first attempt was buggy in multiple ways and had to be backed out. > > This is the description of the original bug report: > > gcc12 has added -ftri

Re: RFR: 8345590: AIX 'make all' fails after JDK-8339480

2024-12-13 Thread Matthias Baesken
On Thu, 12 Dec 2024 22:46:16 GMT, Magnus Ihse Bursie wrote: >> Yes please use indentation and avoid repeating code. >> Suggestion: >> >> all-images: product-images test-image all-docs-images >> ifeq ($(call isTargetOs, aix), false) >> all-images: static-jdk-image >> endif > > Eriks suggestion