Re: RFR: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used [v2]

2024-06-23 Thread Daniel Jeliński
On Wed, 19 Jun 2024 16:50:22 GMT, Daniel Jeliński wrote: >> We use 2 ParkEvent instances per thread. The ParkEvent objects are never >> freed, but they are recycled when a thread dies, so the number of live >> ParkEvent instances is proportional to the maximum number of threads that >> were li

Integrated: 8334166: Enable binary check

2024-06-23 Thread Zhao Song
On Wed, 12 Jun 2024 22:38:37 GMT, Zhao Song wrote: > @kevinrushforth said in > [SKARA-2289](https://bugs.openjdk.org/browse/SKARA-2289), 'In general, our > repositories contain source code and not binary files. There are exceptions > to this for images and other similar resources, but otherwis

Re: RFR: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used [v2]

2024-06-23 Thread David Holmes
On Thu, 20 Jun 2024 05:58:16 GMT, Thomas Stuefe wrote: >> Oh. That's interesting. 😞 > > Of course pre-existing, but the typical pattern we use with RAII objects that > may or may not do something is to give it a constructor argument, e.g. `bool > activate`, that controls if it is activated.

Re: RFR: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used [v2]

2024-06-23 Thread David Holmes
On Sun, 23 Jun 2024 09:35:07 GMT, Daniel Jeliński wrote: >> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment > > the GHA failure looks related, but I can't reproduce it locally. Will dig... @djelinski why d

Re: Build failing when disabling the serialgc

2024-06-23 Thread David Holmes
On 20/06/2024 6:48 pm, Julian Waters wrote: Hi Sanne, The reason the build fails when disabling SerialGC is due to the build process explicitly calling the newly compiled Java with -XX:+UseSerialGC to do small workloads. This is not a bug in the JVM, but rather an unfortunate consequence of the

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v2]

2024-06-23 Thread Jan Kratochvil
On Sun, 23 Jun 2024 13:18:19 GMT, Jan Kratochvil wrote: >> fastdebug: >> >> >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # Internal Error >> (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), >> pid=878152, tid=878158 >> # assert

Re: RFR: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack? [v2]

2024-06-23 Thread Jan Kratochvil
> fastdebug: > > > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error > (/home/azul/azul/openjdk-git/src/hotspot/share/runtime/handles.inline.hpp:77), > pid=878152, tid=878158 > # assert(_thread->is_in_live_stack((address)this)) failed: not on stack? > #

Withdrawn: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used

2024-06-23 Thread Daniel Jeliński
On Tue, 18 Jun 2024 21:01:15 GMT, Daniel Jeliński wrote: > We use 2 ParkEvent instances per thread. The ParkEvent objects are never > freed, but they are recycled when a thread dies, so the number of live > ParkEvent instances is proportional to the maximum number of threads that > were live a

Re: RFR: 8331553: Windows JVM leaks Event and Thread handles when multiple threads are used [v2]

2024-06-23 Thread Daniel Jeliński
On Wed, 19 Jun 2024 16:50:22 GMT, Daniel Jeliński wrote: >> We use 2 ParkEvent instances per thread. The ParkEvent objects are never >> freed, but they are recycled when a thread dies, so the number of live >> ParkEvent instances is proportional to the maximum number of threads that >> were li