Re: RFR: 8319573: Change to Visual Studio 17.6.5 for building on Windows at Oracle

2023-11-06 Thread Erik Joelsson
On Mon, 6 Nov 2023 23:00:39 GMT, Mikael Vidstedt wrote: > Oracle is updating the version of Visual Studio for building the JDK on > Windows to Visual Studio 2022 17.6.5. Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16533#pullrequestreview-1

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments

2023-11-06 Thread Erik Joelsson
On Thu, 26 Oct 2023 23:29:00 GMT, Jonathan Gibbons wrote: > Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.inte

Re: RFR: 8318913: The module-infos for --release data do not contain pre-set versions

2023-11-06 Thread Erik Joelsson
On Fri, 27 Oct 2023 11:35:54 GMT, Jan Lahoda wrote: > Consider a simple module, like: > > module test {} > > > And compile it with JDK 22 and JDK 21 using: > javac --release 21 > > The results of the compilations will differ: when compiling with JDK 21, the > mandated java.base dependency wi

Re: RFR: 8319197: Exclude hb-subset and hb-style from compilation

2023-11-06 Thread Phil Race
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote: > hb-subset and hb-style APIs are not used and not exported by libfontmanger. > We can cut the compilation time by not compiling the unused files. > > The added exclusions reduce the build time by ~1 minute (~8%) on my machine. > This is

RFR: 8319573: Change to Visual Studio 17.6.5 for building on Windows at Oracle

2023-11-06 Thread Mikael Vidstedt
Oracle is updating the version of Visual Studio for building the JDK on Windows to Visual Studio 2022 17.6.5. - Commit messages: - 8319573: Change to Visual Studio 17.6.5 for building on Windows at Oracle Changes: https://git.openjdk.org/jdk/pull/16533/files Webrev: https://webrev

Re: RFR: 8319197: Exclude hb-subset and hb-style from compilation

2023-11-06 Thread Daniel Jeliński
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote: > hb-subset and hb-style APIs are not used and not exported by libfontmanger. > We can cut the compilation time by not compiling the unused files. > > The added exclusions reduce the build time by ~1 minute (~8%) on my machine. > This is

Re: RFR: 8319197: Exclude hb-subset and hb-style from compilation

2023-11-06 Thread Phil Race
On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński wrote: > hb-subset and hb-style APIs are not used and not exported by libfontmanger. > We can cut the compilation time by not compiling the unused files. > > The added exclusions reduce the build time by ~1 minute (~8%) on my machine. > This is

Re: building on macOS 14

2023-11-06 Thread Philip Race
We only just switched to macos 13 SDK a few of weeks ago, so the next upgrade is probably a year away. I can't see us popping up a user dialog. Even for a UI app. That would cause additional problems. But when we see a fix for this on the Apple side, then we'll be able to make a more informed de

Re: building on macOS 14

2023-11-06 Thread Alan Snyder
> On Nov 3, 2023, at 2:51 PM, Philip Race wrote: > > So, yes, it is a bug on the Apple side and will be fixed in (I think) a macOS > 14 update. > > -phil. So, how long do you think the JDK can continue using the macOS 13 SDK? Until macOS 14 is no longer supported? As soon as the JDK start

RFR: JDK-8298405: Support Markdown in Documentation Comments

2023-11-06 Thread Jonathan Gibbons
Please review a patch to add support for Markdown syntax in documentation comments, as described in the associated JEP. Notable features: * support for `///` documentation comments in `JavaTokenizer` * new module `jdk.internal.md` -- a private copy of the `commonmark-java` library * updates to

RFR: 8318913: The module-infos for --release data do not contain pre-set versions

2023-11-06 Thread Jan Lahoda
Consider a simple module, like: module test {} And compile it with JDK 22 and JDK 21 using: javac --release 21 The results of the compilations will differ: when compiling with JDK 21, the mandated java.base dependency will get a version, possibly like "21-internal". When compiling with JDK 22

Re: Cannot configure on Windows in Chinese Environment

2023-11-06 Thread 吴国璋
Thanks Magnus for your opionion. Just one thing to point out: reaching out to Microsoft is not needed. Here is the reason:If Visual Studio is installed with both English and another language pack, cl.exe will present itself in English while running configure.If Visual Studio is installed without En

Re: RFR: 8319197: Exclude hb-subset and hb-style from compilation

2023-11-06 Thread Daniel Jeliński
On Mon, 6 Nov 2023 13:09:08 GMT, Daniel Jeliński wrote: >> @djelinski Just curious; what would the effect be to both include this >> change and setting the NO_* defines? >> >> If all the references to these defines are made in the excluded files then >> the only reason for doing that would be

Re: RFR: 8319197: Exclude hb-subset and hb-style from compilation

2023-11-06 Thread Daniel Jeliński
On Mon, 6 Nov 2023 12:26:58 GMT, Magnus Ihse Bursie wrote: >> FWIW, I compiled the code without this PR, but with `HARFBUZZ_CFLAGS += >> -DHB_NO_SUBSET_LAYOUT -DHB_NO_SUBSET_CFF` instead, and checked `make >> LOG=profile` output. Results: >> - without this change, compiling `hb-subset.cc` took

Re: building on macOS 14

2023-11-06 Thread Magnus Ihse Bursie
On 2023-11-03 21:09, Alan Snyder wrote: On Nov 3, 2023, at 11:54 AM, erik.joels...@oracle.com wrote: If you change out the toolchain through xcode-select, then you definitely need to reconfigure after. I would expect the configuration to be quite messed up if you don’t.. OK, but I think i

Re: Cannot configure on Windows in Chinese Environment

2023-11-06 Thread Magnus Ihse Bursie
Let me expand a bit on what Erik says, and also somewhat contradict him. :-) There is an open bug for documenting that en-US locale is needed to build the JDK on Windows: https://bugs.openjdk.org/browse/JDK-8264425 Unfortunately I have never gotten around to actually write this down in the do

Re: RFR: 8319197: Exclude hb-subset and hb-style from compilation

2023-11-06 Thread Magnus Ihse Bursie
On Fri, 3 Nov 2023 06:06:29 GMT, Daniel Jeliński wrote: >> You can find the file here: >> https://github.com/openjdk/jdk/blob/f262f06c97b9ea94cd6119b3a8beb16bf804d083/src/java.desktop/share/native/libharfbuzz/graph/gsubgpos-context.cc >> >> Hb-subset files are not guarded by ifdefs; HB_NO_SUBSET

Re: RFR: JDK-8313790: [arm32] Specify -marm when building without an ABI profile [v2]

2023-11-06 Thread Magnus Ihse Bursie
On Sat, 4 Nov 2023 06:39:34 GMT, Thomas Stuefe wrote: >> See [JDK-8288719](https://bugs.openjdk.org/browse/JDK-8288719) and >> subsequent >> [discussion](https://mail.openjdk.org/pipermail/build-dev/2022-May/034635.html) >> back in 2022. >> >> On Arm, we can generate either arm- or thumb-code