Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v33]

2023-09-07 Thread Alan Bateman
On Thu, 31 Aug 2023 21:31:40 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v33]

2023-09-07 Thread Paul Sandoz
On Thu, 31 Aug 2023 21:31:40 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v33]

2023-09-07 Thread Srinivas Vamsi Parasa
On Thu, 31 Aug 2023 21:31:40 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v3]

2023-09-07 Thread Tim Prinzing
On Tue, 22 Aug 2023 07:18:21 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/net/Socket.java line 1133: >> >>> 1131: return parent.getSoTimeout(); >>> 1132: } catch (Throwable t) { >>> 1133: // ignored - avoiding exceptions in jfr event da

Re: RFR: 8308995: Update Network IO JFR events to be static mirror events [v5]

2023-09-07 Thread Tim Prinzing
> The socket read/write JFR events currently use instrumentation of java.base > code using templates in the jdk.jfr modules. This results in some java.base > code residing in the jdk.jfr module which is undesirable. > > JDK19 added static support for event classes. The old instrumentor classes

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-07 Thread Antonios Printezis
On Wed, 6 Sep 2023 14:29:56 GMT, Antonios Printezis wrote: > The build failure happens when building on RISC-V with GCC 12.3. Is there a > better way to address this than disabling the stringop-overflow warnings for > the two files in question? I should have included the full error messages (m

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-07 Thread Antonios Printezis
On Thu, 7 Sep 2023 18:35:29 GMT, Kim Barrett wrote: >> Just for the record, this is very likely >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104475 . > > I'd like to not disable the warnings without a better understanding of the > problem. I agree with @theRealAph that gcc > bug 104475 is l

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-07 Thread Antonios Printezis
On Thu, 7 Sep 2023 11:08:45 GMT, Andrew Haley wrote: > Just for the record, this is very likely > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104475 . @theRealAph Thanks for the heads up! - PR Comment: https://git.openjdk.org/jdk/pull/15593#issuecomment-1710760934

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-07 Thread Antonios Printezis
On Wed, 6 Sep 2023 14:29:56 GMT, Antonios Printezis wrote: > The build failure happens when building on RISC-V with GCC 12.3. Is there a > better way to address this than disabling the stringop-overflow warnings for > the two files in question? > Hi, I once created a similar JBS issue and prov

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v33]

2023-09-07 Thread Paul Sandoz
On Thu, 31 Aug 2023 21:31:40 GMT, Srinivas Vamsi Parasa wrote: >> The goal is to develop faster sort routines for x86_64 CPUs by taking >> advantage of AVX512 instructions. This enhancement provides an order of >> magnitude speedup for Arrays.sort() using int, long, float and double arrays. >>

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v18]

2023-09-07 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-07 Thread Kim Barrett
On Thu, 7 Sep 2023 11:08:45 GMT, Andrew Haley wrote: >> The build failure happens when building on RISC-V with GCC 12.3. Is there a >> better way to address this than disabling the stringop-overflow warnings for >> the two files in question? > > Just for the record, this is very likely > https

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-07 Thread Kim Barrett
On Wed, 6 Sep 2023 14:29:56 GMT, Antonios Printezis wrote: > The build failure happens when building on RISC-V with GCC 12.3. Is there a > better way to address this than disabling the stringop-overflow warnings for > the two files in question? The fix for [JDK-8294031](https://bugs.openjdk.or

RFR: 8315786 : [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX

2023-09-07 Thread Deepa Kumari
Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , the AIX build process raised complaints about the disk location detection, incorrectly determining that the build wasn't on a local disk. However, a partial fix introduced a new problem, the build process consistently re

Re: RFR: 8315863: [GHA] Update checkout action to use v4

2023-09-07 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 16:27:18 GMT, Christian Stein wrote: > > Please wait for GHA to complete before integrating GHA patches! > > Yes, sure. Next time, I'll wait for completion - this time, I checked that > `actions/checkout@v4` steps were successfully run in > https://github.com/openjdk/jdk/pul

Re: RFR: 8315863: [GHA] Update checkout action to use v4

2023-09-07 Thread Christian Stein
On Thu, 7 Sep 2023 16:16:36 GMT, Aleksey Shipilev wrote: > Please wait for GHA to complete before integrating GHA patches! Yes, sure. Next time, I'll wait for completion - this time, I checked that `actions/checkout@v4` steps were successfully run in https://github.com/openjdk/jdk/pull/15620/c

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v17]

2023-09-07 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Integrated: 8315863: [GHA] Update checkout action to use v4

2023-09-07 Thread Christian Stein
On Thu, 7 Sep 2023 14:47:41 GMT, Christian Stein wrote: > Please review this change to update all workflows to use > `actions/checkout@v4`. > > Find the associated release notes here: > https://github.com/actions/checkout/releases/tag/v4.0.0 This pull request has now been integrated. Changes

Re: RFR: 8315863: [GHA] Update checkout action to use v4

2023-09-07 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 14:47:41 GMT, Christian Stein wrote: > Please review this change to update all workflows to use > `actions/checkout@v4`. > > Find the associated release notes here: > https://github.com/actions/checkout/releases/tag/v4.0.0 Please wait for GHA to complete before integrating

Re: RFR: 8315863: [GHA] Update checkout action to use v4

2023-09-07 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 14:47:41 GMT, Christian Stein wrote: > Please review this change to update all workflows to use > `actions/checkout@v4`. > > Find the associated release notes here: > https://github.com/actions/checkout/releases/tag/v4.0.0 Oh, okay then! - Marked as reviewed b

Re: RFR: 8315863: [GHA] Update checkout action to use v4

2023-09-07 Thread Aleksey Shipilev
On Thu, 7 Sep 2023 14:47:41 GMT, Christian Stein wrote: > Please review this change to update all workflows to use > `actions/checkout@v4`. > > Find the associated release notes here: > https://github.com/actions/checkout/releases/tag/v4.0.0 I guess we can do this, but does it fix any actual

Re: RFR: 8315863: [GHA] Update checkout action to use v4

2023-09-07 Thread Christian Stein
On Thu, 7 Sep 2023 14:47:41 GMT, Christian Stein wrote: > Please review this change to update all workflows to use > `actions/checkout@v4`. > > Find the associated release notes here: > https://github.com/actions/checkout/releases/tag/v4.0.0 Mainly because the underlying Node version used by

RFR: 8315863: [GHA] Update checkout action to use v4

2023-09-07 Thread Christian Stein
Please review this change to update all workflows to use `actions/checkout@v4`. Find the associated release notes here: https://github.com/actions/checkout/releases/tag/v4.0.0 - Commit messages: - 8315863: [GHA] Update checkout action to use v4 Changes: https://git.openjdk.org/jdk

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v15]

2023-09-07 Thread Jorn Vernee
On Thu, 7 Sep 2023 11:39:30 GMT, Jorn Vernee wrote: >> This patch contains the implementation of the foreign linker & memory API >> JEP for Java 22. The initial patch is composed of commits brought over >> directly from the [panama-foreign >> repo](https://github.com/openjdk/panama-foreign). T

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v16]

2023-09-07 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v10]

2023-09-07 Thread Jorn Vernee
On Wed, 6 Sep 2023 16:03:40 GMT, Paul Sandoz wrote: >> [This SO question](https://stackoverflow.com/a/40348010) points to a gitlab >> repo that seems to have the latest version: >> https://gitlab.com/x86-psABIs/x86-64-ABI But, I'm not sure how stable that >> is, or if that's an authoritative s

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v15]

2023-09-07 Thread Jorn Vernee
> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-07 Thread Andrew Haley
On Wed, 6 Sep 2023 14:29:56 GMT, Antonios Printezis wrote: > The build failure happens when building on RISC-V with GCC 12.3. Is there a > better way to address this than disabling the stringop-overflow warnings for > the two files in question? Just for the record, this is very likely https:/

Re: RFR: 8315794: RISC-V: build fails with GCC 12.3

2023-09-07 Thread Robbin Ehn
On Wed, 6 Sep 2023 14:29:56 GMT, Antonios Printezis wrote: > The build failure happens when building on RISC-V with GCC 12.3. Is there a > better way to address this than disabling the stringop-overflow warnings for > the two files in question? Thanks! I don't see any other non-trivial work a