Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-23 Thread Alan Bateman
On Thu, 23 Feb 2023 19:34:44 GMT, Naoto Sato wrote: >> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since >> this is not a compatible upgrade to the existing mapping, a new system >> property `jdk.charset.GB18030` is introduced. If it is set to "2000", the >> mapping f

Re: RFR: 8303131: pandoc.exe mangles all processed html files

2023-02-23 Thread Erik Joelsson
On Thu, 23 Feb 2023 19:18:32 GMT, Julian Waters wrote: > pandoc.exe follows the Windows CRLF format of newlines, whereas we only ever > have LF in our documentation files. As a result whenever we generate html the > resulting html files will all be mangled, even if there was no change to the >

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-23 Thread Naoto Sato
On Thu, 23 Feb 2023 10:07:22 GMT, Alan Bateman wrote: >> would use of jdk.internal.util.SystemProps be an option here (if having to >> retrieve that value when we're at VM init level <1 ? > >> would use of jdk.internal.util.SystemProps be an option here (if having to >> retrieve that value when

Re: RFR: 8301119: Support for GB18030-2022 [v3]

2023-02-23 Thread Naoto Sato
> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping falls back to the existing mapping based on the 2000 standa

RFR: 8303131: pandoc.exe mangles all processed html files

2023-02-23 Thread Julian Waters
pandoc.exe follows the Windows CRLF format of newlines, whereas we only ever have LF in our documentation files. As a result whenever we generate html the resulting html files will all be mangled, even if there was no change to the corresponding markdown file. This passes --eol=lf to pandoc so t

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-23 Thread Rich DiCroce
On Thu, 23 Feb 2023 14:42:42 GMT, Daniel Fuchs wrote: > > I searched for other WinAPIs of interest; > > [GetIfStackTable](https://learn.microsoft.com/en-us/windows/win32/api/netioapi/nf-netioapi-getifstacktable) > > caught my attention. > > As far as I could see, the network interfaces are arra

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-23 Thread Daniel Fuchs
On Thu, 23 Feb 2023 12:44:30 GMT, Daniel Jeliński wrote: > I searched for other WinAPIs of interest; > [GetIfStackTable](https://learn.microsoft.com/en-us/windows/win32/api/netioapi/nf-netioapi-getifstacktable) > caught my attention. > As far as I could see, the network interfaces are arranged

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-23 Thread Daniel Jeliński
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote: >> Improves performance and correctness, as discussed on the net-dev mailing >> list. > > Rich DiCroce has updated the pull request incrementally with two additional > commits since the last revision: > > - Forgot to add file > - Resolve

Re: RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

2023-02-23 Thread Daniel Jeliński
On Wed, 22 Feb 2023 17:40:31 GMT, Rich DiCroce wrote: >> Improves performance and correctness, as discussed on the net-dev mailing >> list. > > Rich DiCroce has updated the pull request incrementally with two additional > commits since the last revision: > > - Forgot to add file > - Resolve

Re: RFR: 8301119: Support for GB18030-2022 [v2]

2023-02-23 Thread Alan Bateman
On Thu, 23 Feb 2023 09:48:39 GMT, Sean Coffey wrote: > would use of jdk.internal.util.SystemProps be an option here (if having to > retrieve that value when we're at VM init level <1 ? The early startup scenario is early in the system property initialization, specifically SystemProps.Raw. whic

Re: RFR: 8301119: Support for GB18030-2022 [v2]

2023-02-23 Thread Sean Coffey
On Thu, 23 Feb 2023 09:03:49 GMT, Alan Bateman wrote: >> Scratch that: as it seems to be important that we don't switch after startup >> then what this code is really reaching for is `static final` field >> semantics. Since `StandardCharsets` might be loaded very early a holder >> class patter

Re: RFR: 8301119: Support for GB18030-2022 [v2]

2023-02-23 Thread Alan Bateman
On Thu, 23 Feb 2023 08:55:08 GMT, Claes Redestad wrote: >> `@Stable` semantics are still fuzzy to me but the rule I've adhered to is >> that back to back stores to the field - if unavoidable - needs to be >> idempotent since the JIT (or AOT) may record any non-null value as a compile >> time c

Re: RFR: 8301119: Support for GB18030-2022 [v2]

2023-02-23 Thread Claes Redestad
On Thu, 23 Feb 2023 08:32:29 GMT, Claes Redestad wrote: >> `Charset` class is initialized *before* system properties are set up, in >> order to check the JNU encoding (used for file path name) is a supported >> charset or not. In some OS environments, GB18030 is the native encoding so >> we ne

Re: RFR: 8301119: Support for GB18030-2022 [v2]

2023-02-23 Thread Claes Redestad
On Wed, 22 Feb 2023 17:52:01 GMT, Naoto Sato wrote: >>> curious - what scenario triggers this call at initLevel < 1 ? >> >> It's not supported, but it is possible that someone might run with >> -Dfile.encoding=GB18030, in which case the default charset is used before >> the system properties a