RFR: JDK-8298448: UndefinedBehaviorSanitizer

2022-12-08 Thread Justin King
Allow building OpenJDK with UBSan. Currently the build fails when optimizing the image due to lots of undefined behavior (it invokes the built JVM). Follow up PRs will either replace the undefined behavior with well defined behavior or suppress errors which are intentional. The goal is to make O

[jdk20] RFR: 8298324: Unable to run shell test with make

2022-12-08 Thread Erik Joelsson
The parsing of the TestID in the TEST parameter currently only handles tests that are .java files. Jtreg tests can also be .html and .sh files. This patch extends the macro to also handle these kinds of files. Without the patch, trying to run a shell test directly would fail like this: $ make

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v5]

2022-12-08 Thread Julian Waters
On Fri, 18 Nov 2022 11:27:14 GMT, Magnus Ihse Bursie wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Uh oh > > Aaaahhh, **that** bug. I've run into that before. I did attempt to fix it but > after wasting too man

Re: RFR: 8298050: Add links to graph output for javadoc

2022-12-08 Thread Pavel Rappo
On Thu, 8 Dec 2022 16:22:30 GMT, Jonathan Gibbons wrote: >> make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 207: >> >>> 205: private static String relativeLink(TypeElement rootNode, >>> TypeElement node) { >>> 206: var backNavigator = >>> rootNode.getQ

Re: RFR: 8298050: Add links to graph output for javadoc

2022-12-08 Thread Pavel Rappo
On Thu, 8 Dec 2022 09:19:54 GMT, Per Minborg wrote: > This PR proposes adding hyperlinks to the sealed graphic layout making > navigation much simpler via the image. Given that this feature is welcome, I would suggest changing the priority of the respective JBS issue to P3, withdrawing this PR

Re: RFR: 8298050: Add links to graph output for javadoc

2022-12-08 Thread Jonathan Gibbons
On Thu, 8 Dec 2022 16:18:02 GMT, Pavel Rappo wrote: >> This PR proposes adding hyperlinks to the sealed graphic layout making >> navigation much simpler via the image. > > make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 207: > >> 205: private static String relativeLink

Re: RFR: 8298050: Add links to graph output for javadoc

2022-12-08 Thread Jonathan Gibbons
On Thu, 8 Dec 2022 09:19:54 GMT, Per Minborg wrote: > This PR proposes adding hyperlinks to the sealed graphic layout making > navigation much simpler via the image. make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 209: > 207: .filter(c -> '.' == c) > 208:

Integrated: JDK-8296149: Start of release updates for JDK 21

2022-12-08 Thread Joe Darcy
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote: > Usual start-of-release updates. Symbol updates in initial version reflect JDK > 20 build 21. This pull request has now been integrated. Changeset: 175e3d3f Author:Joe Darcy Committer: Jesper Wilhelmsson URL: https://git.openjdk.o

Integrated: 8298383: JFR: GenerateJfrFiles.java lacks copyright header

2022-12-08 Thread Erik Gahlin
On Thu, 8 Dec 2022 13:19:18 GMT, Erik Gahlin wrote: > Could I have a review of a PR that adds missing copyright header to > GenerateJfrFiles.java > > Testing: tier1 > > Thanks > Erik This pull request has now been integrated. Changeset: e555d547 Author:Erik Gahlin URL: https://g

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v14]

2022-12-08 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

Re: RFR: 8298383: JFR: GenerateJfrFiles.java lacks copyright header [v2]

2022-12-08 Thread Erik Joelsson
On Thu, 8 Dec 2022 13:50:14 GMT, Erik Gahlin wrote: >> Could I have a review of a PR that adds missing copyright header to >> GenerateJfrFiles.java >> >> Testing: tier1 >> >> Thanks >> Erik > > Erik Gahlin has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v13]

2022-12-08 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

Re: RFR: 8298383: JFR: GenerateJfrFiles.java lacks copyright header [v2]

2022-12-08 Thread Markus Grönlund
On Thu, 8 Dec 2022 13:50:14 GMT, Erik Gahlin wrote: >> Could I have a review of a PR that adds missing copyright header to >> GenerateJfrFiles.java >> >> Testing: tier1 >> >> Thanks >> Erik > > Erik Gahlin has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v8]

2022-12-08 Thread Julian Waters
On Tue, 6 Dec 2022 19:32:27 GMT, Magnus Ihse Bursie wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> CHECK_VALUE > > make/autoconf/jdk-version.m4 line 571: > >> 569: DESC: [Set the MacOSX Bundle CFBundleVersio

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v12]

2022-12-08 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

Re: RFR: 8298383: JFR: GenerateJfrFiles.java lacks copyright header [v2]

2022-12-08 Thread Erik Gahlin
> Could I have a review of PR that adds missing copyright header to > GenerateJfrFiles.java > > Testing: tier1 > > Thanks > Erik Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Update year - Changes: - all: https://

RFR: 8298383: JFR: GenerateJfrFiles.java lacks copyright header

2022-12-08 Thread Erik Gahlin
Could I have a review of PR that adds missing copyright header to GenerateJfrFiles.java Testing: tier1 Thanks Erik - Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/11591/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11591&range=00 Issue: https:/

Integrated: 8298175: JFR: Common timestamp for periodic events

2022-12-08 Thread Erik Gahlin
On Tue, 6 Dec 2022 15:31:22 GMT, Erik Gahlin wrote: > Could I have review of infrastructure that makes it easier to write periodic > events with the same timestamp. > > Testing: jdk/jdk/jfr + tier1 + tier2 > > Thanks > Erik This pull request has now been integrated. Changeset: 9353899b Autho

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v11]

2022-12-08 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH [v10]

2022-12-08 Thread Julian Waters
> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that still use AC_ARG_WITH in jdk-version.m4. > They are out

RFR: 8298050: Add links to graph output for javadoc

2022-12-08 Thread Per Minborg
This PR proposes adding hyperlinks to the sealed graphic layout making navigation much simpler via the image. - Commit messages: - Remove unused import - Add relative hyperlinks to nodes Changes: https://git.openjdk.org/jdk/pull/11580/files Webrev: https://webrevs.openjdk.org/?re