Re: RFR: 8296886: Fix various include sort order issues

2022-11-11 Thread Kim Barrett
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote: > The sorted blocks of includes have deteriorated to the point that I felt > compelled to clean up some of the issues. > > One of the more prevalent issues is that files in src/hotspot/share/include > are not properly sorted. There has b

Integrated: 8296758: [BACKOUT] Revert 8296115

2022-11-11 Thread Julian Waters
On Thu, 10 Nov 2022 03:25:33 GMT, Julian Waters wrote: > 8296115 unfortunately did not prove to be as useful as expected, revert it > and reopen 8241499 for a future change (which I'll likely address soon). This pull request has now been integrated. Changeset: f0b648bc Author:Julian Waters

Integrated: 8296872: gtest is built with the build-jdk

2022-11-11 Thread Magnus Ihse Bursie
On Fri, 11 Nov 2022 11:07:39 GMT, Magnus Ihse Bursie wrote: > The build-jdk is a JDK built on the current sources that can execute on the > build platform. This is needed when cross-compiling, in addition to the > boot-jdk (which runs on the build platform, but is an older version of the > JDK

Re: RFR: 8296872: gtest is built with the build-jdk

2022-11-11 Thread Mikael Vidstedt
On Fri, 11 Nov 2022 11:07:39 GMT, Magnus Ihse Bursie wrote: > The build-jdk is a JDK built on the current sources that can execute on the > build platform. This is needed when cross-compiling, in addition to the > boot-jdk (which runs on the build platform, but is an older version of the > JDK

Re: RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH

2022-11-11 Thread Julian Waters
On Mon, 7 Nov 2022 14:39:02 GMT, Julian Waters wrote: > 8285093 introduced the new UTIL_ARG_WITH definition, which was not available > when both 8282948 and 8282700 were written. They can now be moved to using > the cleaner logic that UTIL_ARG_WITH grants. > > There are many more options that

RFR: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH

2022-11-11 Thread Julian Waters
8285093 introduced the new UTIL_ARG_WITH definition, which was not available when both 8282948 and 8282700 were written. They can now be moved to using the cleaner logic that UTIL_ARG_WITH grants. There are many more options that still use AC_ARG_WITH in jdk-version.m4. They are out of the scop

Re: RFR: 8296886: Fix various include sort order issues

2022-11-11 Thread Erik Österlund
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote: > The sorted blocks of includes have deteriorated to the point that I felt > compelled to clean up some of the issues. > > One of the more prevalent issues is that files in src/hotspot/share/include > are not properly sorted. There has b

RFR: 8296886: Fix various include sort order issues

2022-11-11 Thread Stefan Karlsson
The sorted blocks of includes have deteriorated to the point that I felt compelled to clean up some of the issues. One of the more prevalent issues is that files in src/hotspot/share/include are not properly sorted. There has been some discussion that that was done on purpose, but it just adds

Re: RFR: 8296872: gtest is built with the build-jdk

2022-11-11 Thread David Holmes
On Fri, 11 Nov 2022 11:07:39 GMT, Magnus Ihse Bursie wrote: > The build-jdk is a JDK built on the current sources that can execute on the > build platform. This is needed when cross-compiling, in addition to the > boot-jdk (which runs on the build platform, but is an older version of the > JDK

RFR: 8296872: gtest is built with the build-jdk

2022-11-11 Thread Magnus Ihse Bursie
The build-jdk is a JDK built on the current sources that can execute on the build platform. This is needed when cross-compiling, in addition to the boot-jdk (which runs on the build platform, but is an older version of the JDK), and is different from the JDK resulting from the build (which can o