Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread John R Rose
On Tue, 25 Oct 2022 23:13:08 GMT, Vladimir Ivanov wrote: > …very modest impact while still being able to catch important types of MXCSR > corruption. I fully support having it turned on by default for JNI calls. I guess I agree. With the clever test for the bad mode Java cares about, the over

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread David Holmes
On 26/10/2022 1:02 am, Andrew Haley wrote: On Tue, 25 Oct 2022 14:46:57 GMT, Florian Weimer wrote: Sorry, I feel like this has gone a bit off track. It started as some hardening for `loadLibrary`, but now it's about making all JNI calls a bit slower? Is there any data to suggest that this is

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread Vladimir Ivanov
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

Re: RFR: 8295884: Support for development with the Eclipse IDE

2022-10-25 Thread Erik Joelsson
On Tue, 25 Oct 2022 13:23:34 GMT, Julian Waters wrote: > Eclipse is a popular and very well-known IDE in the world of Java > development, utilized widely in many contexts, by beginners and experienced > teams alike. Although a relatively lightweight IDE, it features surprisingly > powerful ind

Re: RFR: 8295885: GHA: Bump gcc versions

2022-10-25 Thread Aleksey Shipilev
On Tue, 25 Oct 2022 12:50:02 GMT, Zixian Cai wrote: > Recent PRs have to start to fail due to failed gcc installations. For > example, #10850 has [linux-x86 / build > (release)](https://github.com/tschatzl/jdk/actions/runs/3319164391/jobs/5483988905) > and [linux-cross-compile / build > (risc

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-25 Thread Naoto Sato
On Tue, 25 Oct 2022 13:43:56 GMT, Weijun Wang wrote: > I wonder if this means even if we get everything right now the tool might add > trailing spaces again later. Good catch, Max. Yes, that should be dealt with in the translation process. > I suggest we focus on the English files this time an

Re: RFR: 8295554: Move the "sizecalc.h" to the correct location

2022-10-25 Thread Alexey Ivanov
On Mon, 24 Oct 2022 20:50:19 GMT, Magnus Ihse Bursie wrote: >> The "sizecalc.h" file is moved out from java.desktop/share/native/include, >> the files in that folder appear in the jdk bundle after installation like >> the "jawt.h". > > Thank you for waiting while we sorted out the details. This

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread Andrew Haley
On Tue, 18 Oct 2022 07:46:35 GMT, Florian Weimer wrote: > I wonder if something that focuses on diagnostic tools might be better here, > particularly if there hasn't been any reported breakage. The `dlopen` > protection is of course very incomplete because any JNI call can change the > state i

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread Andrew Haley
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread Andrew Haley
On Tue, 25 Oct 2022 14:46:57 GMT, Florian Weimer wrote: > Sorry, I feel like this has gone a bit off track. It started as some > hardening for `loadLibrary`, but now it's about making all JNI calls a bit > slower? Is there any data to suggest that this is necessary? > > Would it be possible to

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread Florian Weimer
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread Andrew Haley
On Tue, 25 Oct 2022 13:29:52 GMT, Andrew Haley wrote: > Enabling `-XX:+RestoreMXCSROnJNICalls` makes the overhead much worse: > > ``` > Benchmark Mode Cnt Score Error Units > CallOverheadConstant.jni_blank avgt 40 14.741 ± 0.031 ns/op > CallOverheadConstant

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread Andrew Haley
On Thu, 20 Oct 2022 20:26:47 GMT, Vladimir Ivanov wrote: > The GCC bugs with `-ffast-math` only corrupts `FTZ` and `DAZ`. > > But `RC` and exception masks may be corrupted as well the same way and I > believe the consequences are be similar (silent divergence in results during > FP computation

RFR: 8295884: Support for development with the Eclipse IDE

2022-10-25 Thread Julian Waters
Eclipse is a popular and very well-known IDE in the world of Java development, utilized widely in many contexts, by beginners and experienced teams alike. Although a relatively lightweight IDE, it features surprisingly powerful indexing and code analysis capabilities, as well as useful tools, am

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-25 Thread Weijun Wang
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-25 Thread Andrew Haley
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

RFR: 8295885: GHA: Bump gcc versions

2022-10-25 Thread Zixian Cai
Recent PRs have to start to fail due to failed gcc installations. For example, #10850 has [linux-x86 / build (release)](https://github.com/tschatzl/jdk/actions/runs/3319164391/jobs/5483988905) and [linux-cross-compile / build (riscv64)](https://github.com/tschatzl/jdk/actions/runs/3319164391/jo

Re: RFR: 8295885: GHA: Bump gcc versions

2022-10-25 Thread Aleksey Shipilev
On Tue, 25 Oct 2022 12:50:02 GMT, Zixian Cai wrote: > Recent PRs have to start to fail due to failed gcc installations. For > example, #10850 has [linux-x86 / build > (release)](https://github.com/tschatzl/jdk/actions/runs/3319164391/jobs/5483988905) > and [linux-cross-compile / build > (risc

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-10-25 Thread Weijun Wang
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Integrated: 8287754: Update jib GNU make dependency on Windows to latest cygwin build

2022-10-25 Thread Erik Joelsson
On Thu, 20 Oct 2022 21:49:41 GMT, Erik Joelsson wrote: > For Oracle internal builds we control the version of GNU Make (currently > fixed at 4.0). In Cygwin this is causing problems as the now rather dated GNU > Make binary we use isn't compatible with Cygwin.dll version 3.3 or later. To > wor

Re: RFR: 8295868: 32-bit Windows build failures after JDK-8294466

2022-10-25 Thread Erik Joelsson
On Tue, 25 Oct 2022 10:40:05 GMT, Aleksey Shipilev wrote: > Fails like this: > > > * For target > support_native_java.desktop_libsplashscreen_splashscreen_impl.obj: > splashscreen_impl.c > c:\buildbot\worker\build-jdkx-windows\build\src\java.desktop\share\native\libsplashscreen\splashscreen_im

RFR: 8295868: 32-bit Windows build failures after JDK-8294466

2022-10-25 Thread Aleksey Shipilev
Fails like this: * For target support_native_java.desktop_libsplashscreen_splashscreen_impl.obj: splashscreen_impl.c c:\buildbot\worker\build-jdkx-windows\build\src\java.desktop\share\native\libsplashscreen\splashscreen_impl.c(443): error C2220: the following warning is treated as an error c:\bu

Integrated: 8295554: Move the "sizecalc.h" to the correct location

2022-10-25 Thread Sergey Bylokhov
On Wed, 19 Oct 2022 08:15:54 GMT, Sergey Bylokhov wrote: > The "sizecalc.h" file is moved out from java.desktop/share/native/include, > the files in that folder appear in the jdk bundle after installation like the > "jawt.h". This pull request has now been integrated. Changeset: 6673cd85 Auth

Re: RFR: 8295653: Add a graph of the sealed class hierarchy for marked classes [v4]

2022-10-25 Thread Andrey Turbanov
On Mon, 24 Oct 2022 20:44:08 GMT, Magnus Ihse Bursie wrote: >> It would be possible to mark classes with `@sealedGraph` to indicate that >> the sealed hierarchy should be rendered graphically in the JavaDocs. Classes >> not marked would be unaffected, creating an opt-in approach. >> >> [Here](