Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-05 Thread ScientificWare
On Tue, 5 Jul 2022 01:53:33 GMT, Julian Waters wrote: >> This is tracked in JBS as >> >> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) >> >>> **Remove unused imports from DTDBuilder.java** >> Some imports are no more used. >> >> - java.io.FileNotFoundException; >> - java.io.Buffer

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-05 Thread Julian Waters
On Tue, 5 Jul 2022 03:40:51 GMT, Julian Waters wrote: >> This is tracked in JBS as >> >> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) >> >>> **Remove unused imports from DTDBuilder.java** >> Some imports are no more used. >> >> - java.io.FileNotFoundException; >> - java.io.Buffer

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-05 Thread ScientificWare
On Tue, 5 Jul 2022 11:34:05 GMT, Julian Waters wrote: >> Alright, was asking since I can help create one for you, but it seems that >> others already have it covered > >> @TheShermanTanker , thank you for asking and helping. >> >> > it seems that others already have it covered >> >> In fact, I

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-05 Thread Julian Waters
On Mon, 4 Jul 2022 07:04:40 GMT, ScientificWare wrote: > This is tracked in JBS as > > [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) > >> **Remove unused imports from DTDBuilder.java** > Some imports are no more used. > > - java.io.FileNotFoundException; > - java.io.BufferedInputS

Re: Warning about git from 'make test' on Windows

2022-07-05 Thread Magnus Ihse Bursie
Christoph, Andrey, Thanks for your input and debugging. I have created https://bugs.openjdk.org/browse/JDK-8289735 to track this. I believe this is easy to fix, but I'm not sure I'm able to provide a PR before I leave on vacation. /Magnus On 2022-06-03 09:09, Langer, Christoph wrote: Hi,

RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-05 Thread ScientificWare
This is tracked in JBS as [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) > **Remove unused imports from DTDBuilder.java** Some imports are no more used. - java.io.FileNotFoundException; - java.io.BufferedInputStream; - java.io.OutputStream; - java.util.BitSet; - java.util.StringToken

Re: RFR: 8289646: configure script failed on WSL [v2]

2022-07-05 Thread Yasumasa Suenaga
On Mon, 4 Jul 2022 22:32:20 GMT, Yasumasa Suenaga wrote: >> configure failed as following when I run it on WSL 1. >> >> >> checking for version string... 20-internal-adhoc.yasuenag.jdk >> configure: Found potential Boot JDK using configure arguments >> configure: The command for java_to_test, w

Re: RFR: 8289646: configure script failed on WSL [v2]

2022-07-05 Thread Magnus Ihse Bursie
On Mon, 4 Jul 2022 22:32:20 GMT, Yasumasa Suenaga wrote: >> configure failed as following when I run it on WSL 1. >> >> >> checking for version string... 20-internal-adhoc.yasuenag.jdk >> configure: Found potential Boot JDK using configure arguments >> configure: The command for java_to_test, w

Re: RFR: 8289646: configure script failed on WSL

2022-07-05 Thread Yasumasa Suenaga
On Mon, 4 Jul 2022 16:26:21 GMT, Magnus Ihse Bursie wrote: > As a minimum, you need to verify that this works on WSL1, WSL2 and Cygwin. I tested my patch on both WSL 1 and 2. GHA will test on Cygwin (it seems to work). > It might also work on newer versions of wslpath but break on older, seein

Re: RFR: 8289646: configure script failed on WSL

2022-07-05 Thread Yasumasa Suenaga
On Mon, 4 Jul 2022 16:26:21 GMT, Magnus Ihse Bursie wrote: >> configure failed as following when I run it on WSL 1. >> >> >> checking for version string... 20-internal-adhoc.yasuenag.jdk >> configure: Found potential Boot JDK using configure arguments >> configure: The command for java_to_test,

Re: RFR: 8289646: configure script failed on WSL [v2]

2022-07-05 Thread Yasumasa Suenaga
> configure failed as following when I run it on WSL 1. > > > checking for version string... 20-internal-adhoc.yasuenag.jdk > configure: Found potential Boot JDK using configure arguments > configure: The command for java_to_test, which resolves as > "/mnt/d/java/jdk-18/bin/java", can not be fou

Re: RFR: 8289646: configure script failed on WSL

2022-07-05 Thread Magnus Ihse Bursie
On Mon, 4 Jul 2022 03:56:03 GMT, Yasumasa Suenaga wrote: > configure failed as following when I run it on WSL 1. > > > checking for version string... 20-internal-adhoc.yasuenag.jdk > configure: Found potential Boot JDK using configure arguments > configure: The command for java_to_test, which r