cu hw.ucomnames / cu.c 1.29 problem

2024-02-09 Thread aphekz
. shouldn't we have - err(1, "hw.ucomnames"); + break; as i'm not experienced enough to suggest diff (i might be missing sth) so.. verify that please. aphekz

Re: cu hw.ucomnames / cu.c 1.29 problem

2024-02-09 Thread aphekz
On Fri, Feb 09, 2024 at 09:52:53PM -0500, Kenneth Westerback wrote: > Looks correct to me. The value returned by get_ucomnames() is only > passed to find_ucom() where it is checked against NULL. > > aphekz, if you can confirm this works for you I can commit. yes, it w

Re: cu hw.ucomnames / cu.c 1.29 problem

2024-02-10 Thread aphekz
On Fri, Feb 09, 2024 at 08:44:25PM -0700, Theo de Raadt wrote: > Kenneth Westerback wrote: > > > Looks correct to me. The value returned by get_ucomnames() is only > > passed to find_ucom() where it is checked against NULL. > > Alternative diff in the kernel, *in addition* to the other diff. >