Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-03-05 Thread Theo de Raadt
Claudio Jeker wrote: > Thanks for the details. I suggest to commit this so we can get some tests > quickly and hopefully it helps to fix some of the wg(4) crashes people > hit. According to your other mail there are some additional races that > require fixing. quickly means now, and we have abou

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-03-05 Thread Claudio Jeker
On Tue, Mar 05, 2024 at 12:16:37PM +0300, Vitaliy Makkoveev wrote: > On Mon, Mar 04, 2024 at 01:00:32PM +0100, Claudio Jeker wrote: > > On Wed, Feb 28, 2024 at 06:03:14PM +0300, Vitaliy Makkoveev wrote: > > > On Wed, Feb 28, 2024 at 02:45:44PM +0100, Martin Pieuchot wrote: > > > > > > > > > > > >

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-03-05 Thread Vitaliy Makkoveev
On Mon, Mar 04, 2024 at 01:00:32PM +0100, Claudio Jeker wrote: > On Wed, Feb 28, 2024 at 06:03:14PM +0300, Vitaliy Makkoveev wrote: > > On Wed, Feb 28, 2024 at 02:45:44PM +0100, Martin Pieuchot wrote: > > > > > > > > > > > > Not only wg(4). Depends on interface queue usage, ifq_start() > > > > >

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-03-04 Thread Claudio Jeker
On Wed, Feb 28, 2024 at 06:03:14PM +0300, Vitaliy Makkoveev wrote: > On Wed, Feb 28, 2024 at 02:45:44PM +0100, Martin Pieuchot wrote: > > > > > > > > > > Not only wg(4). Depends on interface queue usage, ifq_start() > > > > > schedules > > > > > (*if_qstart)() or calls it, so all the interfaces w

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Vitaliy Makkoveev
On Wed, Feb 28, 2024 at 02:45:44PM +0100, Martin Pieuchot wrote: > > > > > > > > Not only wg(4). Depends on interface queue usage, ifq_start() schedules > > > > (*if_qstart)() or calls it, so all the interfaces with use rwlock(9) in > > > > (*if_qstart)() handler are in risk. > > > > > > > > What

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Martin Pieuchot
On 28/02/24(Wed) 16:39, Vitaliy Makkoveev wrote: > On Wed, Feb 28, 2024 at 02:22:31PM +0100, Mark Kettenis wrote: > > > Date: Wed, 28 Feb 2024 16:16:09 +0300 > > > From: Vitaliy Makkoveev > > > > > > On Wed, Feb 28, 2024 at 12:36:26PM +0100, Claudio Jeker wrote: > > > > On Wed, Feb 28, 2024 at 12

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Claudio Jeker
On Wed, Feb 28, 2024 at 02:37:31PM +0100, Martin Pieuchot wrote: > On 28/02/24(Wed) 12:36, Claudio Jeker wrote: > > On Wed, Feb 28, 2024 at 12:26:43PM +0100, Marko Cupać wrote: > > > Hi, > > > > > > thank you for looking into it, and for the advice. > > > > > > On Wed, 28 Feb 2024 10:13:06 +

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Vitaliy Makkoveev
On Wed, Feb 28, 2024 at 02:22:31PM +0100, Mark Kettenis wrote: > > Date: Wed, 28 Feb 2024 16:16:09 +0300 > > From: Vitaliy Makkoveev > > > > On Wed, Feb 28, 2024 at 12:36:26PM +0100, Claudio Jeker wrote: > > > On Wed, Feb 28, 2024 at 12:26:43PM +0100, Marko Cupać wrote: > > > > Hi, > > > > > > >

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Martin Pieuchot
On 28/02/24(Wed) 12:36, Claudio Jeker wrote: > On Wed, Feb 28, 2024 at 12:26:43PM +0100, Marko Cupać wrote: > > Hi, > > > > thank you for looking into it, and for the advice. > > > > On Wed, 28 Feb 2024 10:13:06 + > > Stuart Henderson wrote: > > > > > Please try to re-type at least the most

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Mark Kettenis
> Date: Wed, 28 Feb 2024 16:16:09 +0300 > From: Vitaliy Makkoveev > > On Wed, Feb 28, 2024 at 12:36:26PM +0100, Claudio Jeker wrote: > > On Wed, Feb 28, 2024 at 12:26:43PM +0100, Marko Cupać wrote: > > > Hi, > > > > > > thank you for looking into it, and for the advice. > > > > > > On Wed, 28 F

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Vitaliy Makkoveev
On Wed, Feb 28, 2024 at 12:36:26PM +0100, Claudio Jeker wrote: > On Wed, Feb 28, 2024 at 12:26:43PM +0100, Marko Cupać wrote: > > Hi, > > > > thank you for looking into it, and for the advice. > > > > On Wed, 28 Feb 2024 10:13:06 + > > Stuart Henderson wrote: > > > > > Please try to re-type

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Claudio Jeker
On Wed, Feb 28, 2024 at 12:26:43PM +0100, Marko Cupać wrote: > Hi, > > thank you for looking into it, and for the advice. > > On Wed, 28 Feb 2024 10:13:06 + > Stuart Henderson wrote: > > > Please try to re-type at least the most important bits from a > > screenshot so readers can quickly se

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Marko Cupać
Hi, thank you for looking into it, and for the advice. On Wed, 28 Feb 2024 10:13:06 + Stuart Henderson wrote: > Please try to re-type at least the most important bits from a > screenshot so readers can quickly see which subsystems are involved. Below is manual transcript of whole screensho

Re: panic: kernel diagnostic assertion "p->p_wchan == NULL" failed

2024-02-28 Thread Stuart Henderson
Please try to re-type at least the most important bits from a screenshot so readers can quickly see which subsystems are involved. splassert: assertwaitok: want 0 have 4 assertion p->wchan == NULL failed, kern_sched.c line 373 active procs: openvpn wg_handshake softnet0 trace includes rw_enter,