Re: lock order reversal in soreceive and NFS

2024-04-30 Thread Alexander Bluhm
On Tue, Apr 30, 2024 at 05:26:15PM +0300, Vitaliy Makkoveev wrote: > On Tue, Apr 30, 2024 at 04:06:29PM +0200, Mark Kettenis wrote: > > > Date: Tue, 30 Apr 2024 16:18:31 +0300 > > > From: Vitaliy Makkoveev > > > > > > On Tue, Apr 30, 2024 at 11:08:13AM +0200, Martin Pieuchot wrote: > > > > > > >

Re: lock order reversal in soreceive and NFS

2024-04-30 Thread Vitaliy Makkoveev
On Tue, Apr 30, 2024 at 04:06:29PM +0200, Mark Kettenis wrote: > > Date: Tue, 30 Apr 2024 16:18:31 +0300 > > From: Vitaliy Makkoveev > > > > On Tue, Apr 30, 2024 at 11:08:13AM +0200, Martin Pieuchot wrote: > > > > > > On the other side, would that make sense to have a NET_LOCK()-free > > > sysct

Re: lock order reversal in soreceive and NFS

2024-04-30 Thread Mark Kettenis
> Date: Tue, 30 Apr 2024 16:18:31 +0300 > From: Vitaliy Makkoveev > > On Tue, Apr 30, 2024 at 11:08:13AM +0200, Martin Pieuchot wrote: > > > > On the other side, would that make sense to have a NET_LOCK()-free > > sysctl path? > > > > To me it's better to remove uvm_vslock() from network relat

Re: lock order reversal in soreceive and NFS

2024-04-30 Thread Vitaliy Makkoveev
On Tue, Apr 30, 2024 at 11:08:13AM +0200, Martin Pieuchot wrote: > > On the other side, would that make sense to have a NET_LOCK()-free > sysctl path? > To me it's better to remove uvm_vslock() from network related sysctl paths. uvm_vslock() used to avoid context switch in the uiomove() call to

Re: lock order reversal in soreceive and NFS

2024-04-30 Thread Vitaliy Makkoveev
On Tue, Apr 30, 2024 at 11:08:13AM +0200, Martin Pieuchot wrote: > > So the issue here is due to NFS entering the network stack after the > VFS. Alexander, Vitaly are we far from a NET_LOCK()-free sosend()? > Is something we should consider? > We are close enough, but I want to unlock raw and U

Re: lock order reversal in soreceive and NFS

2024-04-30 Thread Mark Kettenis
> Date: Tue, 30 Apr 2024 11:08:13 +0200 > From: Martin Pieuchot > > On 27/04/24(Sat) 13:44, Visa Hankala wrote: > > On Tue, Apr 23, 2024 at 02:48:32PM +0200, Martin Pieuchot wrote: > > > [...] > > > I agree. Now I'd be very grateful if someone could dig into WITNESS to > > > figure out why we se

Re: lock order reversal in soreceive and NFS

2024-04-30 Thread Alexander Bluhm
On Tue, Apr 30, 2024 at 11:08:13AM +0200, Martin Pieuchot wrote: > > With the patch, the nfsnode-vmmaplk reversal looks like this: > > So the issue here is due to NFS entering the network stack after the > VFS. Alexander, Vitaly are we far from a NET_LOCK()-free sosend()? > Is something we should

Re: lock order reversal in soreceive and NFS

2024-04-30 Thread Martin Pieuchot
On 27/04/24(Sat) 13:44, Visa Hankala wrote: > On Tue, Apr 23, 2024 at 02:48:32PM +0200, Martin Pieuchot wrote: > > [...] > > I agree. Now I'd be very grateful if someone could dig into WITNESS to > > figure out why we see such reports. Are these false positive or are we > > missing data from the

Re: lock order reversal in soreceive and NFS

2024-04-27 Thread Visa Hankala
On Tue, Apr 23, 2024 at 02:48:32PM +0200, Martin Pieuchot wrote: > On 22/04/24(Mon) 16:18, Mark Kettenis wrote: > > > Date: Mon, 22 Apr 2024 15:39:55 +0200 > > > From: Alexander Bluhm > > > > > > Hi, > > > > > > I see a witness lock order reversal warning with soreceive. It > > > happens during

Re: lock order reversal in soreceive and NFS

2024-04-24 Thread Vitaliy Makkoveev
On Tue, Apr 23, 2024 at 02:48:32PM +0200, Martin Pieuchot wrote: > On 22/04/24(Mon) 16:18, Mark Kettenis wrote: > > > Date: Mon, 22 Apr 2024 15:39:55 +0200 > > > From: Alexander Bluhm > > > > > > Hi, > > > > > > I see a witness lock order reversal warning with soreceive. It > > > happens during

Re: lock order reversal in soreceive and NFS

2024-04-23 Thread Martin Pieuchot
On 22/04/24(Mon) 16:18, Mark Kettenis wrote: > > Date: Mon, 22 Apr 2024 15:39:55 +0200 > > From: Alexander Bluhm > > > > Hi, > > > > I see a witness lock order reversal warning with soreceive. It > > happens during NFS regress tests. In /var/log/messages is more > > context from regress. > >

Re: lock order reversal in soreceive and NFS

2024-04-22 Thread Vitaliy Makkoveev
On Mon, Apr 22, 2024 at 04:18:46PM +0200, Mark Kettenis wrote: > > Date: Mon, 22 Apr 2024 15:39:55 +0200 > > From: Alexander Bluhm > > > > Hi, > > > > I see a witness lock order reversal warning with soreceive. It > > happens during NFS regress tests. In /var/log/messages is more > > context f

Re: lock order reversal in soreceive and NFS

2024-04-22 Thread Mark Kettenis
> Date: Mon, 22 Apr 2024 15:39:55 +0200 > From: Alexander Bluhm > > Hi, > > I see a witness lock order reversal warning with soreceive. It > happens during NFS regress tests. In /var/log/messages is more > context from regress. > > Apr 22 03:18:08 ot29 /bsd: uid 0 on > /mnt/regress-ffs/fstes