Re: syntax error reported in maintain/generate_code_convert_data.pl

2024-10-21 Thread Patrice Dumas
On Mon, Oct 21, 2024 at 03:28:35PM +0100, Gavin Smith wrote: > For shorter files like default_special_unit_info.csv and > default_direction_strings.csv it is less clear that it offers a net > benefit. To be honest, the function of these files is not particularly > clear to me other than one of the

Re: syntax error reported in maintain/generate_code_convert_data.pl

2024-10-21 Thread Gavin Smith
On Sat, Oct 19, 2024 at 03:30:13PM +0200, Patrice Dumas wrote: > On Fri, Oct 18, 2024 at 09:49:00PM +0100, Gavin Smith wrote: > > /opt/csw/bin/perl ./../../maintain/generate_code_convert_data.pl \ > > < ./main/command_data.c \ > > ./../Data/default_css_element_class_styles.csv \

Re: syntax error reported in maintain/generate_code_convert_data.pl

2024-10-19 Thread Patrice Dumas
On Fri, Oct 18, 2024 at 09:49:00PM +0100, Gavin Smith wrote: > /opt/csw/bin/perl ./../../maintain/generate_code_convert_data.pl \ > < ./main/command_data.c \ > ./../Data/default_css_element_class_styles.csv \ > ./../Data/default_direction_strings.csv \ >

Re: syntax error reported in maintain/generate_code_convert_data.pl

2024-10-19 Thread Gavin Smith
On Fri, Oct 18, 2024 at 09:49:01PM +0100, Gavin Smith wrote: > The Solaris CI reports a syntax error: > ... > I guess "continue;" should have been "next;"? I have never looked at > this Perl program before and don't know what it is for. I saw you fixed this. With the other commits for gettext