Re: using size_t for search bindings in info reader bug hidden versus underflow

2024-10-07 Thread Collin Funk
Hi Patrice, Patrice Dumas writes: > I realized that there was a bug because I had set SEARCH_BINDING start > and end offsets to size_t, which lead s.start becoming the max size_t > value (and to a segfault), I had not seen it while reviewing the code > for such possibilities. > > Keeping long co

Re: Flood of commits from July?

2024-10-07 Thread Eli Zaretskii
> Date: Mon, 7 Oct 2024 13:37:52 -0700 > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > From: Per Bothner > > > That was maybe true 10 or 15 years ago, but is no longer true: C++ got > > a lot of additional baggage, standard classes and libraries, and is > > now very different from C. Conve

using size_t for search bindings in info reader bug hidden versus underflow

2024-10-07 Thread Patrice Dumas
Hello, In the info reader, as part of an effort to avoid comparison of signed and unsigned integers, and also to have a clearer code, I am considering setting SEARCH_BINDING start and end offsets to size_t instead of long. Indeed, this should be a bug if they are negative (although there were plac

Re: Flood of commits from July?

2024-10-07 Thread Per Bothner
On 10/7/24 12:00 PM, Eli Zaretskii wrote: From: Per Bothner First, compared to C++ to Rust, moving from C to C++ is much more modest of terms of code changes as well as new skills needed. That was maybe true 10 or 15 years ago, but is no longer true: C++ got a lot of additional baggage, st

Re: Flood of commits from July?

2024-10-07 Thread Eli Zaretskii
> Date: Mon, 7 Oct 2024 09:24:34 -0700 > From: Per Bothner > > > > On 10/6/24 11:18 AM, Gavin Smith wrote: > > Now imagine that half of DomTerm gets rewritten in Rust and then you > > are scratching your head looking at a bunch of Rust code that you barely > > understand when trying to fix prob

Re: Flood of commits from July?

2024-10-07 Thread Per Bothner
On 10/6/24 11:18 AM, Gavin Smith wrote: Now imagine that half of DomTerm gets rewritten in Rust and then you are scratching your head looking at a bunch of Rust code that you barely understand when trying to fix problems in DomTerm. That's the situation you are promoting for Texinfo. First,