[Bug-tar] paxutils: rmt.c missing va_end()

2018-07-30 Thread Pavel Raiskup
Hi, please consider fixing rmt_write function: rmt_write (const char *fmt, ...) { va_list ap; va_start (ap, fmt); vfprintf (stdout, fmt, ap); // missing va_end fflush (stdout); VDEBUG (10, "S: ", fmt, ap); // potential re-use of 'ap' (requires new va_start) } th

[Bug-tar] [PATCH] avoid some resource leaks

2018-07-30 Thread Pavel Raiskup
* src/incremen.c (store_rename): Free temp_name, leaked before for each renamed directory with --listed-incremental. * src/transform.c (add_literal_segment): Tighten arguments by const. (parse_transform_expr): Free 'str', leaked storage for each --transform option before. * src/utf8.c (utf8_convert

Re: [Bug-tar] paxutils: rmt.c missing va_end()

2018-07-30 Thread Joerg Schilling
Pavel Raiskup wrote: > Hi, > > please consider fixing rmt_write function: > > rmt_write (const char *fmt, ...) > { > va_list ap; > va_start (ap, fmt); > vfprintf (stdout, fmt, ap); > // missing va_end > fflush (stdout); > VDEBUG (10, "S: ", fmt, ap); > // potential

[Bug-tar] restoring --selinux archive from non-MLS to MLS enabled system fails

2018-07-30 Thread Chris Hecker
Hi, I made some tar archives with --selinux on centos5, which does not seem to have MLS enabled, so files have no selinux range (the :s0 part at the end) in the security context.  Trying to restore these archives on centos7, which does have MLS enabled, errors: tar-1.30: setfileconat: Cannot set

[Bug-tar] Please fix the build with gcc 8.1

2018-07-30 Thread Pavel Raiskup
With current gnulib submodule hash - build system throws: CC stdopen.o cc1: error: -Wabi won't warn about anything [-Werror=abi] cc1: error: -Wabi won't warn about anything [-Werror=abi] cc1: note: -Wabi warns about differences from the most up-to-date ABI,

Re: [Bug-tar] [PATCH] tests: fix race in dirrem01 and dirrem02

2018-07-30 Thread Pavel Raiskup
On Tuesday, March 13, 2018 9:42:41 PM CEST Pavel Raiskup wrote: > ping, still valid issue ping > On Thursday, January 4, 2018 7:17:31 PM CET Pavel Raiskup wrote: > > Previously the '--checkpoint-action=echo' was triggered after > > '--checkpoint-action=sleep=1' - so the order of events *usually*

[Bug-tar] --exclude-vcs-ignores does not read .gitignore files from parent directories

2018-07-30 Thread Michal Novotny
Hello, if I invoke tar --exclude-vcs-ignores on a subdirectory of a Git repository, the files that should be ignored per .gitignore file placed in a top-level repo directory, are not ignored. It would be nice if tar could operate the same way git archive operates in this respect. Can I at least m

Re: [Bug-tar] --exclude-vcs-ignores does not read .gitignore files from parent directories

2018-07-30 Thread Pavel Raiskup
On Monday, July 30, 2018 3:04:06 PM CEST Michal Novotny wrote: > Can I at least make tar (by passing some additional arguments) take the > parent .gitignores into consideration? I don't like that idea; IMO GNU tar should rely on /bin/git to interpret gitignore ('git check-ignore'). > Is there a s

Re: [Bug-tar] --exclude-vcs-ignores does not read .gitignore files from parent directories

2018-07-30 Thread Michal Novotny
n Mon, Jul 30, 2018 at 4:30 PM Pavel Raiskup wrote: > On Monday, July 30, 2018 3:04:06 PM CEST Michal Novotny wrote: > > Can I at least make tar (by passing some additional arguments) take the > > parent .gitignores into consideration? > > I don't like that idea; IMO GNU tar should rely on /bin/g

[Bug-tar] Multi-threaded tar

2018-07-30 Thread J.R. Heisey
Greetings, I was trying to make some processes faster which use tar a bit on large archives. I was able to use the command line options --use-compress-program pbzip2 and that helped a lot. I was wondering if anyone has experimented using pthreads in the tar implementation. I don't see any refere