Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes

2018-01-23 Thread Mark H Weaver
Hi Andreas, Andreas Dilger writes: > On Jan 20, 2018, at 5:06 PM, Mark H Weaver wrote: >> Yes, on Btrfs I reliably see (st_blocks == 0) on a recently written, >> mostly sparse file with size > 8G, using linux-libre-4.14.14. More >> specifically, the "storing sparse files > 8G" test in tar's te

Re: [Bug-tar] Detection of sparse files is broken on btrfs

2018-01-23 Thread Joerg Schilling
Andreas Dilger wrote: > Maybe you wrote a filesystem 30 years ago when everything was BSD FFS, but > things have moved on from that time. I'm one of the maintainers for ext4, Things changed since then because people followed my filesystem design from 30 years ago. Jörg -- EMail:jo...@schi

Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes

2018-01-23 Thread Joerg Schilling
Mark H Weaver wrote: > > Now many bytes have been written past the hole? > > Did you read my entire message? The answer to your question was just a > few lines beyond the excerpt that you quoted above. I wrote: > > >> Yes, on Btrfs I reliably see (st_blocks == 0) on a recently written, > >> mos

Re: [Bug-tar] Detection of sparse files is broken on btrfs

2018-01-23 Thread Joerg Schilling
Sorry for the resend mail, but it turned out that accidently typed "r" instead of "R" and I belive this may be of interes for more than just you Paul. Paul Eggert wrote: > On 01/22/2018 09:47 AM, Joerg Schilling wrote: > > we are talking about files that do not change while something like TAR >

Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes

2018-01-23 Thread Mark H Weaver
Joerg Schilling writes: > Mark H Weaver wrote: > >> > Now many bytes have been written past the hole? >> >> Did you read my entire message? The answer to your question was just a >> few lines beyond the excerpt that you quoted above. I wrote: >> >> >> Yes, on Btrfs I reliably see (st_blocks ==

Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes

2018-01-23 Thread Andreas Dilger
On Jan 23, 2018, at 1:44 AM, Mark H Weaver wrote: > Andreas Dilger writes: > >> On Jan 20, 2018, at 5:06 PM, Mark H Weaver wrote: >>> Yes, on Btrfs I reliably see (st_blocks == 0) on a recently written, >>> mostly sparse file with size > 8G, using linux-libre-4.14.14. More >>> specifically, th

Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes

2018-01-23 Thread Andreas Dilger
On Jan 23, 2018, at 2:49 PM, Mark H Weaver wrote: > > Joerg Schilling writes: > >> Mark H Weaver wrote: >> Now many bytes have been written past the hole? >>> >>> Did you read my entire message? The answer to your question was just a >>> few lines beyond the excerpt that you quoted abo

Re: [Bug-tar] [PATCH] Remove nonportable check for files containing only zeroes

2018-01-23 Thread Mark H Weaver
Hi Andreas, Andreas Dilger writes: > On Jan 23, 2018, at 1:44 AM, Mark H Weaver wrote: >> Andreas Dilger writes: >> >>> On Jan 20, 2018, at 5:06 PM, Mark H Weaver wrote: Yes, on Btrfs I reliably see (st_blocks == 0) on a recently written, mostly sparse file with size > 8G, using li