Re: tar-1.33/src/buffer.c:1733:redundantAssignment

2021-01-08 Thread David Binderman
Hello there,   >> tar-1.33/src/buffer.c:1733:25: style: Variable 'st.orig_file_name' is >> reassigned a value before the old one >has been used. [redundantAssignment] >As a matter of fact, its value *is* used before reasignment.  By >xheader_format_name. Agreed. The static analyser tool cppchec

Re: tar-1.33/src/buffer.c:1733:redundantAssignment

2021-01-08 Thread Sergey Poznyakoff
David Binderman ha escrit: > tar-1.33/src/buffer.c:1733:25: style: Variable 'st.orig_file_name' is > reassigned a value before the old one has been used. [redundantAssignment] As a matter of fact, its value *is* used before reasignment. By xheader_format_name. Regards, Sergey

tar-1.33/src/buffer.c:1733:redundantAssignment

2021-01-08 Thread David Binderman
Hello there, tar-1.33/src/buffer.c:1733:25: style: Variable 'st.orig_file_name' is reassigned a value before the old one has been used. [redundantAssignment] Source code is memset (&st, 0, sizeof st); st.orig_file_name = st.file_name = map->file_name; st.stat.st_mode = S_IFREG