Re: [PATCH] fix GCC 8 compile error

2021-09-18 Thread Christian Schoenebeck
On Samstag, 18. September 2021 18:45:37 CEST Paul Eggert wrote: > On 9/18/21 9:26 AM, Christian Schoenebeck wrote: > > apparently this compile error will retain in > > the next release tarball. > > It shouldn't do that. Have you tried building a tarball with 'make dist' > and built from that with

Re: [PATCH] fix GCC 8 compile error

2021-09-18 Thread Paul Eggert
On 9/18/21 9:26 AM, Christian Schoenebeck wrote: apparently this compile error will retain in the next release tarball. It shouldn't do that. Have you tried building a tarball with 'make dist' and built from that with 'configure; make'? If that fails to build on your older platform, please r

Re: [PATCH] fix GCC 8 compile error

2021-09-18 Thread Christian Schoenebeck
On Samstag, 18. September 2021 17:29:15 CEST Paul Eggert wrote: > On 9/18/21 4:18 AM, Christian Schoenebeck wrote: > > this patch is just needed if you care that tar does no longer compile on > > a substantial amount of systems out there. > > Tar releases should compile just fine on these systems,

Re: [PATCH] fix GCC 8 compile error

2021-09-18 Thread Paul Eggert
On 9/18/21 4:18 AM, Christian Schoenebeck wrote: this patch is just needed if you care that tar does no longer compile on a substantial amount of systems out there. Tar releases should compile just fine on these systems, so the patch is not needed for them. You're building from Git not from

Re: [PATCH] fix GCC 8 compile error

2021-09-18 Thread Christian Schoenebeck
On Samstag, 18. September 2021 00:30:01 CEST Paul Eggert wrote: > On 9/17/21 9:33 AM, Christian Schoenebeck wrote: > > attached patch fixes a compile error with GCC 8, whining about missing > > malloc function attribute. > > As I understand it, this patch is not needed for recent GCC, which is sma

Re: [PATCH] fix GCC 8 compile error

2021-09-17 Thread Paul Eggert
On 9/17/21 9:33 AM, Christian Schoenebeck wrote: attached patch fixes a compile error with GCC 8, whining about missing malloc function attribute. As I understand it, this patch is not needed for recent GCC, which is smart enough to not require programmers to specify attributes that GCC can ea

[PATCH] fix GCC 8 compile error

2021-09-17 Thread Christian Schoenebeck
TCH] Fix GCC 8 compile error in wordsplit Fixes: 8378991c --- lib/wordsplit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/wordsplit.c b/lib/wordsplit.c index cf8a499..0e1cf1e 100644 --- a/lib/wordsplit.c +++ b/lib/wordsplit.c @@ -107,6 +107,9 @@ static int wordsplit_run (const c