Re: [PATCH] Don't pre-create read-only files with --extract --xattrs

2023-06-06 Thread Sergey Poznyakoff
Applied (commit e7987b72). Thank you. Regards, Sergey

Re: [PATCH] Don't pre-create read-only files with --extract --xattrs

2023-05-18 Thread Pavel Raiskup
Thank you for the fix in 35d9845d5d41023 and 0b74885e81b90d6ab4. The patches simplify the code a lot. I just think two in-code doc fixes are worth it, patch attached. Per https://github.com/praiskup/tar/pull/2 Pavel On středa 24. listopadu 2021 15:56:05 CEST Pavel Raiskup wrote: > Gently pingi

Re: [PATCH] Don't pre-create read-only files with --extract --xattrs

2021-11-24 Thread Pavel Raiskup
le > > > was > > > + meant to be user-read-only, the permissions will be > > > corrected by > > > + the set_stat call. */ > > > + mode_t initial_mode = mode ^ invert_permissions | S_IWUSR; > > > + > > > + if (!mkno

Re: [PATCH] Don't pre-create read-only files with --extract --xattrs

2021-02-15 Thread Pavel Raiskup
Ping, I can see there's 1.34 release now, thank you! But the git isn't updated yet so I'm not sure this has been fixed or not. Pavel On Tuesday, February 9, 2021 5:06:31 PM CET Pavel Raiskup wrote: > Gently ping on this. This is easily reproducible, so I am re-attaching > the patch including a

Re: [PATCH] Don't pre-create read-only files with --extract --xattrs

2021-02-09 Thread Pavel Raiskup
if (!mknodat (chdir_fd, file_name, initial_mode, 0)) > { >/* Successfully created file */ >xattrs_xattrs_set (st, file_name, typeflag, 0); > >From 42201a0ce560846f770cd5305d04287b13e4bd2b Mon Sep 17 00:00:00 2001 From: Pavel Raiskup Date: Fri, 9 Oct 2020 12:03:22

[PATCH] Don't pre-create read-only files with --extract --xattrs

2020-10-09 Thread Pavel Raiskup
We used to respect the target file mode when pre-creating files in set_xattr, so we also pre-created read-only files that we were not able to open later for writing. This is now fixed, and we always create the file with S_IWUSR. Fixes the original bug report https://bugzilla.redhat.com/1886540 *