Re: [Bug-tar] [PATCH] ZSTD compression support.

2018-12-27 Thread Dmitry V. Levin
Hi, On Wed, Nov 15, 2017 at 10:02:12PM +0100, Adam Borowski wrote: > Its customary file extension is ".zst", while some tools use ".tzst" as a > shorthand for ".tar.zst". [...] > diff --git a/doc/tar.1 b/doc/tar.1 > index f5c1fca..b140446 100644 > --- a/doc/tar.1 > +++ b/doc/tar.1 > @@ -828,6 +828

Re: [Bug-tar] [PATCH] ZSTD compression support.

2018-03-18 Thread Sergey Poznyakoff
Hi Adam, I have pushed the ZSTD patch to git HEAD. Thanks a lot for your help. Regards, Sergey

Re: [Bug-tar] [PATCH] ZSTD compression support.

2018-01-04 Thread Nick Terrell
> On Nov 15, 2017, at 1:02 PM, Adam Borowski wrote: > > Its customary file extension is ".zst", while some tools use ".tzst" as a > shorthand for ".tar.zst". > --- > Not sure what/if a short option would be appropriate. > > configure.ac | 1 + > doc/tar.1| 4 > doc/tar.texi | 12 ++

Re: [Bug-tar] [PATCH] ZSTD compression support.

2017-11-28 Thread Ralph Corderoy
Hi Adam, > Shawn wrote: > > + ct_xz, > > + ct_zstd > > > > there should be a comma after ct_zstd. compilers can accept this > > now. > > Yeah, that's much nicer for diffs. I wanted to follow the old code, > but you're right here. Only if you assume GNU tar doesn't intend to be compiled by old

Re: [Bug-tar] [PATCH] ZSTD compression support.

2017-11-27 Thread Adam Borowski
On Mon, Nov 27, 2017 at 09:28:07AM -0800, Shawn Landden wrote: > + ct_xz, > + ct_zstd > > there should be a comma after ct_zstd. compilers can accept this now. Yeah, that's much nicer for diffs. I wanted to follow the old code, but you're right here. > You are missing concatenation -A support

Re: [Bug-tar] [PATCH] ZSTD compression support.

2017-11-27 Thread Shawn Landden
+ ct_xz, + ct_zstd there should be a comma after ct_zstd. compilers can accept this now. You are missing concatenation -A support. Zstd has special compatibility with concatenation (read the man page) and as such you should change the tar man

Re: [Bug-tar] [PATCH] ZSTD compression support.

2017-11-27 Thread Shawn Landden
+ ct_xz, + ct_zstd there should be a comma after ct_zstd. compilers can accept this now. You are missing concatenation -A support. Zstd has special compatibility with concatenation (read the man page) and as such you should change the tar man page to document that -A works with zstd, and mak

Re: [Bug-tar] [PATCH] ZSTD compression support.

2017-11-16 Thread Nick Terrell
On 11/15/17, 1:03 PM, "Adam Borowski" wrote: > Its customary file extension is ".zst", while some tools use ".tzst" as a > shorthand for ".tar.zst". I've tested your patch with this script. I think I've covered most of the surface area, but I'm sure there are some niche features that this doesn't

Re: [Bug-tar] [PATCH] ZSTD compression support.

2017-11-15 Thread Adam Borowski
On Wed, Nov 15, 2017 at 10:27:07PM +, Ralph Corderoy wrote: > > Its customary file extension is ".zst", while some tools use ".tzst" > > as a shorthand for ".tar.zst". > > This shortening should die, just like DOS 8.3 filenames. > > If it's .tar.foo then eyeballs and scripts stand a chance of

Re: [Bug-tar] [PATCH] ZSTD compression support.

2017-11-15 Thread Ralph Corderoy
Hi, > Its customary file extension is ".zst", while some tools use ".tzst" > as a shorthand for ".tar.zst". This shortening should die, just like DOS 8.3 filenames. If it's .tar.foo then eyeballs and scripts stand a chance of realising it's a tar file that's had another transformation applied, a

[Bug-tar] [PATCH] ZSTD compression support.

2017-11-15 Thread Adam Borowski
Its customary file extension is ".zst", while some tools use ".tzst" as a shorthand for ".tar.zst". --- Not sure what/if a short option would be appropriate. configure.ac | 1 + doc/tar.1| 4 doc/tar.texi | 12 ++-- src/buffer.c | 5 - src/suffix.c | 2 ++ src/tar.c|