Bug in gpt_probe()

2011-07-31 Thread rahul dev
Guys, Looks like there is a bug in gpt_probe(). In case it reads the primary header successfully but doesn't find a gpt signature, it returns 0 and doesn't check for the secondary gpt table. This seems to be a serious bug. Can anyone take a look ? thanks, rahul

Re: Bug in gpt_probe()

2011-08-01 Thread rahul dev
wrote: > From: Brian C. Lane > Subject: Re: Bug in gpt_probe() > To: "rahul dev" > Cc: bug-parted@gnu.org > Date: Monday, 1 August, 2011, 10:29 PM > On Mon, Aug 01, 2011 at 10:00:58AM > +0530, rahul dev wrote: > > Guys, > > > >   Looks like ther

Bug in ped_disk_new(). needs_clobber should be set to 1 before reading partition table.

2011-08-03 Thread rahul dev
Guys, I am using libparted version 1.8.8. Yes, this is an old version but I cannot upgrade to higher versions at present. There seems to be a bug in function ped_disk_new(). ped_disk_new() calls ped_disk_new_fresh() that sets needs_clobbber = 1. Then it calls, type->ops->read(disk). I

ped_disk_new(). why needs_clobber is set while reading the partition table ?

2011-08-04 Thread rahul dev
Guys, I had a look at the latest version of libparted. Here also in function ped_disk_new(), disk->needs_clobber is set to 0 after type->ops->read(disk). Why do we want to keep need_clobber set to 1 while reading the partition table ? I think needs_clobber should be set to 0 before partition

Does libparted suport Hybrid MBR

2011-09-05 Thread rahul dev
Guys, Just want to know if there is support for hybrid MBR in libparted ? How would libparted interpret a hybrid MBR partition table ? thanks, rahul ___ bug-parted mailing list bug-parted@gnu.org https://lists.gnu.org/mailman/listinfo/bug-parted

Re: Does libparted suport Hybrid MBR

2011-09-06 Thread rahul dev
Ok. Thanks Petr. So, that means parted gives preference to gpt over mbr on a hybrid mbr table ? thanks, rahul --- On Tue, 6/9/11, Petr Uzel wrote: > From: Petr Uzel > Subject: Re: Does libparted suport Hybrid MBR > To: "rahul dev" > Cc: bug-parted@gnu.org > Date: T

Re: Bug in gpt_probe()

2011-09-11 Thread rahul dev
Any thoughts on this ? Did anyone get a chance to look at this ? thanks, rahul --- On Mon, 1/8/11, rahul dev wrote: > From: rahul dev > Subject: Re: Bug in gpt_probe() > To: "Brian C. Lane" > Cc: bug-parted@gnu.org > Date: Monday, 1 August, 2011, 11:30 PM > Yeah

Re: Assertion ((PedSector) PED_LE64_TO_CPU

2011-09-27 Thread rahul dev
Hi,      I also saw this failure. This may happen if a disk size has been reduced. In the current code, parted doesn't take care of "disk shrunk" case.   If the disk size has been reduced the backup table will be lost. But, if there is sufficient space at the end of disk beyond the last partition,

Re: Assertion ((PedSector) PED_LE64_TO_CPU

2011-10-10 Thread rahul dev
Hi Brian,               >               > > You found a bug in GNU Parted.  Please email a > bug report to > > bug-parted@gnu.org > containing the version (1.6.19), and the following > > message: > > > > Assertion ((PedSector) PED_LE64_TO_CPU > (gpt.AlternateLBA) <= > > disk->dev->length - 1) at

Re: bug partedUtil in ESXi 5.0

2012-07-12 Thread rahul dev
> +, Memenza, David wrote: > > /dev/disks # partedUtil fix > vml.02200087097ae1583233355f48 > > Warning: Device /dev/disks/naa.200087097ae1 has a > logical sector size of 520.  Not all parts of GNU > Parted support this at the > > moment, and the working code is HIGHLY EXPERIMEN

Minimum size of GPT partition table header

2012-09-19 Thread rahul dev
Guys, There seems to be a bug in function _header_is_valid() in file gpt.c. static int _header_is_valid (PedDisk const *disk, GuidPartitionTableHeader_t *gpt, PedSector my_lba) { uint32_t crc, origcrc; PedDevice const *dev = disk->dev; if (PED_LE64_TO_CPU (gpt->Signatu

Re: Minimum size of GPT partition table header

2012-09-21 Thread rahul dev
Hi Jim, > >    There seems to be a bug in function > _header_is_valid() in file gpt.c. > > > > static int > > _header_is_valid (PedDisk const *disk, > GuidPartitionTableHeader_t *gpt, > >                >    PedSector my_lba) > > { > >   uint32_t crc, origcrc; > >   PedDevice const *dev = disk->de

Re: Minimum size of GPT partition table header

2012-09-22 Thread rahul dev
Hi Jim, > > > >    There seems to be a bug in function > _header_is_valid() in file gpt.c. > > > > static int > > _header_is_valid (PedDisk const *disk, > GuidPartitionTableHeader_t *gpt, > >                >    PedSector my_lba) > > { > >   uint32_t crc, origcrc; > >   PedDevice const *dev = disk

Re: Minimum size of GPT partition table header

2012-09-22 Thread rahul dev
> > >>> There seems to be a bug in function > _header_is_valid() in file > >>> gpt.c. > ... > >>> The check gpt->HeaderSize<  > pth_get_size_static seems to be > >>> incorrect. I think minimum size of gpt header > is 92 bytes. So, > >>> correct check should be > gtp->HeaderSize<  92. > ... > >> Ha

Re: Minimum size of GPT partition table header

2012-09-23 Thread rahul dev
> ... > >> Has this code caused an actual problem for you? > > > > One more question here. > > Should we allow read of gpt table in case the header > size > 92 ? This > > is because if the header size has been increased, the > header revision > > should also be increased. So, we should fail reading