Re: [parted-devel] [PATCH] Fall back to not using O_DIRECT

2008-08-06 Thread Olaf Hering
On Tue, Aug 05, Soren Hansen wrote: > +#if defined(O_DIRECT) It is safe to drop the entire thing. ifarch like that, in generic code, asks for trouble. --- libparted/arch/linux.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) --- a/libparted/arch/linux.c +++ b/libparted/arch/l

Re: [parted-devel] [PATCH] Fall back to not using O_DIRECT

2008-08-06 Thread Olaf Hering
On Wed, Aug 06, Jim Meyering wrote: > I agree wholeheartedly that arch-specific #ifdefs are best > avoided, but am a little leery of removing O_DIRECT altogether. > However, I'm currently leaning towards accepting this. > Has this change been tested much? Its a result of this bug, the patch is us

Re: [parted-devel] [PATCH] Fall back to not using O_DIRECT

2008-08-06 Thread Olaf Hering
On Wed, Aug 06, Jim Meyering wrote: > Olaf Hering <[EMAIL PROTECTED]> wrote: > > > On Wed, Aug 06, Jim Meyering wrote: > > > >> I agree wholeheartedly that arch-specific #ifdefs are best > >> avoided, but am a little leery of removing O_DIRECT altog