Remove unused _device_get_partition_range function
* libparted/arch/linux.c (_device_get_partition_range): Remove unused function
* libparted/arch/linux.c (_disk_sync_part_table): Set lpn=256 for blkext majors
---
libparted/arch/linux.c | 37 -
1 files change
---
libparted/arch/linux.c | 23 ++-
1 files changed, 2 insertions(+), 21 deletions(-)
diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
index 38f4e31..435cb46 100644
--- a/libparted/arch/linux.c
+++ b/libparted/arch/linux.c
@@ -2776,19 +2776,6 @@ _dm_reread_part_
it s print" cmd triggers
> the crash again.
> Försäkran (head_size <= 63) på ../../../libparted/labels/dos.c:659 i
> funktionen
> probe_partition_for_geom() misslyckades.
What does fdisk -l /dev/xxx show for the CHS of the device? Looks to me
like another case of something repor
NOTE: This applies cleanly to parted-2.1 and parted-2.3
To better support 4k sector drives this changes the
linux_get_optimum_alignment() function to prefer aligning partitions to
DEFAULT_ALIGNMENT (1048576) if possible.
This also modifies the alignment test to take this change into account.
---
On Wed, Dec 15, 2010 at 11:10:46AM +0100, Jim Meyering wrote:
Thanks for the changes, I especially like the operators aligned at the
start.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgplNuVeZVnnf.pgp
Description: PGP signature
From: Peter Jones
On mac partition tables which specify a sector size larger than the
physical sector size, we need to reallocate the buffer after we
determine the correct sector size.
This is a normal condition when CD is used with Apple partitions (for
example, the USB rescue stick for the Mac
ce Boot Start End Blocks Id System
> /dev/sdg1 8064 7827455 3909696 c W95 FAT32 (LBA)
>
re-formatting the device will solve this. The problem is that you cannot
have > 63 heads, but some flash drives appear to have factory formats
that break this rule.
--
Brian C. Lane | Anaconda Team | IRC
yet another example of a flash drive with the wrong formatting
from the factory.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpENb7N1icLT.pgp
Description: PGP signature
___
bug-parted mailing list
bug-parte
Add support for the Legacy BIOS Bootable flag in the GPT
Attribute field. This is used by software like syslinux to
determine which partition to boot when in BIOS mode.
See Page 105, Table 19 Bit 2 of the UEFI Spec 2.3 book.
* doc/C/parted.8: document legacy_boot
* doc/parted.texi: document legac
Add NoBlockIOProtocol and LegacyBIOSBootable flags to the GPT partition
Attributes entry.
---
libparted/labels/gpt.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/libparted/labels/gpt.c b/libparted/labels/gpt.c
index b9ed5c3..0396ad7 100644
--- a/libparted/labels/
The CHS geometry values are calculated based on the existing partition
information. The values can't always be calculated, and the partition
may be corrupt so instead of throwing an assertion just return 0 and
carry on.
I left the logic for the PED_ASSERT checks the same so that it is clear
that t
The first one of these applies cleanly to the fedora master branch
of parted and passes all the tests. The second will only apply to the
current upstream master.
Brian C. Lane (2):
Remove PED_ASSERT from dos geometry checking
Remove PED_ASSERT action argument
debug/clearfat/clearfat.c
heads. 10 sectors/track seems like a reasonable number.
parted and fdisk guess at the CHS values differently. You can't compare
the 2. The assertion was because parted's guess was outside the allowed
values.
Thanks for your help,
Brian
--
Brian C. Lane | Anaconda Team | IRC: bcl #a
. It may also be helpful in solving (or providing a
work-around) to rhbz#623268 where it sometimes snaps to the wrong place.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpTeybKz2n6q.pgp
Description: PGP signature
___
The static buffer for the error string is too small. Double it.
Resolves: rhbz#693852
---
libparted/labels/fdasd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libparted/labels/fdasd.c b/libparted/labels/fdasd.c
index 6d708f6..e235dd3 100644
--- a/libparted/labels/fda
ath_len && !strcmp (dev->path + path_len - 5, "/disc")) {
> /* replace /disc with /path%d */
Small typo in the comment, should read /part%d
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pg
.so.6
> libhistory.so libhistory.so.6.2 libreadline.so libreadline.so.6.2
You probably needed to install readline-devel (at least that's the name
of the package in Fedora). Also you might see that if your system isn't
setup to use /usr/local/lib for libraries.
--
Brian C.
emoved in parted 2.4. You can work around this problem by erasing
the partitioning on the USB device and re-partitioning it. Or unplugging
it ;)
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgp0NdMaLX5Ox.pgp
Description: PGP signature
__
When a value < 1 is used there is the possibility that the range can
overlap sector 0. The user should use smaller units instead. 0 is a
special case and is still allowed.
* libparted/unit.c (ped_unit_parse_custom): Throw error if a value
between 0 and 1 is used.
---
libparted/unit.c |6 +++
* tests/t9022-one-unit-snap.sh: New file
* tests/Makefile.am: Add new test
---
tests/Makefile.am|1 +
tests/t9022-one-unit-snap.sh | 42 ++
2 files changed, 43 insertions(+), 0 deletions(-)
create mode 100644 tests/t9022-one-unit-snap.sh
The snap radius didn't match the documentation, it has been using +/-
unit size instead +/- 0.5 * unit (eg. 500KB for a MB unit). This caused
problems when specifying 1MB, 1GB, etc. as a partition start or end
resulting in partitions being created that were nowhere near the
specified size.
* libpa
* tests/t9023-value-lt-one.sh: New file
* tests/Makefile.am: Add new test
---
tests/Makefile.am |1 +
tests/t9023-value-lt-one.sh | 32
2 files changed, 33 insertions(+), 0 deletions(-)
create mode 100644 tests/t9023-value-lt-one.sh
diff --git a/t
count=1
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpkE5N82tLsT.pgp
Description: PGP signature
___
bug-parted mailing list
bug-parted@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-parted
format a Linux partition in Windows.
This seems like a good idea. But I worry about tools and other OS's that
expect the current behavior. And as Jim pointed out we don't always
have a Linux filesystem on partitions we create.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | P
grams that might assume the Microsoft Basic Data partition type
> code on Linux partitions by giving the option of setting that type
> code on Linux partitions. What this patch does is:
This looks good to me. I like the addition of the new flag.
--
Brian C. Lane | Anaconda Team | IRC: bcl
syntax for locations.
>
> if in interactive mode, the above command works. but i need to
> script it. so is it a bug or it's work-aroundable?
Pass -- after you are done with command line arguments so that it will
ignore anything else that looks like a - or -- arg. Like this:
parte
round it by removing the old partitioning on the drive and
re-creating it with parted. dd if=/dev/zop of=/dev/device bs=1M count=1
should do the trick (note, this will destroy whatever you have on it so
make sure you have a backup).
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port
> This seems to be a serious bug. Can anyone take a look ?
Can you describe a reliable way to reproduce it? Preferably using a
disk image file as a test.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpH8Fwu73wwV
lesystem code has been removed completely as of v3.0 so yes, that
is true.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpOg9sSteiPo.pgp
Description: PGP signature
___
bug-parted mailing list
bug-parted@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-parted
From: "Brian C. Lane"
* libparted/fs/hfs/probe.c (hfsplus_probe): Add a check on the
search value and reject it if it is negative.
(hfsx_probe): Same
(hfs_and_wrapper_probe): Same
---
libparted/fs/hfs/probe.c | 18 +++---
1 files changed, 11 insertions(+), 7
From: "Brian C. Lane"
pc98 is not a common disk label. Change pc98_probe to only return true
if one of the recognized signatures is present.
Currently these include:
IPL1
Linux 98
GRUB/98
This will prevent false-positive detection on msdos labeled disks
* libparted/labels/pc98.c (
From: "Brian C. Lane"
* tests/t2201-pc98-label-recog.sh: New file
* tests/Makefile.am: Add test
---
tests/Makefile.am |1 +
tests/t2201-pc98-label-recog.sh | 41 +++
2 files changed, 42 insertions(+), 0 deletions(-)
create m
On Thu, Oct 06, 2011 at 11:44:56AM +0200, ak...@volny.cz wrote:
> Sory for misunderstending, it was partprobe.
>
Is that the full output? There should also be a block of text with the
actual assert message included in it.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orcha
containing at least the version
> (2.3) and the following message: Assertion (cyl_size <= 255 * 63) at
> dos.c:649 in function probe_partition_for_geom() failed.
> Aborted
This was fixed in parted 2.4, you can work around it by wiping your disk
and re-creating the partitions (warnin
t;
> Assertion ((PedSector) PED_LE64_TO_CPU (gpt.AlternateLBA) <=
> disk->dev->length - 1) at disk_gpt.c:621 in function gpt_read() failed.
>
v1.6.19 is a *really* old version of parted. Can you reproduce this with
something newer?
--
Brian C. Lane | Anaconda Team | IRC: bcl #ana
.
> Finally, please always configure with
>
> ./configure --enable-gcc-warnings
>
> That would have highlighted some unused variables and the unused function.
Sorry about that, I build it using the fedora build scripts and missed
that one. Enclosed is an updated patch
#x27;t think we have any way to construct a valid
HFS filesystem to run the test against.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpCs5N9qnl7K.pgp
Description: PGP signature
___
bug-parted mailing list
bug-parte
hybrid EFI/BIOS bootable USB sticks.
I was also just wondering if we (Fedora) should be setting legacy_boot
on /boot partitions instead of the boot flag, since the latter writes an EFI
system GUID to the partition type.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anacond
v2.4
Typically you can work around this by re-partitioning the device using
parted (usually this happens on factory supplied USB sticks).
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpXqcy0jdou5.pgp
Description: PGP signature
de FS-manipulation code and
> parted, the command-line tool, will not perform FS manipulation.
Whew! Had me scared there for a minute :)
>
> This new library will be usable by external applications
> to resize HFS and FAT partitions.
>
That's the right way to do things. resizi
On Sat, Dec 24, 2011 at 10:07:08AM -0700, Curtis Gedak wrote:
> Hi Takis,
>
> This problem was fixed in parted 2.4 and higher. Please try a newer
> version of parted.
If you can't use a newer parted version you can work around it by
re-partitioning the USB device with part
tion_range was
added. It reads from '/sys/module/loop/parameters/max_part' which on my
F15 system (kernel 2.6.41.4-1.fc15.x86_64) returns 0.
Partitioned loop devices certainly do work, so I think this is an error.
I also am not sure what will happen with systems where loop is not a
mo
/ideapad/mbr16GB.img (md5:
> 0b236b16e98de53393f6539c40ba1201).
One way to work around this is to make a sparse disk image and then drop
your partition table onto the start of it, something like this:
dd if=/dev/null of=disk.img bs=1M seek=16K
dd if=mbr16GB.img of=disk.img seek=0 conv=nocreat
the libparted api? Thank you.
>
Well, there is already the pyparted project.
http://git.fedorahosted.org/git/?p=pyparted.git
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgp6dYRGl9CyB.pgp
Description: PGP signature
owing
> message: Assertion (head_size <= 63) at dos.c:661 in function
> probe_partition_for_geom() failed.
This is fixed in parted v2.4, or you can fix it by re-partitioning the
device using parted. Usually this is an issue with factory USB sticks
that have not been re-partitioned.
--
Bria
0) at arch/linux.c:628 in function _device_get_length() failed.
Thanks for the report, but parted 1.8.1 is ancient. If you can, try
using the 3.x release.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgp1lGuOdDeYG.pgp
Description: PGP signature
lease reboot.
That version of parted is extremely old. I'd suggest upgrading to v3.1
if possible.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpEhZ5ypxHz3.pgp
Description: PGP signature
ation. parted now supports this via the
pmbr_boot flag. You are thinking of the boot flag which changes the GUID
for the partition to the EFI System Partition type.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpSMQlGYLiOM.pgp
Description: PGP signature
come a patch", but I just
> wanted to know whether anybody else is interested in or maybe working
> on this subject.
Not that I am aware of, but we will gladly review patches ;) If you do
submit them please also include test cases for it if possible.
--
Brian C. Lane | Anaconda
ould you do:
dd if=/dev/sda of=sda.disklabel.bin bs=1M count=1
and email the file to me?
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpli1TVhWlnC.pgp
Description: PGP signature
in
> use. You should reboot now before making further changes.
> Ignore/Cancel?
This means that parted is having trouble communicating the partition
changes to the kernel. I would start by filing a bug with whatever
distribution you are running on.
--
Brian C. Lane | Anaconda Team | IRC:
ther
the b (bytes) units or s (sectors). You can get machine readable output
by passing -m
I *DO NOT* recommend doing this. Especially without a backup of the
data. But you could remove the existing partition and then re-create it
with the same starting position and new end.
--
Brian C. Lane | Anacond
is *really* old at this point. You
should upgrade to 3.1 if you can.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpdzPZqJkwJw.pgp
Description: PGP signature
ointing people to the
> other repo. Having a read only auto synced copy is nice, but I'd
> rather not have to manually keep them both in sync, especially since I
> don't have write access to alioth :)
I agree, it is better to have people switch to the active repo sooner
than later.
arse the output, but maybe in the next major release we should just
drop it.
I have a bug tracking this in Fedora -
https://bugzilla.redhat.com/show_bug.cgi?id=767830
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpo2zW7iRYOd.pgp
Description: PGP signature
be able to enter bad numbers after the
warnings.
9/9 - Nak. I need more details here. The reasoning in the original
commit seems sound to me, and I'd be more worried about busy
devices than the filesystem not matching (I'm not sure we should
even be in the fs detec
is
myself what also includes support for the msdos partition type as well.
I need to send a number of patches to the list, including that one.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgp1daRXz7FFl.pgp
Description: PGP signature
From: "Brian C. Lane"
Add support for showing 'btrfs' in the 'file system' column. Also
allows the used to enter btrfs as the fs type. It doesn't really do
anything -- just sets the partition type to linux.
* NEWS (Changes in behavior): Mention it.
*
From: Nageswara R Sastry
Fixed Block Access (FBA) DASDs are mainframe-specific disk devices
which are layed out as a sequence of 512-byte sectors. In contrast
to ECKD DASDs, these disks do not require formatting and resemble
the LBA layout of non-mainframe disks. Despite this resemblance,
the Lin
From: "Brian C. Lane"
This adds support for the ESP partition type on MS-DOS. It also aliases
it to the boot flag on GPT which sets the ESP GUID type.
* NEWS (Changes in behavior): Mention it.
* doc/C/parted.8: Document esp flag.
* doc/parted.texti: Document esp flag.
* include/parted
From: Nageswara R Sastry
Extended Address Volume (EAV) DASDs are ECKD DASDs with more than
65520 cylinders. This patch adds support for recognizing and
modifying partitions on EAV DASDs to Parted. The changes are
based on the EAV support added to version 1.8.1 [1] of the
s390-tools package.
[1]
From: "Brian C. Lane"
This adds support for the irst partition type flag. Sets the type to
0x84 on MS-DOS and D3BFE2DE-3DAF-11DF-BA-40-E3A556D89593 on GPT.
* NEWS (Changes in behavior): Mention it.
* doc/C/parted.8: Document irst flag.
* doc/parted.texti: Document irst flag.
* incl
From: "Brian C. Lane"
Mac uses a HFS+ formatted partition for ESP. When dual booting with
Linux we need a way to differentiate between the Mac partition and the
one created by Linux which contains just enough stuff to fake OSX into
displaying a nice logo and allowing it to be selecte
From: "Brian C. Lane"
This is based on Peter Rajnoha's patch to use dm_udev_wait to
synchronize with udev.
This requires libdevmapper v1.02.39 and higher.
mailing list thread:
https://lists.gnu.org/archive/html/bug-parted/2010-09/msg7.html
* libparted/arch/linux.c (_dm_task
From: "Brian C. Lane"
Here is the stack of patches that I'm currently carrying for the master branch
of parted in Fedora. I think patches 1-12 have been posted before, but I
recently rebased things onto parted master. The patches adding new flags
(13-16) are all new.
Patch
From: Nageswara R Sastry
Fixed Block Access (FBA) DASDs are mainframe-specific disk devices
which are layed out as a sequence of 512-byte sectors. This patch adds
support for mklabel to properly handle FBA devices.
Signed-off-by: Nageswara R Sastry
---
libparted/labels/fdasd.c | 28 +++
From: "Brian C. Lane"
Parted probes for filesystems using geometry offsets into the parent
device, not the partition device itself. This means it may get stale
information if a partition has just been formatted.
On kernels before 2.6 this will also flush all partition devices. On 2.6
From: "Brian C. Lane"
* libparted/arch/linux.c (_dm_add_partition): Set the uuid if there was
one.
---
libparted/arch/linux.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
index 1c5faa5..375b
From: "Brian C. Lane"
* libparted/labels/gpt.c (gpt_duplicate): copy pmbr_boot flag
---
libparted/labels/gpt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libparted/labels/gpt.c b/libparted/labels/gpt.c
index 490de70..25490af 100644
--- a/libparted/labels/gpt.c
+++ b/libpar
From: "Brian C. Lane"
* tests/t6004-dm-many-partitions.sh: Make sure > 17 partitions appear in
device mapper.
---
tests/Makefile.am | 1 +
tests/t6004-dm-many-partitions.sh | 60 +++
2 files changed, 61 insertions(+)
creat
From: "Brian C. Lane"
This test began failing because using a private copy of /dev/mapper
confuses the system. This fixes that and generally cleans up the test.
tests/t6001.sh: update to use /dev/mapper directly
---
tests/t6001-psep.sh | 42 +---
From: "Brian C. Lane"
This is the same issue we have with /dev/mapper/ paths that was fixed in
commit c1eb485b9fd8919e18f192d678bc52b0488e6ee0. When libparted
is used to setup the device the symlink should be used to reference it,
not the backing device name which could change.
*
From: Nageswara R Sastry
This patch avoids setting 'dasd' as a default disk type for
'disk image file' at the time of probe.
Signed-off-by: Nageswara R Sastry
---
include/parted/fdasd.in.h | 1 +
libparted/labels/fdasd.c | 6 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git
From: "Brian C. Lane"
* tests/t6005-dm-uuid.sh: Make sure dm UUIDs are not erased
---
tests/Makefile.am | 1 +
tests/t6005-dm-uuid.sh | 58 ++
2 files changed, 59 insertions(+)
create mode 100755 tests/t6005-dm-uuid.sh
diff --g
From: Nageswara R Sastry
Extended Address Volume (EAV) DASDs are ECKD DASDs with more than
65520 cylinders. This patch adds support for mklabel to properly
handle unformatted EAV DASDs.
Signed-off-by: Nageswara R Sastry
---
include/parted/fdasd.in.h | 1 -
libparted/labels/fdasd.c | 92 +
From: "Brian C. Lane"
* tests/tests/t1700-probe-fs.sh: Add btrfs and xfs
---
tests/t1700-probe-fs.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/t1700-probe-fs.sh b/tests/t1700-probe-fs.sh
index 7ce53d0..0418e73 100755
--- a/tests/t1700-probe-fs.sh
+
From: "Brian C. Lane"
gpt-header-munge uses perl to manipulate the gpt header for the test. It
only works on 64 bit little-endian systems so restrict it to x86_64
only.
* tests/t0210-gpt-resized-partition-entry-array.sh: Skip if not x86_64
* tests/t0211-gpt-rewrite-header.sh: Skip if
Uhh, what the heck is up with the To: line and the subject lines? I sent these
to the list
address (bug-parted@gnu.org)
-
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
pgpKworXvYzc2.pgp
Description: PGP signature
on
> some of these, see comments inline.
>
> On 08/13/2013 11:46 PM, Phillip Susi wrote:
> > On 08/08/2013 08:45 PM, Brian C. Lane wrote:
> >> Commit messages need to follow the normal parted form. I'd also
> >> like to see tests as separate commits.
> >
On Wed, Sep 11, 2013 at 11:14:50PM -0400, Phillip Susi wrote:
> On 09/11/2013 05:51 PM, Brian C. Lane wrote:
> > Let me see if I understand the problem. The issue is that the disk
> > isn't right, the gpt backup is in the wrong location and currently
> > we will sorta
On Wed, Sep 11, 2013 at 12:25:05PM -0700, Brian C. Lane wrote:
> From: "Brian C. Lane"
>
> Mac uses a HFS+ formatted partition for ESP. When dual booting with
> Linux we need a way to differentiate between the Mac partition and the
> one created by Linux which contains
to look it up by that same path it won't
find it if the symlink is followed and the name changed.
Personally, I can't think of a situation where I'd ever want the name I
give it to be changed, whether I'm using the cli or libparted. Maybe we
should drop that whole bit and just use t
ow, and made sure #8 does not allow the user to create the errors. I
> just wanted to make sure that you came around on #6 and #9 before I
> push them.
Yes, I think those should be ok.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
here a way/parted
> version that can display the size of an unalabeled drive? I am using
> parted-1.8.1-28.el5
Newer versions of parted (eg. 3.1) handle this just fine.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
I was of help.
Is this reproducible and could you provide the steps you used to create the
device?
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
t; If more information is wanted, please ask.
parted's filesystem detection should not be depended on, it is for
cosmetic purposes only. I'm not sure what gparted is doing, but it
shouldn't be failing because of libparted's fs display.
Also, how was the fs created? If I use mkfs.vfa
On Fri, Feb 28, 2014 at 01:22:28PM -0500, Phillip Susi wrote:
> On 9/11/2013 3:24 PM, Brian C. Lane wrote:
> > From: "Brian C. Lane"
> >
> > * tests/t6004-dm-many-partitions.sh: Make sure > 17 partitions
> > appear in device mapper.
>
> W
On Fri, Feb 28, 2014 at 02:15:52PM -0500, Phillip Susi wrote:
> On 9/11/2013 3:25 PM, Brian C. Lane wrote:
> > From: "Brian C. Lane"
> >
> > gpt-header-munge uses perl to manipulate the gpt header for the
> > test. It only works on 64 bit little-endian syst
On Sat, Mar 01, 2014 at 09:57:38PM -0500, Phillip Susi wrote:
> On 02/28/2014 02:29 PM, Brian C. Lane wrote:
> >>> gpt-header-munge uses perl to manipulate the gpt header for
> >>> the test. It only works on 64 bit little-endian systems so
> >>> restr
; int fd;
>
> --
> 1.8.3.2
Ack. A quick grep shows that this may be the last 16 limit left :)
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
t (buf, 0, strlen (LOOP_SIGNATURE));
> - return ped_device_write (disk->dev, buf, 0, 1);
> - }
> -
> memset (buf, 0, buflen);
> strcpy (buf, LOOP_SIGNATURE);
>
> -int write_ok = ped_device_write (disk->dev, buf, 0, 1);
> -free (buf);
> - return write_ok;
> +if (ped_device_write (disk->dev, buf, 0, 1))
> + return 1;
> + return 0;
It looks like this leaks buf everywhere it returns.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
(!ped_geometry_read(geom, sb_v, 0, sectors))
> return NULL;
> - struct ext2_super_block *sb = sb_v;
> + struct ext2_super_block *sb = (struct ext2_super_block *)(sb_v + 1024);
It would probably be more readable to just read_alloc the first 4 blocks
and then point *
> if (dev->boot_dirty && dev->type != PED_DEVICE_FILE) {
> ped_exception_throw (
> PED_EXCEPTION_WARNING,
Looks like _done could use some indentation fixes, may as well clean it
up while you're changing it.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
On Mon, Mar 17, 2014 at 09:51:18PM -0400, Phillip Susi wrote:
> On 03/03/2014 07:36 PM, Phillip Susi wrote:
> > On 03/03/2014 02:45 PM, Brian C. Lane wrote:
> >> Do our tests already cover all of these filesystems?
> >
> > I think so but now that I look at this aga
While rebasing parted for Fedora rawhide I ran into a couple of problems. These
patches fix them up and all tests pass, both in a mockbuild and as root on
rawhide.
Brian C. Lane (4):
libparted: Check AlternateLBA against LBA-1
tests: Fix the t0281 test to respond to the backup GPT location
---
tests/t0281-gpt-grow.sh | 3 ++-
tests/t0282-gpt-move-backup.sh| 3 ++-
tests/t0283-overlap-partitions.sh | 6 --
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/t0281-gpt-grow.sh b/tests/t0281-gpt-grow.sh
index 44a743b..ff36b79 100644
--- a/tests/t0281-g
commit 9e9588c71e introduced a problem with how the backup gpt
partition's location was checked, and where it was re-written. It was
using LastUsableLBA plus an offset based on the number of partition
entries. This will not always match up with the end of the disk. eg.
during t0210 where the number
This fixes the test so that it will fix the backup GPT location as well
as expand move the LastUsableLBA to cover the larger disk.
* tests/t0281-gpt-grow.sh: Add backup GPT prompt
---
tests/t0281-gpt-grow.sh | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/t0281-gpt-g
xxd isn't present in minimal build systems, as it is part of vim. Change
to using a simple python script to mangle the msdos disklabel for the
test.
* tests/msdos-overlap.py: New file
* tests/t0283-overlap-partitions.sh: Use msdos-overlap.py
---
tests/msdos-overlap.py| 25
On Wed, Mar 26, 2014 at 10:28:00PM -0400, Phillip Susi wrote:
> On 03/26/2014 01:56 PM, Brian C. Lane wrote:
> > This fixes the test so that it will fix the backup GPT location as
> > well as expand move the LastUsableLBA to cover the larger disk.
> >
> > * tests/t0281-
1 - 100 of 315 matches
Mail list logo
