[RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Jonathan Nieder
Hi, The inimitable Stephen Powell sent something like the two patches below to . It seems that they teach the dasd driver in parted to handle CMS-labeled partitions, which are a little more flexible and probably more common than the LDL format libparted already supp

[RFC/PATCH 1/2] dasd: take sector size into account when calculating starting block

2010-04-17 Thread Jonathan Nieder
From: Stephen Powell Fix a bug in which the starting block of the partition is incorrectly calculated for LDL disks if the block size is not 4906. In the old Linux Disk Layout, there is a single implicit partition on the disk. The first two physical blocks on the disk (for a CKD DASD device) ar

[RFC/PATCH 2/2] dasd: add read-only support for CMS labeled minidisks

2010-04-17 Thread Jonathan Nieder
From: Stephen Powell CMS-formatted disks are supported by the S/390 Linux kernel, but they are not supported by parted. Correct the omission. As before, the DASD driver only supports Extended Count Key Data devices. Just as for LDL disks, for an CMS formatted disk which has been processed by t

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Adam Thornton
I no longer have easy access to a system with CMS disks either, but I do remember that Rick Troth wrote cmsfs for Linux in the first place and I think his tool set included a couple of CMS disk images to test against. That might be helpful--although since none of them were images of CMS RESERV

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Jim Meyering
Jonathan Nieder wrote: > The inimitable Stephen Powell sent something like the two patches > below to . It seems that they teach > the dasd driver in parted to handle CMS-labeled partitions, which are > a little more flexible and probably more common than the LDL for

[PATCH] doc: add HACKING

2010-04-17 Thread Jim Meyering
FYI, I've just pushed this and expect to have to adjust it. Not everything in it is true yet (e.g., leading TABs), but that should change soon. Of course, it'll take some work to make these style and indentation preferences sensible. >From 4fad0d64af8690b4c9f164eacd034eb8a53998e3 Mon Sep 17 00:

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Stephen Powell
On Fri, 16 Apr 2010 23:46:26 -0400 (EDT), Jonathan Nieder wrote: > > The inimitable Stephen Powell sent something like the two patches > below to . It seems that they teach > the dasd driver in parted to handle CMS-labeled partitions, which are > a little more flexi

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Stephen Powell
On Sat, 17 Apr 2010 11:01:10 -0400 (EDT), Adam Thornton wrote: > > I think that CMS disks can have a different logical block size than the > underlying DASD, but I also suspect that case is vary rare. Not on CKD DASD. On CKD DASD, the CMS minidisk block size is the physical blocksize. On FBA D

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Stephen Powell
On Sat, 17 Apr 2010 11:10:04 -0400 (EDT), Jim Meyering wrote: > > Thanks for preparing those. > Can either of you outline a test for each that would fail before > application of a patch and succeed after it? For the first problem, the invalid starting block for an LDL disk, the failure would invo

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Jim Meyering
Stephen Powell wrote: > On Sat, 17 Apr 2010 11:10:04 -0400 (EDT), Jim Meyering wrote: >> >> Thanks for preparing those. >> Can either of you outline a test for each that would fail before >> application of a patch and succeed after it? > > For the first problem, the invalid starting block for an LD

Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

2010-04-17 Thread Jonathan Nieder
Stephen Powell wrote: > What I propose is four 1-cylinder minidisk > images of a 3390 DASD device. They will be (a) a non-reserved > CMS minidisk with no filesystem (mkfs or mkswap has never been run > on the partition), (b) a non-reserved CMS minidisk with an ext3 > filesystem on it, (c) a reser