unclarities in message

Hi, In partprobe/partprobe.c it says: Inform the OS of partition table changes. -d, --no-update don't update the kernel To me "updating the kernel" means to install a new version of the kernel. But it seems that "don't inform the kernel" is the intended meaning. If so, then a bett

the test suite fails

Trying to install parted-.1.8.7 from an overlay produces this: [...] Making check in tests make[1]: Entering directory `/var/tmp/portage/sys-apps/parted-1.8.7/work/parted-1.8.7/tests' make check-TESTS make[2]: Entering directory `/var/tmp/portage/sys-apps/parted-1.8.7/work/parted-1.8.7/tests'

Re: the test suite fails

Benno Schulenberg <[EMAIL PROTECTED]> wrote: > Trying to install parted-.1.8.7 from an overlay produces this: Thanks for the report. What is an "overlay"? Please give enough information so that someone here can try to reproduce your problem. Also, when a test fails, please rerun it like e.g.,

New Dutch PO file for `parted'

Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file, for programs using the textual domain `parted', has been submitted by the team of translators taking care of the Dutch language. This particular file, along with all other PO files pertaining to the

translatable strings contain unnecessary formatting

In libparted/labels/fdasd.c and libparted/labels/vtoc.c the functions that print out error messages put several "%s" and "\n" in the gettextized strings, unnecessarily Patches that make this simpler are coming up in a minute. The patches also gettextize a few messages that were overlooked. F

[PATCH] Move formatting out of translatable strings.

And gettextize a few missed messages. --- include/parted/vtoc.h |1 - libparted/labels/vtoc.c | 26 +- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/include/parted/vtoc.h b/include/parted/vtoc.h index 3e79478..2e09caa 100644 --- a/include/parted/v

[PATCH] Move more formatting out of translatable strings.

Also gettextize a few more missed messages, and simplify some of them. --- include/parted/fdasd.h |1 - libparted/labels/fdasd.c | 88 ++ 2 files changed, 42 insertions(+), 47 deletions(-) diff --git a/include/parted/fdasd.h b/include/parted/fda

Re: the test suite fails

Jim Meyering wrote: > Benno Schulenberg <[EMAIL PROTECTED]> wrote: > > Trying to install parted-.1.8.7 from an overlay produces this: > > Thanks for the report. > What is an "overlay"? Something Gentoo-specific. > Also, when a test fails, please rerun it like e.g., > > cd tests && ./t1000-basic

Re: the test suite fails

Benno Schulenberg <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Benno Schulenberg <[EMAIL PROTECTED]> wrote: >> > Trying to install parted-.1.8.7 from an overlay produces this: >> >> Thanks for the report. >> What is an "overlay"? > > Something Gentoo-specific. Thanks, but that doesn't help

Re: unclarities in message

Benno Schulenberg <[EMAIL PROTECTED]> writes: > Hi, > > In partprobe/partprobe.c it says: > > Inform the OS of partition table changes. > > -d, --no-update don't update the kernel > > To me "updating the kernel" means to install a new version of the > kernel. But it seems that "don't i

Re: the test suite fails

Jim Meyering wrote: > Benno Schulenberg <[EMAIL PROTECTED]> wrote: > > * expecting success: $compare out /dev/null > > --- out 2007-05-16 14:47:00.0 + > > +++ /dev/null 2005-05-14 16:37:31.0 + > > @@ -1 +0,0 @@ > > - > > \ No newline at end of file > > * FAIL 3: expect no

Re: [PATCH] Move formatting out of translatable strings.

Here's a somewhat better version of that patch, removing the superflouus parentheses and some whitespace. Benno >From 8dd17aea731da4c064edb4c13c7e02b9b0da3012 Mon Sep 17 00:00:00 2001 From: Benno Schulenberg <[EMAIL PROTECTED]> Date: Wed, 16 May 2007 21:52:56 +0200 Subject: [PATCH] Move formatti

Re: unclarities in message

Otavio Salvador wrote: > Benno Schulenberg <[EMAIL PROTECTED]> writes: > > Better use the same word in both cases then: > > > > Inform the operating system about partition table changes. > > > > -d, --dry-run do not actually inform the operating system > > Ack. Can you provide a patch for i

Re: unclarities in message

Benno Schulenberg <[EMAIL PROTECTED]> wrote: > diff --git a/partprobe/partprobe.c b/partprobe/partprobe.c > index 1659100..e79193a 100644 > --- a/partprobe/partprobe.c > +++ b/partprobe/partprobe.c > @@ -57,7 +57,7 @@ > > static struct option const long_options[] = >{ > -{"no-update", no_a

Re: unclarities in message

Jim Meyering wrote: > Benno Schulenberg <[EMAIL PROTECTED]> wrote: > > -{"no-update", no_argument, NULL, 'd'}, > > +{"dry-run", no_argument, NULL, 'd'}, > > Looks good, but do not remove support for --no-update just yet. > Instead, mark it as deprecated, and with a comment suggesting > when

Re: unclarities in message

Benno Schulenberg <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Benno Schulenberg <[EMAIL PROTECTED]> wrote: >> > -{"no-update", no_argument, NULL, 'd'}, >> > +{"dry-run", no_argument, NULL, 'd'}, >> >> Looks good, but do not remove support for --no-update just yet. >> Instead, mark i

Re: the test suite fails

Benno Schulenberg <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Benno Schulenberg <[EMAIL PROTECTED]> wrote: >> > * expecting success: $compare out /dev/null >> > --- out 2007-05-16 14:47:00.0 + >> > +++ /dev/null 2005-05-14 16:37:31.0 + >> > @@ -1 +0,0 @@ >> > - >>

Re: the test suite fails

Jim Meyering wrote: > Benno Schulenberg <[EMAIL PROTECTED]> wrote: > > # dd if=/dev/zero of=FILE bs=1M count=1 2>/dev/null > > # parted -s FILE mklabel msdos >out 2>&1 > > # xxd out > > 000: 1b5b 3f31 3033 3468 .[?1034h > > That's probably coming from one of your startup do

Re: the test suite fails

Benno Schulenberg <[EMAIL PROTECTED]> wrote: > Jim Meyering wrote: >> Benno Schulenberg <[EMAIL PROTECTED]> wrote: >> > # dd if=/dev/zero of=FILE bs=1M count=1 2>/dev/null >> > # parted -s FILE mklabel msdos >out 2>&1 >> > # xxd out >> > 000: 1b5b 3f31 3033 3468 .[?1034h >>